Bug 18349: SCO - Do not trust the confirmed flag
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 29 Mar 2017 21:25:40 +0000 (18:25 -0300)
committerKatrin Fischer <katrin.fischer.83@web.de>
Sun, 16 Apr 2017 11:29:10 +0000 (13:29 +0200)
commitdbee200409d738fcf7c4fdcfb2cd19f5d6d36c04
treeacd33778e371ebf0a8ade1adc09b8ea9ae5d6e29
parent0a26e824ae3861fefb8a615c7e042fbfc83698f4
Bug 18349: SCO - Do not trust the confirmed flag

The "confirmed" flag is used to know if that user confirmed a situation
that needs a confirmation.
But if the issue/renew is impossible the CanBookBeIssued and the
'impossible flags' should be checked.

Otherwise a patron can checkout and renew bypassing the circulation
rules (Understand 'no limit' here...)

Test plan:
Want to renew?
Checkin $barcode, then
/cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout

Want to bypass the checkin?
Same url...

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 85bd15a83ffdab0c2e28eae54e50ce4dee9e608b)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
opac/sco/sco-main.pl