Bug 18349: SCO - Do not trust the confirmed flag
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 29 Mar 2017 21:25:40 +0000 (18:25 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 12 Apr 2017 18:47:01 +0000 (18:47 +0000)
commit85bd15a83ffdab0c2e28eae54e50ce4dee9e608b
tree1c7b4148c421a069fdbaba7c3c57410a0f401b5f
parent2471dab71dff052b546f45690d8a3bea6f1f3811
Bug 18349: SCO - Do not trust the confirmed flag

The "confirmed" flag is used to know if that user confirmed a situation
that needs a confirmation.
But if the issue/renew is impossible the CanBookBeIssued and the
'impossible flags' should be checked.

Otherwise a patron can checkout and renew bypassing the circulation
rules (Understand 'no limit' here...)

Test plan:
Want to renew?
Checkin $barcode, then
/cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout

Want to bypass the checkin?
Same url...

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
opac/sco/sco-main.pl