Updating Version Number to 3.02.05.000

Release Notes for 3.02.05.000

Security Bugfix: Bug 1953 Adding Placeholders to SQL To Avoid Potential Injection Attacks

This patch addresses both security issues mentioned in the summary of the report
submitted by Frère Sébastien Marie included below.

---------------------------
The problem is here: 'C4/AuthoritiesMarc.pm' in the function 'DelAuthority':
The argument $authid is included directly (not via statement) in the SQL.

For the exploit of this problem, you can use 'authorities/authorities-home.pl'
with authid on the URL and op=delete (something like
"authorities/authorities-home.pl?op=delete&authid=xxx").

This should successfully call DelAuthority, without authentification...
(DelAuthority is call BEFORE get_template_and_user, so before authentification
[This should be an issue also...]).

Please note that the problem isn't only that anyone can delete an authority of
this choose, it is more general: with "authid=1%20or%1=1" (after inclusion sql
will be like: "delete from auth_header where authid=1 or 1=1") you delete all
authorities ; with "authid=1;delete%20from%xxx" it is "delete from auth_header
where authid=1;delete from xxx" and so delete what you want...

SQL-INJECTION is very permissive: you can redirect the output in a file (with
some MySQL function), so write thea file of you choose in the server, in order
to create a backdoor, and compromise the server.

Signed-off-by: Frère Sébastien Marie <semarie-koha@latrappe.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b0f60221f41041665c4fecacce35654fc8d45a01)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

2742: Wrong language name in the preferences

Follow up patch. Improvement suggested by Belgian translators (Hans Supply).

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fc1b7201c55d00d6c43a0ecc04bee09cd0e0bde7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Partial fix for Bug 5745, Overdues with fines report not showing titles

- Adding title, subtitle, and author to output
- Reworking display of shelving location selection

Patch does not address the contents of 'overdue status' and 'notified by'

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 50c0ae09a12e10b851022d6b3fe18aa0b345a98b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5759 : displaying 2nd email if there is one on print template for borrowers

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2f9bebf802530ad1a96fe5bb5ced1b8ef02ba46f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5769 - notice tab disappearing on edit patron

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ed2b583eb10cb81c26c43714572bbb2c85d5797c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.04.000

Release Notes for 3.02.04.000

Translation update for 3.2.4
(cherry picked from commit 44c2af8d66e2fdb6036469a296238b6da41c880c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Revert "Partial fix for Bug 5745, Overdues with fines report not showing titles"

This reverts commit 65e478ca51a5b20d4b26c31213571f1344c42fbf.

Patch accidentally pushed which  introduces string changes.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Revert "Bug 5759 : displaying 2nd email if there is one on print template for borrowers"

This reverts commit 211dae9f01d27b6bcce1ddfd5737862bcaa592bc.

Patch accidentally pushed which introduces string changes.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Revert "Fix for Bug 5769 - notice tab disappearing on edit patron"

This reverts commit 31760556526f2cca3082e490384d30324b6deb8b.

Patch accidentally pushed which  introduces string changes.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5776 - menu on funds wraps when only 1 fund

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a0367aa973ad61eda090d743cccd9cf387dfcc09)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5741 - Extra comma causes JavaScript error in Internet Explorer

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1f0e0c5de182cde0215ac0782563d89b3d04291b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5777 Update and install syspref tab titles

This allow also Save button label translation

[3.2] It applies

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit eaf4cfe6b8684b1fff6d7fc6b3b93a456f57fda8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

NormalizeString POD Fixing and variable renaming

    POD was mistakenly telling that NFD was supposed to be the default
    encoding.  In fact, it is not, it is NFC.
    So the variable $nfc to change to the not default encoding was misleading.
    Renaming it into $nfd

(written by hdl)

Refactored by Chris Cormack

Signed-off-by: Davi <davi@gnu.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4117b293f633597e74e3dda9e1e52810d31ad23d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5769 - notice tab disappearing on edit patron

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ed2b583eb10cb81c26c43714572bbb2c85d5797c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5140 - In Chrome, drop-down menus disappear after using pop-up calendar

Disabling that part of the calendar JavaScript which hides
<select> form fields when the calendar is displayed. This is at
the expense of IE6.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fb5ede8b59bb82e00736235e9ada293cc13e67e4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.03.003

Bug 2742 Followup patch fixing Norwegian bokmål, adding nynorsk

- Replace Norwegian with Norwegian bokmål
- Add Norwegian nynorsk, which was missing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5d82c493f76b609df48478219e75d901df80b055)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5760 : MT3137 : Adding jquery.tablesorter and jquery.tablesorter.pager support for readingrec.pl

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 761fa372977c753483c0b3378967d1f60a2bef2a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5759 : displaying 2nd email if there is one on print template for borrowers

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2f9bebf802530ad1a96fe5bb5ced1b8ef02ba46f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Partial fix for Bug 5745, Overdues with fines report not showing titles

- Adding title, subtitle, and author to output
- Reworking display of shelving location selection

Patch does not address the contents of 'overdue status' and 'notified by'

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 50c0ae09a12e10b851022d6b3fe18aa0b345a98b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Follow up on 5736: fix authorities record.abs

Follow up on 5736: Same problem with 100 and 100a in authorities/record.abs

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a33109f523b45e248e9f8a327cc165cfd97bdc27)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Follow up on bug 2742: Correct language names in install

Rename the phonetic name in about, just like an earlier patch did elsewhere.
Make the distinction between the two Dutch translations more clear.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d2cf30820f47379425802886a93476385844cc53)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5751 : Follow up patch, removing unused variable and fixing copyright
(cherry picked from commit f6be5ef20fb8428dac00f6d958ed5ca280fee07a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5751 : MT2690 fix members-home

This fix the members-home script to work with new letter search management, and delete not anymore used code/template

(written by Nahuel Angelinetti)

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 3be7a6d4588ef4b406eb324e14966a4ac66c708d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

updating some references from koha.org to koha-community.org
(cherry picked from commit e34f93a69a9a1b6915112318ce8aa9f7b053c6c9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5734 (MT3625) Fix column order in issue history

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit adb1aefaf346456d2c5c559c85391e0c129d6aaa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5649: changes the white/blacklisting to approved/rejected consistent wording

Changes the wording to approved/rejected to be consistent with other wording

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ace3f0b70a7db0de718cce56a1ec4920eb39a8cd)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4306: respect item-level_itypes when displaying item label batches

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Salvador Zaragoza Rubio <salvazm@masmedios.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 311d051f77fdc4c5d6081404aff28624bb93210c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5735: Expanding/collapsing cloned fields in editor takes original field

Adds corrected onclick response for expanding marc tags.
Removes some lines that did not work as promised.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit af1009da3d155b717b9c517a2992000e5f39eb94)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5727 Warning in log due to XSLT.pm

XSLT.pm add few syspref to MARCXML record send to be transformed by XSLT. If
one of those syspref doesn't exist, it generated a warning.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bfec5ef4c1d16b3dc4cccd3982883a21b09955a6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5230: Call number ranges in export don't give expected results.

If you entered low number and high number, you got only items that *exactly* matched either entry (if any).
If you enter only a low number, you got everying *lower* than that.
If you enter only a high number, you get everything *higher* than that.

This was a greater-than-less-than problem.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 050466ce2bfbb06108c32ca388a7acca3dca2e4c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Make 'about' show D Ruth Bavousett's name change

Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f889cbaa25680d482c5a0666ee26984eef046083)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Correcting the name of one of the developers. :)

Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f486e85c5b9bb0fe8b38987ccfe0a494ff45cefe)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4263: Remove duplicated lines from C4::Items

Merge of bug 4263 duplicates the bulk of
ModItemFromMarc causing compile time errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1a0b6ded11a22c8c1425e1bb4a7fdd61d3c46c5b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4263: Fix subfield ordering broken by earlier patch

Restores alpha sorting of item subfields in add/edit screen

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ea2ace41a44cba0485be9e7cbece5e4782d2ad38)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5733 : MT3531: Intranet cart is emptied when session is closed

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 94bd7ad545cfa996fe2ec58b5c9c3293bed8d3fa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5731 When No ccode is defined for an item, then moredetail.pl throws a 500 error

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1abf1ea2d009b15762bacd764fa5f66f915c6283)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5716 - Whitespace correction for browse shelf

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d7208f76bda9073df0452b85a7aa7e3649f20d0b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 3009 - Change items.content field so it prints due date by default

<items.content> in overdue notices prints issuedate instead of duedate by default.
This patch changes default to issues.date_due.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 224d2dee90237670672a7f2b212d5333852dd41f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Add markers to text in Javascript variable in order to be translate.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit de491849ac3565aab985efe7ff6bd26e45977ae8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5629 : Adding an HTML anchor in the link in order to choose the right tab when we click on the link

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b5c58f964a9f36b70d56d2ca9be6ffaf6a14605d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5702 : Adding if statement condition to highlight toggle

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 02824a0b08fd2178fa970277b0fe636c7ed3d1b9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

adding some copyright BibLibre statements

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d22001b1c49bf06ef86bf50855bdf0e6924c2a09)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5726 : MT1059 Follow-up : Fix merge reference selection presentation

    A change in global-staff.css messed the merge reference selection presentation

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3a29f37dff1c58a344822a52aa2bc5f030dd44f8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5718 : fix permission of moveitem = edit_items needed

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d251585f717203b3abc27ab1238a276cc6addbaf)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 2742 : Fix typo
(cherry picked from commit 403f53c0d841e2a9f5991d3e6a9cb7704a83cf40)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5616: Corrects an utf-8 encoding problem in cardviews

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 07731037ee453fe3537c257b07be9c49b66e8ced)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.03.002

Bug 2742 Correct language names in install

Correct native versions of Danish and Dutch

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d1a06829f60ba5371e649239488fdfa838883de4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating history docs
(cherry picked from commit 0060b10af9acdc9eb0b5529d96de29375b8c79d0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5700: MT4004 : additem.pl Some Status were not defaulted to the correct value Status 0 was lost because test was done on value and not on the fact that a value was defined or not. when value is 0 then it was not used as default value for

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 14422c8ed9df29a6b89e8afe69c4d05056618124)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5699: don't discard $3 when building a record (UNIMARC specific)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 60e0a76fc027ff8d97c3630fce0a7b8222b6d5fd)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5691 - Delete all items respects independentbranches system preferences

Squashed commit of the following:

commit 66cdb8804136803a3f626d183c8f192f61f3c7b1
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:55:10 2011 +1300

    Bug 5691: Updating copyright statement

commit 79ef6c269afc9c644c51709a7657542a0fc6d7d6
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:52:13 2011 +1300

    Bug 5691 - Fixing a syntax error and tidying up some formatting

commit a66485dba113c05ed51a3b4ff19f788e335aa1f6
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Tue Oct 5 17:23:55 2010 +0200

    (MT #1365) Delete all items

    Using DelItemCheck in cataloguing/additem.pl
    when deleting all items

commit fe845fd48ab22ff82ad6d8971c468c327b49f3c4
Author: Christophe Croullebois <christophe.croullebois@biblibre.com>
Date:   Wed Sep 22 11:39:28 2010 +0200

    (MT #1365) Delete all items

    Now if IndependantBranches is on and a user try to delete all items, only the items of his branch will be deleted.
    A message explain this fact.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Followup: (MT #1365) Fixing up the English idiom
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a4cc394508182f292b4767504dfbac882744c3df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5532 - sysprefs editor should show names of saved prefs

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7acfb3a17f9ab592b385b032c93c96d6894ff821)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5689 - System preference notifications are not translatable

Defining strings in the template so that they can be translated.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aac253a5e0192b14dfa23e34c76629020c392bca)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5115, Tags JavaScript includes many untranslatable strings

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dec6be9148ec28b240015762cdeb7019fbfadeb6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5690

MT3947: items.timestamp were not updated on edition

If items.timestamp is used in the framework and hidden
the fact that it is NOT deleted before update is done would input the previous timestamp,
which is not the desired behaviour.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 60dd25b5c230249581a9736458aad4bad783dd52)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fixing a syntax error, that snuck in with a merge
(cherry picked from commit e29aca325d199468673365ee7540760b38630833)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 3319 - Need error message when adding patron and libraries are defined

- Hiding patron add toolbar when branches or categories are undefined
- Blocking patron entry form if branches or categories are undefined
- Removing nonfunctional template logic for displaying missing category
  error message.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e6a3029470501b3a8269986c1448d5f8b2d6b7f2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 3212 Force leader 9 position to 'a' for new biblios

When Creating a new biblio record, if the cataloguer doesn't use the leader
plugin, a biblio record can be saved with a leader not containing a 'a' in 9
position. If the biblio contains UTF-8 characters, its decoding can fail.

This issue applies to MARC-21 not UNIMARC.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f1f36a0c940fa53a5671b379a31d77c2cbe40a7f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5673: test guarantorid consistently

Incorrect checking of guarantorid was causing moremember.pl to
try and construct addresses using data from non-existent guarantors
ensure that test is consistently checking that value is defined and not
'', '0' or 0 [ i.e. what perl does for you anyway!!]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 49b5f77194ccf688e95b3fbb5f08ea5ba18f7f7e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 2341: items marked 'on order' not reserveable from search results

Items created as part of the acquisitions process, and assigned the temporary notforloan value of -1,
cannot be placed on hold from the search results in either the OPAC or staff client (the link is missing).

This patch changes the evaluation of items->notforloan from a Boolean (if $items->{notforloan}) to a comparison
(if $items->{notforloan} > 0).  Any notforloan status with a negative value can therefore be reserved.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f692123bf1b2b843d348a897852018caa04de76f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug: 4263 - Repeatable subfields in items

Squashed commit of the following:

commit f441094d5095d165eab18340c983a831cce8f6e0
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Mon Jul 5 20:33:23 2010 +0200

    bug4263 followup : Can't blank subfields

    Previous bug4263 reintroduced bug 2466: fix clearing item field
    This keeps bug4263 followup to be assigned (donot blank dateaccessioned)
    But also allow to blank item subfields.

commit 92889b766c41b48bdd0e3a33ca4b183b1e259805
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Apr 23 13:54:30 2010 +0200

    (bug #4263) dateaccessionned is cleaned on item modification

    Every item modification, date accessionned is cleaned, if there is no modification made, we must'nt reset to "undef" the value.

commit 5abb2db16b2564d32e84b7cc680acbc301d73179
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Mar 2 09:57:33 2010 +0100

    (bug #4263) fix the edition of items with repeatable subfields

    The subfield management in item level is broken, fields are concatenated in one field, and if the librarian edit it, the values are not selected.
    This big patch fix three things:
     1) saving fields that are stocked in SQL(using koha2marc mapping) are now well cut and separated in _REAL_ subfields
     2) loading records with repeatable subfields are now well returned
     3) Editing items with repeatable fields works well

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Bug 4263 Removing extranious block of code
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aa398ed055a7226ba02d6559b297cb172b3ce3df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4931: Stocking can be by homebranch or holding branch

Squashed commit of the following:

commit 105de81639cbac5084e4a5c099b19569043e69ff
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Jul 13 11:58:01 2010 +0200

    (bug #4931) fix forgottens input in buttons

    the previous patch missed an hidden input in next buttons that break next page. This fix it.

commit db00295a6b9d1d36fc888ba6a0558011fd6884ba
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Jul 2 15:27:59 2010 +0200

    (bug #4931) add the ability to choose home or holding branch in stocktaking

    This add radio box in stocktaking to base it on home or holdingbranch

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Bug 4391 Followup: Adding back lost declaration of $branchcode
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 35b47b6ff71ea2bcfc699ec35132756d01bfadd3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating history docs
(cherry picked from commit c269dfdeb49ac45d492edde5b1ad1f67d01aff65)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5661 Fix a problem when doing an authority search with no sort order

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 079796ed189541a0f04126c97e97cad50fb18783)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5681: Fixes leading zeroes in Add Mulpiple Copies

From Biblibre:
I don't know why, but removing sprintf solves the problems with leading zeroes
and the problems with large values.

(written by jean-andré santoni)

Note from Chris:

The width is never set, so the sprintf always defaults to a float, which
trims the leading zeros. I am not smart enough to figure out how to set
a valid width when calling it, and removing the sprintf seems to work
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 for
test results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4f7bcdcbae336d7cceb71b60f77a8ba2249b0f54)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5683 - it is possible to save corrupt records

This patch makes it impossible to save records with variables fields that don't
contain any subfields. Prior to this patch, link_bibs_to_authorities.pl would
sometimes corrupt records.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 428556cd130db0cfcffd6fe081f32dc1218a904f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.03.001

Updating Version Number to 3.02.03.001

Bug 4160: Currency conversion doesn't handle rates other than 100

Changes data type for currency.rate to accomodate bigger currency conversion rates.

FLOAT( 15, 5 )

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5665: Routing slip prints too wide for narrow printers

This patch switches off some min-width styling which causes right hand
of page to be clipped.

Work sponsored by Opus

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 241fa939b48b2eb7e87360f2e47073df0b64af25)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5452 - Overdue date color in borrower's today issues

Patch sent by Fridolyn SOMERS, but not in git format
(cherry picked from commit 1c461680c89fb73d0df55260dc9173899bcd032b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

BUG 5649: Change wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Changes the wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 460a7b566bded878b4fd800f8baa98e83e32e38b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5477 [SIGN-OFF] Fix test cases that require database access

This moves the DB-requiring tests out of the way, with the exception of
00-load.t which is used by the git hooks. For it, it makes it skip
loading problematic modules. This allows 'make test' to complete successfully
without a database configured, wich is a required part of making packages.

This has been tested against the v3.02.03 tag and the master branch.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9df2a4a8fc24ebb693ffb80a218b12137f8b282d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5376: Batch Mod and Delete require superlibrarian permissions

This only occurs with IndependantBranches turned on; in an attempt to check that the items being
modified belonged to the user's branch, the code made a simultaneous comparison and assignment,
which is not permitted in all compilations of Perl.

Splitting the assignment of $itembranchcode and the check for its non-null value fixes the problem

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 12c116236f0f686005bbe035659778012bcaf862)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Translation updates

- Two new languages:

  . sd-PK - Sindhi
  . is-IS - Icelandic

- Fix a naming error for nb-NO and nn-NO
(cherry picked from commit 671419dcce781aa01f300012f0f425c040749f73)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5654: remove disused directory

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 34ba87625a80701cce7a1ffca9fab1f3691bb3ab)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Adding Jerome Charaoui to the history docs, 130 people have code in Koha now
(cherry picked from commit 7f4771588e08dc418d304f249efad03dde67fdbb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

History updated
(cherry picked from commit 7d87094fc84a88584af72f27e10509b2ef5416de)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5506 Fix installation of prefs translations in standard installs

[3.2] Should be applied

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1fc16ea5431eba97b7562a94e6493249d4e700f7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.03.000

Release Notes for 3.02.03.000

Bug 5327 fixing missing number of tests
(cherry picked from commit d64008644a72d88e8ab5442cb24ff64d23665a8f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added more unit tests to check when JSONStream should fail.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5f0f2e297a7d7e51dc7503493025c14d39944757)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: Added unit tests to Output_JSONStream.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 434d9a3c66c54c028c971a0bd59312d099ba358a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: small typo in the Members.t test
(cherry picked from commit 1c89ce34b914cd5247cb6103b9bda5cde9720dcb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Made test file for Accounts.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 669280c7ab200637f06a5b6852409f7207f68403)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: Shifting and little tidy up of the members tests
(cherry picked from commit 314772637ce23285defd5372c772c3562c560fc2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Some tests added

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d567945517021ed093c7ec7c246514cea444df12)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent
(cherry picked from commit e03026adffe58561db842f7dcf8dcb064539b224)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added unit tests to test all of get_amazon_tld in Amazon.pm.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b56121db026837e3d6d6e7e7f3800d7a5b92923c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: Little change to Record.t
(cherry picked from commit 23f92a8f8dcded82bf5c3b319f373350a011e078)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 1 more test added.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5aa80408756c14565481259a927ab40488a4bd00)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added unit tests for Biblio and moved it to db_dependent as it requires the database.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 65e2cda8d2dcb89c0af6b6bcf07118e05b0123e8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Cleaning up XISBN.t a bit
(cherry picked from commit 4093615e9f2f79f8738769edbfb4b41733b284da)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 - Fixing a path issue with XISBN.t
(cherry picked from commit 71a7d2ad389ff946c5fc65293240caf3d3e290f6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>