Bug 21829: Add tests for dateexpiry format in notices

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 04e121a741a442f5b557e11864eb69be9d0c3ded)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 1106c0fa595c8378807bc955b29c2f83c2af5ba9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f7bcb149d57cf55ff075d6f41cbecbb310218c9e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t
index 84fbaac..ec04155 100644 (file)
--- a/t/db_dependent/Letters.t
+++ b/t/db_dependent/Letters.t
@@ -399,6 +399,21 @@ $dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('orde
     is( $values->{dateexpiry}, '2015-12-13', "_parseletter doesn't modify its parameters" );
 }
 
+# Correctly format dateexpiry
+{
+    my $values = { dateexpiry => '2015-12-13', };
+
+    t::lib::Mocks::mock_preference('dateformat', 'metric');
+    t::lib::Mocks::mock_preference('timeformat', '24hr');
+    my $letter = C4::Letters::_parseletter({ content => "expiry on <<borrowers.dateexpiry>>"}, 'borrowers', $values);
+    is( $letter->{content}, 'expiry on 13/12/2015' );
+
+    t::lib::Mocks::mock_preference('dateformat', 'metric');
+    t::lib::Mocks::mock_preference('timeformat', '12hr');
+    $letter = C4::Letters::_parseletter({ content => "expiry on <<borrowers.dateexpiry>>"}, 'borrowers', $values);
+    is( $letter->{content}, 'expiry on 13/12/2015' );
+}
+
 my $bookseller = Koha::Acquisition::Bookseller->new(
     {
         name => "my vendor",