Bug 17347: Ignore whitespace before and after on renewing
authorKatrin Fischer <katrin.fischer.83@web.de>
Mon, 14 Jan 2019 05:41:48 +0000 (05:41 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 15 Feb 2019 07:09:06 +0000 (08:09 +0100)
When an item is checked out, Koha ignores whitespace
at the beginning and the end of the entered barcode.
This makes life easier, if a barcode is C&P from another
page. This patch makes the renewal page behave the same.

To test:
- Checkout an item
- Renew the item from the renew tab or renewal page
  entering the barcode with leading and trailing
  whitespace
- "Barcode not found"
- Apply patch
- Try again
- Barcode should be found now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 0e220869f5a3327eee8f9426d648fbcaaa0fd7fa)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 7c881b32b5f7bfca6ccb17b8ddc8045ad37a3524)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 3c9af06611d0642ab96d51ca1c249a8e14a52805)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

circ/renew.pl

index 246c266..5304f40 100755 (executable)
@@ -52,6 +52,7 @@ my $error = q{};
 my ( $soonest_renew_date, $latest_auto_renew_date );
 
 if ($barcode) {
+    $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace
     $item = $schema->resultset("Item")->single( { barcode => $barcode } );
 
     if ($item) {