Bug 24279: Claims Returned does not work when set from additem.pl
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 30 Dec 2019 13:04:29 +0000 (08:04 -0500)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 27 Jul 2020 15:05:06 +0000 (17:05 +0200)
Test Plan:
1) Configure Claimes Returned
2) Apply this patch
3) Go to additem.pl for that item
4) Note the claims returned lost status does not show in the lost status pulldown

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

cataloguing/additem.pl

index 130ff0a..9f37537 100755 (executable)
@@ -170,7 +170,17 @@ sub generate_subfield_form {
             my @authorised_values;
             my %authorised_lib;
             # builds list, depending on authorised value...
-            if ( $subfieldlib->{authorised_value} eq "branches" ) {
+            if ( $subfieldlib->{authorised_value} eq "LOST" ) {
+                  my $ClaimReturnedLostValue = C4::Context->preference('ClaimReturnedLostValue');
+                  push @authorised_values, qq{};
+                  my $av = GetAuthorisedValues( $subfieldlib->{authorised_value} );
+                  for my $r ( @$av ) {
+                      next if $ClaimReturnedLostValue && $r->{authorised_value} eq $ClaimReturnedLostValue;
+                      push @authorised_values, $r->{authorised_value};
+                      $authorised_lib{$r->{authorised_value}} = $r->{lib};
+                  }
+            }
+            elsif ( $subfieldlib->{authorised_value} eq "branches" ) {
                 foreach my $thisbranch (@$branches) {
                     push @authorised_values, $thisbranch->{branchcode};
                     $authorised_lib{$thisbranch->{branchcode}} = $thisbranch->{branchname};