Bug 24279: Claims Returned does not work when set from moredetail.pl
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 30 Dec 2019 12:51:23 +0000 (07:51 -0500)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 27 Jul 2020 15:05:06 +0000 (17:05 +0200)
Test Plan:
1) Configure Claimes Returned
2) Apply this patch
3) Go to moredetail.pl for that item
4) Note the claims returned lost status does not show in the lost status pulldown

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt

index 62352fc..5e639f7 100644 (file)
@@ -99,6 +99,7 @@
             [% IF itemlostloop %]
                 <li><span class="label">Lost status:</span>
                     [% IF ( CAN_user_circulate ) %]
+                        [% SET ClaimReturnedLostValue = Koha.Preference('ClaimReturnedLostValue') %]
                         <form action="updateitem.pl" method="post">
                             <input type="hidden" name="biblionumber" value="[% ITEM_DAT.biblionumber | html %]" />
                             <input type="hidden" name="biblioitemnumber" value="[% ITEM_DAT.biblioitemnumber | html %]" />
                             <select name="itemlost" >
                                 <option value="">Choose</option>
                                 [% FOREACH itemlostloo IN itemlostloop %]
+                                    [% NEXT IF ClaimReturnedLostValue && !ITEM_DAT.itemlost && itemlostloo.authorised_value == ClaimReturnedLostValue #Filter claims returned status from pulldown %]
                                     [% IF itemlostloo.authorised_value == ITEM_DAT.itemlost %]
                                         <option value="[% itemlostloo.authorised_value | html %]" selected="selected">[% itemlostloo.lib | html %]</option>
                                     [% ELSE %]
                             <input type="hidden" name="withdrawn" value="[% ITEM_DAT.withdrawn | html %]" />
                             <input type="hidden" name="damaged" value="[% ITEM_DAT.damaged | html %]" />
 
-                            [% SET ClaimReturnedLostValue = Koha.Preference('ClaimReturnedLostValue') %]
                             [% IF ClaimReturnedLostValue && ITEM_DAT.itemlost == ClaimReturnedLostValue %]
                                 <input type="submit" name="submit" class="submit" value="Set status" disabled="disabled"/>
                                 <p class="help-block">Item has been claimed as returned.</p>