Bug 24705: Holds placed via SIP will be given first priority
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 21 Feb 2020 14:41:27 +0000 (09:41 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 24 Feb 2020 09:57:07 +0000 (09:57 +0000)
The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1.

Test Plan:
1) Place a hold via SIP for a record with existing holds
2) Note the new hold is top priority
3) Apply this patch
4) Restart SIP
5) Repeat step 1
6) New hold should be last priority

Signed-off-by: Christofer Zorn <Christofer.Zorn@ajaxlibrary.ca>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

C4/SIP/ILS/Transaction/Hold.pm

index ecf8416..d51ebde 100644 (file)
@@ -66,8 +66,10 @@ sub do_hold {
         return $self;
     }
 
+    my $priority = C4::Reserves::CalculatePriority($item->biblionumber);
     AddReserve(
         {
+            priority       => $priority,
             branch         => $branch,
             borrowernumber => $patron->borrowernumber,
             biblionumber   => $item->biblionumber