From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Fri, 21 Feb 2020 14:41:27 +0000 (-0500)
Subject: Bug 24705: Holds placed via SIP will be given first priority
X-Git-Url: http://git.equinoxoli.org/?p=koha-equinox.git;a=commitdiff_plain;h=8a6dd41d3a31e318f14df91ede8f90a10c89df5f

Bug 24705: Holds placed via SIP will be given first priority

The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1.

Test Plan:
1) Place a hold via SIP for a record with existing holds
2) Note the new hold is top priority
3) Apply this patch
4) Restart SIP
5) Repeat step 1
6) New hold should be last priority

Signed-off-by: Christofer Zorn <Christofer.Zorn@ajaxlibrary.ca>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---

diff --git a/C4/SIP/ILS/Transaction/Hold.pm b/C4/SIP/ILS/Transaction/Hold.pm
index ecf8416..d51ebde 100644
--- a/C4/SIP/ILS/Transaction/Hold.pm
+++ b/C4/SIP/ILS/Transaction/Hold.pm
@@ -66,8 +66,10 @@ sub do_hold {
         return $self;
     }
 
+    my $priority = C4::Reserves::CalculatePriority($item->biblionumber);
     AddReserve(
         {
+            priority       => $priority,
             branch         => $branch,
             borrowernumber => $patron->borrowernumber,
             biblionumber   => $item->biblionumber