Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 18 Jun 2020 13:01:36 +0000 (09:01 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 25 Jun 2020 08:39:37 +0000 (10:39 +0200)
commit017b67e6c52ab7b79a0187b1ca9fea220117f7ef
tree6b4c0bd0b3a93c88c5612bee3afc748042166edd
parent115eeada2b6f959997d21d0e0dd73606f1ca7324
Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name

This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode.
The subroutine hold_patron_bcode should always return an empty string, not undef.

Test Plan:
1) Using the SIP cli emulator, checkin an item that is not checked out
2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)"
   The hex number will almost certainly be different from this example
3) Apply this patch
4) Restart the SIP server
5) Run the SIP checkin again
6) Note the DA field is no longer present!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/SIP/ILS/Item.pm