4 use Test::More tests => 3;
7 use t::lib::TestBuilder;
15 my $schema = Koha::Database->new->schema;
16 $schema->storage->txn_begin;
18 subtest 'CancelExpiredReserves tests incl. holidays' => sub {
21 my $builder = t::lib::TestBuilder->new();
23 t::lib::Mocks::mock_preference('ExpireReservesOnHolidays', 0);
24 # Waiting holds could be cancelled only if ExpireReservesMaxPickUpDelay is set to "allow", see bug 19260
25 t::lib::Mocks::mock_preference('ExpireReservesMaxPickUpDelay', 1);
28 my $today = dt_from_string();
29 my $reserve_reservedate = $today->clone;
30 $reserve_reservedate->subtract(days => 30);
32 my $reserve1_expirationdate = $today->clone;
33 $reserve1_expirationdate->add(days => 1);
36 my $reserve1 = $builder->build({
39 reservedate => $reserve_reservedate,
40 expirationdate => $reserve1_expirationdate,
41 cancellationdate => undef,
47 CancelExpiredReserves();
48 my $r1 = Koha::Holds->find($reserve1->{reserve_id});
49 ok($r1, 'Reserve 1 should not be canceled.');
51 my $reserve2_expirationdate = $today->clone;
52 $reserve2_expirationdate->subtract(days => 1);
55 my $reserve2 = $builder->build({
58 reservedate => $reserve_reservedate,
59 expirationdate => $reserve2_expirationdate,
60 cancellationdate => undef,
66 CancelExpiredReserves();
67 my $r2 = Koha::Holds->find($reserve2->{reserve_id});
68 is($r2, undef,'reserve 2 should be canceled.');
70 # Reserve expired on holiday
71 my $reserve3 = $builder->build({
74 reservedate => $reserve_reservedate,
75 expirationdate => $reserve2_expirationdate,
77 cancellationdate => undef,
83 Koha::Caches->get_instance()->flush_all();
84 my $holiday = $builder->build({
85 source => 'SpecialHoliday',
89 month => $today->month,
91 title => 'My holiday',
96 CancelExpiredReserves();
97 my $r3 = Koha::Holds->find($reserve3->{reserve_id});
98 ok($r3,'Reserve 3 should not be canceled.');
100 t::lib::Mocks::mock_preference('ExpireReservesOnHolidays', 1);
101 CancelExpiredReserves();
102 $r3 = Koha::Holds->find($reserve3->{reserve_id});
103 is($r3, undef,'Reserve 3 should be canceled.');
106 subtest 'Test handling of waiting reserves by CancelExpiredReserves' => sub {
111 my $builder = t::lib::TestBuilder->new();
112 my $category = $builder->build({ source => 'Category' });
113 my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
114 my $biblio = $builder->build({ source => 'Biblio' });
115 my $bibnum = $biblio->{biblionumber};
116 my $item = $builder->build({ source => 'Item', value => { biblionumber => $bibnum }});
117 my $itemnumber = $item->{itemnumber};
118 my $borrowernumber = $builder->build({ source => 'Borrower', value => { categorycode => $category->{categorycode}, branchcode => $branchcode }})->{borrowernumber};
120 my $resdate = dt_from_string->add( days => -20 );
121 my $expdate = dt_from_string->add( days => -2 );
122 my $notexpdate = dt_from_string->add( days => 2 );
124 my $hold1 = Koha::Hold->new({
125 branchcode => $branchcode,
126 borrowernumber => $borrowernumber,
127 biblionumber => $bibnum,
129 reservedate => $resdate,
130 expirationdate => $notexpdate,
134 my $hold2 = Koha::Hold->new({
135 branchcode => $branchcode,
136 borrowernumber => $borrowernumber,
137 biblionumber => $bibnum,
139 reservedate => $resdate,
140 expirationdate => $expdate,
144 my $hold3 = Koha::Hold->new({
145 branchcode => $branchcode,
146 borrowernumber => $borrowernumber,
147 biblionumber => $bibnum,
148 itemnumber => $itemnumber,
150 reservedate => $resdate,
151 expirationdate => $expdate,
155 t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 0 );
156 CancelExpiredReserves();
157 my $count1 = Koha::Holds->search->count;
158 is( $count1, 2, 'Only the non-waiting expired holds should be cancelled');
160 t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 1 );
161 CancelExpiredReserves();
162 my $count2 = Koha::Holds->search->count;
163 is( $count2, 1, 'Also the waiting expired hold should be cancelled now');
167 subtest 'Test handling of in transit reserves by CancelExpiredReserves' => sub {
170 my $builder = t::lib::TestBuilder->new();
172 t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 1 );
173 my $expdate = dt_from_string->add( days => -2 );
174 my $reserve = $builder->build({
177 expirationdate => '2018-01-01',
179 cancellationdate => undef,
181 suspend_until => undef
184 my $count = Koha::Holds->search->count;
185 CancelExpiredReserves();
186 is(Koha::Holds->search->count, $count-1, "Transit hold is cancelled if ExpireReservesMaxPickUpDelay set");
188 t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 0 );
189 my $reserve2 = $builder->build({
192 expirationdate => '2018-01-01',
194 cancellationdate => undef,
196 suspend_until => undef
199 CancelExpiredReserves();
200 is(Koha::Holds->search->count, $count-1, "Transit hold is cancelled if ExpireReservesMaxPickUpDelay unset");
204 $schema->storage->txn_rollback;