3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 126;
26 use POSIX qw( floor );
28 use t::lib::TestBuilder;
37 use C4::Overdues qw(UpdateFine CalcFine);
40 use Koha::IssuingRules;
44 use Koha::CirculationRules;
45 use Koha::Subscriptions;
46 use Koha::Account::Lines;
47 use Koha::Account::Offsets;
50 my $schema = Koha::Database->schema;
51 $schema->storage->txn_begin;
52 my $builder = t::lib::TestBuilder->new;
53 my $dbh = C4::Context->dbh;
56 $dbh->{RaiseError} = 1;
58 my $cache = Koha::Caches->get_instance();
59 $dbh->do(q|DELETE FROM special_holidays|);
60 $dbh->do(q|DELETE FROM repeatable_holidays|);
61 $cache->clear_from_cache('single_holidays');
63 # Start with a clean slate
64 $dbh->do('DELETE FROM issues');
65 $dbh->do('DELETE FROM borrowers');
67 my $library = $builder->build({
70 my $library2 = $builder->build({
73 my $itemtype = $builder->build(
79 rentalcharge_daily => 0,
80 defaultreplacecost => undef,
85 my $patron_category = $builder->build(
91 BlockExpiredPatronOpacActions => -1, # Pick the pref value
96 my $CircControl = C4::Context->preference('CircControl');
97 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
100 homebranch => $library2->{branchcode},
101 holdingbranch => $library2->{branchcode}
105 branchcode => $library2->{branchcode}
108 # No userenv, PickupLibrary
109 t::lib::Mocks::mock_preference('IndependentBranches', '0');
110 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
112 C4::Context->preference('CircControl'),
114 'CircControl changed to PickupLibrary'
117 C4::Circulation::_GetCircControlBranch($item, $borrower),
118 $item->{$HomeOrHoldingBranch},
119 '_GetCircControlBranch returned item branch (no userenv defined)'
122 # No userenv, PatronLibrary
123 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
125 C4::Context->preference('CircControl'),
127 'CircControl changed to PatronLibrary'
130 C4::Circulation::_GetCircControlBranch($item, $borrower),
131 $borrower->{branchcode},
132 '_GetCircControlBranch returned borrower branch'
135 # No userenv, ItemHomeLibrary
136 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
138 C4::Context->preference('CircControl'),
140 'CircControl changed to ItemHomeLibrary'
143 $item->{$HomeOrHoldingBranch},
144 C4::Circulation::_GetCircControlBranch($item, $borrower),
145 '_GetCircControlBranch returned item branch'
149 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
150 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
152 # Userenv set, PickupLibrary
153 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
155 C4::Context->preference('CircControl'),
157 'CircControl changed to PickupLibrary'
160 C4::Circulation::_GetCircControlBranch($item, $borrower),
161 $library2->{branchcode},
162 '_GetCircControlBranch returned current branch'
165 # Userenv set, PatronLibrary
166 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
168 C4::Context->preference('CircControl'),
170 'CircControl changed to PatronLibrary'
173 C4::Circulation::_GetCircControlBranch($item, $borrower),
174 $borrower->{branchcode},
175 '_GetCircControlBranch returned borrower branch'
178 # Userenv set, ItemHomeLibrary
179 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
181 C4::Context->preference('CircControl'),
183 'CircControl changed to ItemHomeLibrary'
186 C4::Circulation::_GetCircControlBranch($item, $borrower),
187 $item->{$HomeOrHoldingBranch},
188 '_GetCircControlBranch returned item branch'
191 # Reset initial configuration
192 t::lib::Mocks::mock_preference('CircControl', $CircControl);
194 C4::Context->preference('CircControl'),
196 'CircControl reset to its initial value'
199 # Set a simple circ policy
200 $dbh->do('DELETE FROM issuingrules');
201 Koha::CirculationRules->search()->delete();
203 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
204 issuelength, lengthunit,
205 renewalsallowed, renewalperiod,
206 norenewalbefore, auto_renew,
223 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
225 # CanBookBeRenewed tests
226 C4::Context->set_preference('ItemsDeniedRenewal','');
227 # Generate test biblio
228 my $biblio = $builder->build_sample_biblio();
230 my $branch = $library2->{branchcode};
232 my $item_1 = $builder->build_sample_item(
234 biblionumber => $biblio->biblionumber,
236 replacementprice => 12.00,
240 $reused_itemnumber_1 = $item_1->itemnumber;
242 my $item_2 = $builder->build_sample_item(
244 biblionumber => $biblio->biblionumber,
246 replacementprice => 23.00,
250 $reused_itemnumber_2 = $item_2->itemnumber;
252 my $item_3 = $builder->build_sample_item(
254 biblionumber => $biblio->biblionumber,
256 replacementprice => 23.00,
262 my %renewing_borrower_data = (
264 surname => 'Renewal',
265 categorycode => $patron_category->{categorycode},
266 branchcode => $branch,
269 my %reserving_borrower_data = (
270 firstname => 'Katrin',
271 surname => 'Reservation',
272 categorycode => $patron_category->{categorycode},
273 branchcode => $branch,
276 my %hold_waiting_borrower_data = (
278 surname => 'Reservation',
279 categorycode => $patron_category->{categorycode},
280 branchcode => $branch,
283 my %restricted_borrower_data = (
284 firstname => 'Alice',
285 surname => 'Reservation',
286 categorycode => $patron_category->{categorycode},
287 debarred => '3228-01-01',
288 branchcode => $branch,
291 my %expired_borrower_data = (
294 categorycode => $patron_category->{categorycode},
295 branchcode => $branch,
296 dateexpiry => dt_from_string->subtract( months => 1 ),
299 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
300 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
301 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
302 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
303 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
305 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
306 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
307 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
314 my $checkitem = undef;
317 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
318 my $datedue = dt_from_string( $issue->date_due() );
319 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
321 my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
322 $datedue = dt_from_string( $issue->date_due() );
323 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
326 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
327 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
329 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
330 is( $renewokay, 1, 'Can renew, no holds for this title or item');
333 # Biblio-level hold, renewal test
335 $branch, $reserving_borrowernumber, $biblio->biblionumber,
336 $bibitems, $priority, $resdate, $expdate, $notes,
337 'a title', $checkitem, $found
340 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
341 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
342 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
343 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
344 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
345 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
346 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
348 # Now let's add an item level hold, we should no longer be able to renew the item
349 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
351 borrowernumber => $hold_waiting_borrowernumber,
352 biblionumber => $biblio->biblionumber,
353 itemnumber => $item_1->itemnumber,
354 branchcode => $branch,
358 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
359 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
362 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
363 # be able to renew these items
364 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
366 borrowernumber => $hold_waiting_borrowernumber,
367 biblionumber => $biblio->biblionumber,
368 itemnumber => $item_3->itemnumber,
369 branchcode => $branch,
374 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
375 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
376 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
377 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
378 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
380 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
381 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
382 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
384 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
385 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
386 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
388 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
389 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
390 AddIssue($reserving_borrower, $item_3->barcode);
391 my $reserve = $dbh->selectrow_hashref(
392 'SELECT * FROM old_reserves WHERE reserve_id = ?',
396 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
398 # Item-level hold, renewal test
400 $branch, $reserving_borrowernumber, $biblio->biblionumber,
401 $bibitems, $priority, $resdate, $expdate, $notes,
402 'a title', $item_1->itemnumber, $found
405 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
406 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
407 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
409 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
410 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
412 # Items can't fill hold for reasons
413 ModItem({ notforloan => 1 }, $biblio->biblionumber, $item_1->itemnumber);
414 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
415 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
416 ModItem({ notforloan => 0, itype => $itemtype }, $biblio->biblionumber, $item_1->itemnumber);
418 # FIXME: Add more for itemtype not for loan etc.
420 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
421 my $item_5 = $builder->build_sample_item(
423 biblionumber => $biblio->biblionumber,
425 replacementprice => 23.00,
429 my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
430 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
432 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
433 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
434 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
435 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
436 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
438 # Users cannot renew an overdue item
439 my $item_6 = $builder->build_sample_item(
441 biblionumber => $biblio->biblionumber,
443 replacementprice => 23.00,
448 my $item_7 = $builder->build_sample_item(
450 biblionumber => $biblio->biblionumber,
452 replacementprice => 23.00,
457 my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
458 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
460 my $now = dt_from_string();
461 my $five_weeks = DateTime::Duration->new(weeks => 5);
462 my $five_weeks_ago = $now - $five_weeks;
463 t::lib::Mocks::mock_preference('finesMode', 'production');
465 my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
466 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
468 my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
469 C4::Overdues::UpdateFine(
471 issue_id => $passeddatedue1->id(),
472 itemnumber => $item_7->itemnumber,
473 borrowernumber => $renewing_borrower->{borrowernumber},
475 due => Koha::DateUtils::output_pref($five_weeks_ago)
479 t::lib::Mocks::mock_preference('RenewalLog', 0);
480 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
481 my %params_renewal = (
482 timestamp => { -like => $date . "%" },
483 module => "CIRCULATION",
487 timestamp => { -like => $date . "%" },
488 module => "CIRCULATION",
491 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
492 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
493 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
494 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
496 t::lib::Mocks::mock_preference('RenewalLog', 1);
497 $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
498 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
499 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
500 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
501 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
503 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
504 is( $fines->count, 2 );
505 is( $fines->next->accounttype, 'F', 'Fine on renewed item is closed out properly' );
506 is( $fines->next->accounttype, 'F', 'Fine on renewed item is closed out properly' );
510 my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
511 my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
512 AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
513 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
514 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
515 $new_log_size = Koha::ActionLogs->count( \%params_issue );
516 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
518 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
521 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
522 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
523 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
524 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
525 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
528 $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
532 # Test automatic renewal before value for "norenewalbefore" in policy is set
533 # In this case automatic renewal is not permitted prior to due date
534 my $item_4 = $builder->build_sample_item(
536 biblionumber => $biblio->biblionumber,
538 replacementprice => 16.00,
543 $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
544 ( $renewokay, $error ) =
545 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
546 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
547 is( $error, 'auto_too_soon',
548 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
551 # Test premature manual renewal
552 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
554 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
555 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
556 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
559 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
560 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
562 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
563 $datedue->clone->add( days => -7 ),
564 'Bug 14395: Renewals permitted 7 days before due date, as expected'
568 # Test 'date' setting for syspref NoRenewalBeforePrecision
569 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
571 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
572 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
573 'Bug 14395: Renewals permitted 7 days before due date, as expected'
577 # Test premature automatic renewal
578 ( $renewokay, $error ) =
579 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
580 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
581 is( $error, 'auto_too_soon',
582 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
585 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
586 # and test automatic renewal again
587 $dbh->do('UPDATE issuingrules SET norenewalbefore = 0');
588 ( $renewokay, $error ) =
589 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
590 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
591 is( $error, 'auto_too_soon',
592 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
595 # Change policy so that loans can be renewed 99 days prior to the due date
596 # and test automatic renewal again
597 $dbh->do('UPDATE issuingrules SET norenewalbefore = 99');
598 ( $renewokay, $error ) =
599 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
600 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
601 is( $error, 'auto_renew',
602 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
605 subtest "too_late_renewal / no_auto_renewal_after" => sub {
607 my $item_to_auto_renew = $builder->build(
610 biblionumber => $biblio->biblionumber,
611 homebranch => $branch,
612 holdingbranch => $branch,
617 my $ten_days_before = dt_from_string->add( days => -10 );
618 my $ten_days_ahead = dt_from_string->add( days => 10 );
619 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
621 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 9');
622 ( $renewokay, $error ) =
623 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
624 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
625 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
627 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 10');
628 ( $renewokay, $error ) =
629 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
630 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
631 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
633 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 11');
634 ( $renewokay, $error ) =
635 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
636 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
637 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
639 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
640 ( $renewokay, $error ) =
641 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
642 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
643 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
645 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => -1 ) );
646 ( $renewokay, $error ) =
647 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
648 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
649 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
651 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => -1 ) );
652 ( $renewokay, $error ) =
653 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
654 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
655 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
657 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 1 ) );
658 ( $renewokay, $error ) =
659 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
660 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
661 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
664 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew" => sub {
666 my $item_to_auto_renew = $builder->build({
669 biblionumber => $biblio->biblionumber,
670 homebranch => $branch,
671 holdingbranch => $branch,
675 my $ten_days_before = dt_from_string->add( days => -10 );
676 my $ten_days_ahead = dt_from_string->add( days => 10 );
677 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
679 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
680 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
681 C4::Context->set_preference('OPACFineNoRenewals','10');
682 my $fines_amount = 5;
683 my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
686 amount => $fines_amount,
688 item_id => $item_to_auto_renew->{itemnumber},
689 description => "Some fines"
691 )->accounttype('F')->store;
692 ( $renewokay, $error ) =
693 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
694 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
695 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
699 amount => $fines_amount,
701 item_id => $item_to_auto_renew->{itemnumber},
702 description => "Some fines"
704 )->accounttype('F')->store;
705 ( $renewokay, $error ) =
706 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
707 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
708 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
712 amount => $fines_amount,
714 item_id => $item_to_auto_renew->{itemnumber},
715 description => "Some fines"
717 )->accounttype('F')->store;
718 ( $renewokay, $error ) =
719 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
720 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
721 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
723 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
726 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
728 my $item_to_auto_renew = $builder->build({
731 biblionumber => $biblio->biblionumber,
732 homebranch => $branch,
733 holdingbranch => $branch,
737 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
739 my $ten_days_before = dt_from_string->add( days => -10 );
740 my $ten_days_ahead = dt_from_string->add( days => 10 );
742 # Patron is expired and BlockExpiredPatronOpacActions=0
743 # => auto renew is allowed
744 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
745 my $patron = $expired_borrower;
746 my $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
747 ( $renewokay, $error ) =
748 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
749 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
750 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
751 Koha::Checkouts->find( $checkout->issue_id )->delete;
754 # Patron is expired and BlockExpiredPatronOpacActions=1
755 # => auto renew is not allowed
756 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
757 $patron = $expired_borrower;
758 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
759 ( $renewokay, $error ) =
760 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
761 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
762 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
763 Koha::Checkouts->find( $checkout->issue_id )->delete;
766 # Patron is not expired and BlockExpiredPatronOpacActions=1
767 # => auto renew is allowed
768 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
769 $patron = $renewing_borrower;
770 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
771 ( $renewokay, $error ) =
772 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
773 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
774 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
775 Koha::Checkouts->find( $checkout->issue_id )->delete;
778 subtest "GetLatestAutoRenewDate" => sub {
780 my $item_to_auto_renew = $builder->build(
783 biblionumber => $biblio->biblionumber,
784 homebranch => $branch,
785 holdingbranch => $branch,
790 my $ten_days_before = dt_from_string->add( days => -10 );
791 my $ten_days_ahead = dt_from_string->add( days => 10 );
792 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
793 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = NULL');
794 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
795 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
796 my $five_days_before = dt_from_string->add( days => -5 );
797 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 5, no_auto_renewal_after_hard_limit = NULL');
798 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
799 is( $latest_auto_renew_date->truncate( to => 'minute' ),
800 $five_days_before->truncate( to => 'minute' ),
801 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
803 my $five_days_ahead = dt_from_string->add( days => 5 );
804 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = NULL');
805 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
806 is( $latest_auto_renew_date->truncate( to => 'minute' ),
807 $five_days_ahead->truncate( to => 'minute' ),
808 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
810 my $two_days_ahead = dt_from_string->add( days => 2 );
811 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 2 ) );
812 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
813 is( $latest_auto_renew_date->truncate( to => 'day' ),
814 $two_days_ahead->truncate( to => 'day' ),
815 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
817 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 2 ) );
818 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
819 is( $latest_auto_renew_date->truncate( to => 'day' ),
820 $two_days_ahead->truncate( to => 'day' ),
821 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
828 # set policy to forbid renewals
829 $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
831 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
832 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
833 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
835 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
836 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
837 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
839 C4::Overdues::UpdateFine(
841 issue_id => $issue->id(),
842 itemnumber => $item_1->itemnumber,
843 borrowernumber => $renewing_borrower->{borrowernumber},
846 due => Koha::DateUtils::output_pref($datedue)
850 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
851 is( $line->accounttype, 'FU', 'Account line type is FU' );
852 is( $line->lastincrement, '15.000000', 'Account line last increment is 15.00' );
853 is( $line->amountoutstanding, '15.000000', 'Account line amount outstanding is 15.00' );
854 is( $line->amount, '15.000000', 'Account line amount is 15.00' );
855 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
857 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
858 is( $offset->type, 'Fine', 'Account offset type is Fine' );
859 is( $offset->amount, '15.000000', 'Account offset amount is 15.00' );
861 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
862 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
864 LostItem( $item_1->itemnumber, 'test', 1 );
866 $line = Koha::Account::Lines->find($line->id);
867 is( $line->accounttype, 'F', 'Account type correctly changed from FU to F' );
869 my $item = Koha::Items->find($item_1->itemnumber);
870 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
871 my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
872 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
874 my $total_due = $dbh->selectrow_array(
875 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
876 undef, $renewing_borrower->{borrowernumber}
879 is( $total_due, '15.000000', 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
881 C4::Context->dbh->do("DELETE FROM accountlines");
883 C4::Overdues::UpdateFine(
885 issue_id => $issue2->id(),
886 itemnumber => $item_2->itemnumber,
887 borrowernumber => $renewing_borrower->{borrowernumber},
890 due => Koha::DateUtils::output_pref($datedue)
894 LostItem( $item_2->itemnumber, 'test', 0 );
896 my $item2 = Koha::Items->find($item_2->itemnumber);
897 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
898 ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
900 $total_due = $dbh->selectrow_array(
901 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
902 undef, $renewing_borrower->{borrowernumber}
905 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
907 my $future = dt_from_string();
908 $future->add( days => 7 );
909 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
910 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
912 # Users cannot renew any item if there is an overdue item
913 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
914 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
915 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
916 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
917 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
919 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
920 $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
921 LostItem( $item_3->itemnumber, 'test', 0 );
922 my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
923 is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
927 # GetUpcomingDueIssues tests
928 my $branch = $library2->{branchcode};
930 #Create another record
931 my $biblio2 = $builder->build_sample_biblio();
934 my $item_1 = Koha::Items->find($reused_itemnumber_1);
935 my $item_2 = Koha::Items->find($reused_itemnumber_2);
936 my $item_3 = $builder->build_sample_item(
938 biblionumber => $biblio2->biblionumber,
946 my %a_borrower_data = (
947 firstname => 'Fridolyn',
949 categorycode => $patron_category->{categorycode},
950 branchcode => $branch,
953 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
954 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
956 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
957 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
958 my $today = DateTime->today(time_zone => C4::Context->tz());
960 my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
961 my $datedue = dt_from_string( $issue->date_due() );
962 my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
963 my $datedue2 = dt_from_string( $issue->date_due() );
967 # GetUpcomingDueIssues tests
969 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
970 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
973 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
974 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
975 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
978 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
979 is ( scalar( @$upcoming_dues ), 1,
980 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
983 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
985 my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
987 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
988 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
990 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
991 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
993 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
994 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
996 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
997 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
999 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1000 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1002 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1003 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1008 my $branch = $library2->{branchcode};
1010 my $biblio = $builder->build_sample_biblio();
1013 my $item = $builder->build_sample_item(
1015 biblionumber => $biblio->biblionumber,
1022 my %a_borrower_data = (
1023 firstname => 'Kyle',
1025 categorycode => $patron_category->{categorycode},
1026 branchcode => $branch,
1029 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1031 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1032 my $issue = AddIssue( $borrower, $item->barcode );
1035 issue_id => $issue->id(),
1036 itemnumber => $item->itemnumber,
1037 borrowernumber => $borrowernumber,
1043 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1044 my $count = $hr->{count};
1046 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1050 $dbh->do('DELETE FROM issues');
1051 $dbh->do('DELETE FROM items');
1052 $dbh->do('DELETE FROM issuingrules');
1053 Koha::CirculationRules->search()->delete();
1056 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod,
1057 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
1066 Koha::CirculationRules->set_rules(
1068 categorycode => '*',
1076 my $biblio = $builder->build_sample_biblio();
1078 my $item_1 = $builder->build_sample_item(
1080 biblionumber => $biblio->biblionumber,
1081 library => $library2->{branchcode},
1086 my $item_2= $builder->build_sample_item(
1088 biblionumber => $biblio->biblionumber,
1089 library => $library2->{branchcode},
1094 my $borrowernumber1 = Koha::Patron->new({
1095 firstname => 'Kyle',
1097 categorycode => $patron_category->{categorycode},
1098 branchcode => $library2->{branchcode},
1099 })->store->borrowernumber;
1100 my $borrowernumber2 = Koha::Patron->new({
1101 firstname => 'Chelsea',
1103 categorycode => $patron_category->{categorycode},
1104 branchcode => $library2->{branchcode},
1105 })->store->borrowernumber;
1107 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1108 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1110 my $issue = AddIssue( $borrower1, $item_1->barcode );
1112 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1113 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1116 $library2->{branchcode}, $borrowernumber2, $biblio->biblionumber,
1117 '', 1, undef, undef, '',
1121 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
1122 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1123 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1124 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1126 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
1127 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1128 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1129 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1131 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
1132 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1133 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1134 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1136 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
1137 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1138 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1139 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1141 # Setting item not checked out to be not for loan but holdable
1142 ModItem({ notforloan => -1 }, $biblio->biblionumber, $item_2->itemnumber);
1144 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1145 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1149 # Don't allow renewing onsite checkout
1150 my $branch = $library->{branchcode};
1152 #Create another record
1153 my $biblio = $builder->build_sample_biblio();
1155 my $item = $builder->build_sample_item(
1157 biblionumber => $biblio->biblionumber,
1163 my $borrowernumber = Koha::Patron->new({
1166 categorycode => $patron_category->{categorycode},
1167 branchcode => $branch,
1168 })->store->borrowernumber;
1170 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1172 my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1173 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1174 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1175 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1179 my $library = $builder->build({ source => 'Branch' });
1181 my $biblio = $builder->build_sample_biblio();
1183 my $item = $builder->build_sample_item(
1185 biblionumber => $biblio->biblionumber,
1186 library => $library->{branchcode},
1191 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1193 my $issue = AddIssue( $patron, $item->barcode );
1196 issue_id => $issue->id(),
1197 itemnumber => $item->itemnumber,
1198 borrowernumber => $patron->{borrowernumber},
1205 issue_id => $issue->id(),
1206 itemnumber => $item->itemnumber,
1207 borrowernumber => $patron->{borrowernumber},
1212 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1215 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1218 my $homebranch = $builder->build( { source => 'Branch' } );
1219 my $holdingbranch = $builder->build( { source => 'Branch' } );
1220 my $otherbranch = $builder->build( { source => 'Branch' } );
1221 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1222 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1224 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1225 my $item = $builder->build(
1228 homebranch => $homebranch->{branchcode},
1229 holdingbranch => $holdingbranch->{branchcode},
1230 biblionumber => $biblioitem->{biblionumber}
1235 set_userenv($holdingbranch);
1237 my $issue = AddIssue( $patron_1->unblessed, $item->{barcode} );
1238 is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1240 my ( $error, $question, $alerts );
1242 # AllowReturnToBranch == anywhere
1243 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1244 ## Test that unknown barcodes don't generate internal server errors
1245 set_userenv($homebranch);
1246 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1247 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1248 ## Can be issued from homebranch
1249 set_userenv($homebranch);
1250 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1251 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1252 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1253 ## Can be issued from holdingbranch
1254 set_userenv($holdingbranch);
1255 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1256 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1257 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1258 ## Can be issued from another branch
1259 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1260 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1261 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1263 # AllowReturnToBranch == holdingbranch
1264 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1265 ## Cannot be issued from homebranch
1266 set_userenv($homebranch);
1267 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1268 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1269 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1270 is( $error->{branch_to_return}, $holdingbranch->{branchcode} );
1271 ## Can be issued from holdinbranch
1272 set_userenv($holdingbranch);
1273 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1274 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1275 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1276 ## Cannot be issued from another branch
1277 set_userenv($otherbranch);
1278 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1279 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1280 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1281 is( $error->{branch_to_return}, $holdingbranch->{branchcode} );
1283 # AllowReturnToBranch == homebranch
1284 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1285 ## Can be issued from holdinbranch
1286 set_userenv($homebranch);
1287 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1288 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1289 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1290 ## Cannot be issued from holdinbranch
1291 set_userenv($holdingbranch);
1292 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1293 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1294 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1295 is( $error->{branch_to_return}, $homebranch->{branchcode} );
1296 ## Cannot be issued from holdinbranch
1297 set_userenv($otherbranch);
1298 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1299 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1300 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1301 is( $error->{branch_to_return}, $homebranch->{branchcode} );
1303 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1306 subtest 'AddIssue & AllowReturnToBranch' => sub {
1309 my $homebranch = $builder->build( { source => 'Branch' } );
1310 my $holdingbranch = $builder->build( { source => 'Branch' } );
1311 my $otherbranch = $builder->build( { source => 'Branch' } );
1312 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1313 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1315 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1316 my $item = $builder->build(
1319 homebranch => $homebranch->{branchcode},
1320 holdingbranch => $holdingbranch->{branchcode},
1324 biblionumber => $biblioitem->{biblionumber}
1329 set_userenv($holdingbranch);
1331 my $ref_issue = 'Koha::Checkout';
1332 my $issue = AddIssue( $patron_1, $item->{barcode} );
1334 my ( $error, $question, $alerts );
1336 # AllowReturnToBranch == homebranch
1337 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1338 ## Can be issued from homebranch
1339 set_userenv($homebranch);
1340 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1341 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1342 ## Can be issued from holdinbranch
1343 set_userenv($holdingbranch);
1344 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1345 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1346 ## Can be issued from another branch
1347 set_userenv($otherbranch);
1348 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1349 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1351 # AllowReturnToBranch == holdinbranch
1352 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1353 ## Cannot be issued from homebranch
1354 set_userenv($homebranch);
1355 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1356 ## Can be issued from holdingbranch
1357 set_userenv($holdingbranch);
1358 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1359 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1360 ## Cannot be issued from another branch
1361 set_userenv($otherbranch);
1362 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1364 # AllowReturnToBranch == homebranch
1365 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1366 ## Can be issued from homebranch
1367 set_userenv($homebranch);
1368 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1369 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1370 ## Cannot be issued from holdinbranch
1371 set_userenv($holdingbranch);
1372 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1373 ## Cannot be issued from another branch
1374 set_userenv($otherbranch);
1375 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1376 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1379 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1382 my $library = $builder->build( { source => 'Branch' } );
1383 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1385 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1386 my $item_1 = $builder->build(
1389 homebranch => $library->{branchcode},
1390 holdingbranch => $library->{branchcode},
1391 biblionumber => $biblioitem_1->{biblionumber}
1395 my $biblioitem_2 = $builder->build( { source => 'Biblioitem' } );
1396 my $item_2 = $builder->build(
1399 homebranch => $library->{branchcode},
1400 holdingbranch => $library->{branchcode},
1401 biblionumber => $biblioitem_2->{biblionumber}
1406 my ( $error, $question, $alerts );
1408 # Patron cannot issue item_1, they have overdues
1409 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1410 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, $yesterday ); # Add an overdue
1412 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1413 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1414 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1415 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1417 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1418 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1419 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1420 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1422 # Patron cannot issue item_1, they are debarred
1423 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1424 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1425 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1426 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1427 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1429 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1430 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1431 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1432 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1435 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1438 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1439 my $patron_category_x = $builder->build_object(
1441 class => 'Koha::Patron::Categories',
1442 value => { category_type => 'X' }
1445 my $patron = $builder->build_object(
1447 class => 'Koha::Patrons',
1449 categorycode => $patron_category_x->categorycode,
1450 gonenoaddress => undef,
1457 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1458 my $item_1 = $builder->build(
1462 homebranch => $library->branchcode,
1463 holdingbranch => $library->branchcode,
1464 biblionumber => $biblioitem_1->{biblionumber}
1469 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->{barcode} );
1470 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
1472 # TODO There are other tests to provide here
1475 subtest 'MultipleReserves' => sub {
1478 my $biblio = $builder->build_sample_biblio();
1480 my $branch = $library2->{branchcode};
1482 my $item_1 = $builder->build_sample_item(
1484 biblionumber => $biblio->biblionumber,
1486 replacementprice => 12.00,
1491 my $item_2 = $builder->build_sample_item(
1493 biblionumber => $biblio->biblionumber,
1495 replacementprice => 12.00,
1502 my $resdate = undef;
1503 my $expdate = undef;
1505 my $checkitem = undef;
1508 my %renewing_borrower_data = (
1509 firstname => 'John',
1510 surname => 'Renewal',
1511 categorycode => $patron_category->{categorycode},
1512 branchcode => $branch,
1514 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
1515 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
1516 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
1517 my $datedue = dt_from_string( $issue->date_due() );
1518 is (defined $issue->date_due(), 1, "item 1 checked out");
1519 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
1521 my %reserving_borrower_data1 = (
1522 firstname => 'Katrin',
1523 surname => 'Reservation',
1524 categorycode => $patron_category->{categorycode},
1525 branchcode => $branch,
1527 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
1529 $branch, $reserving_borrowernumber1, $biblio->biblionumber,
1530 $bibitems, $priority, $resdate, $expdate, $notes,
1531 'a title', $checkitem, $found
1534 my %reserving_borrower_data2 = (
1535 firstname => 'Kirk',
1536 surname => 'Reservation',
1537 categorycode => $patron_category->{categorycode},
1538 branchcode => $branch,
1540 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
1542 $branch, $reserving_borrowernumber2, $biblio->biblionumber,
1543 $bibitems, $priority, $resdate, $expdate, $notes,
1544 'a title', $checkitem, $found
1548 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1549 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
1552 my $item_3 = $builder->build_sample_item(
1554 biblionumber => $biblio->biblionumber,
1556 replacementprice => 12.00,
1562 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1563 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
1567 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
1570 my $library = $builder->build( { source => 'Branch' } );
1571 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1573 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1574 my $biblionumber = $biblioitem->{biblionumber};
1575 my $item_1 = $builder->build(
1578 homebranch => $library->{branchcode},
1579 holdingbranch => $library->{branchcode},
1580 biblionumber => $biblionumber,
1584 my $item_2 = $builder->build(
1587 homebranch => $library->{branchcode},
1588 holdingbranch => $library->{branchcode},
1589 biblionumber => $biblionumber,
1594 my ( $error, $question, $alerts );
1595 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, dt_from_string->add( days => 1 ) );
1597 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1598 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1599 is( keys(%$error) + keys(%$alerts), 0, 'No error or alert should be raised' . str($error, $question, $alerts) );
1600 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' . str($error, $question, $alerts) );
1602 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1603 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1604 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1' . str($error, $question, $alerts) );
1606 # Add a subscription
1607 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
1609 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1610 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1611 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' . str($error, $question, $alerts) );
1613 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1614 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1615 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' . str($error, $question, $alerts) );
1618 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
1621 my $library = $builder->build( { source => 'Branch' } );
1622 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1625 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1626 my $item_1 = $builder->build(
1630 homebranch => $library->{branchcode},
1631 holdingbranch => $library->{branchcode},
1635 biblionumber => $biblioitem_1->{biblionumber}
1639 my $biblioitem_2 = $builder->build( { source => 'Biblioitem' } );
1640 my $item_2 = $builder->build(
1644 homebranch => $library->{branchcode},
1645 holdingbranch => $library->{branchcode},
1649 biblionumber => $biblioitem_2->{biblionumber}
1654 # And the issuing rule
1655 Koha::IssuingRules->search->delete;
1656 my $rule = Koha::IssuingRule->new(
1658 categorycode => '*',
1662 firstremind => 1, # 1 day of grace
1663 finedays => 2, # 2 days of fine per day of overdue
1664 lengthunit => 'days',
1669 # Patron cannot issue item_1, they have overdues
1670 my $five_days_ago = dt_from_string->subtract( days => 5 );
1671 my $ten_days_ago = dt_from_string->subtract( days => 10 );
1672 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
1673 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1674 ; # Add another overdue
1676 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
1677 AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, dt_from_string );
1678 my $debarments = Koha::Patron::Debarments::GetDebarments(
1679 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1680 is( scalar(@$debarments), 1 );
1682 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
1683 # Same for the others
1684 my $expected_expiration = output_pref(
1686 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1687 dateformat => 'sql',
1691 is( $debarments->[0]->{expiration}, $expected_expiration );
1693 AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, dt_from_string );
1694 $debarments = Koha::Patron::Debarments::GetDebarments(
1695 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1696 is( scalar(@$debarments), 1 );
1697 $expected_expiration = output_pref(
1699 dt => dt_from_string->add( days => ( 10 - 1 ) * 2 ),
1700 dateformat => 'sql',
1704 is( $debarments->[0]->{expiration}, $expected_expiration );
1706 Koha::Patron::Debarments::DelUniqueDebarment(
1707 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1709 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
1710 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
1711 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1712 ; # Add another overdue
1713 AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, dt_from_string );
1714 $debarments = Koha::Patron::Debarments::GetDebarments(
1715 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1716 is( scalar(@$debarments), 1 );
1717 $expected_expiration = output_pref(
1719 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1720 dateformat => 'sql',
1724 is( $debarments->[0]->{expiration}, $expected_expiration );
1726 AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, dt_from_string );
1727 $debarments = Koha::Patron::Debarments::GetDebarments(
1728 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1729 is( scalar(@$debarments), 1 );
1730 $expected_expiration = output_pref(
1732 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
1733 dateformat => 'sql',
1737 is( $debarments->[0]->{expiration}, $expected_expiration );
1740 subtest 'AddReturn + suspension_chargeperiod' => sub {
1743 my $library = $builder->build( { source => 'Branch' } );
1744 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1747 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1748 my $item_1 = $builder->build(
1752 homebranch => $library->{branchcode},
1753 holdingbranch => $library->{branchcode},
1757 biblionumber => $biblioitem_1->{biblionumber}
1762 # And the issuing rule
1763 Koha::IssuingRules->search->delete;
1764 my $rule = Koha::IssuingRule->new(
1766 categorycode => '*',
1770 firstremind => 0, # 0 day of grace
1771 finedays => 2, # 2 days of fine per day of overdue
1772 suspension_chargeperiod => 1,
1773 lengthunit => 'days',
1778 my $five_days_ago = dt_from_string->subtract( days => 5 );
1779 # We want to charge 2 days every day, without grace
1780 # With 5 days of overdue: 5 * Z
1781 my $expected_expiration = dt_from_string->add( days => ( 5 * 2 ) / 1 );
1782 test_debarment_on_checkout(
1785 library => $library,
1787 due_date => $five_days_ago,
1788 expiration_date => $expected_expiration,
1792 # We want to charge 2 days every 2 days, without grace
1793 # With 5 days of overdue: (5 * 2) / 2
1794 $rule->suspension_chargeperiod(2)->store;
1795 $expected_expiration = dt_from_string->add( days => floor( 5 * 2 ) / 2 );
1796 test_debarment_on_checkout(
1799 library => $library,
1801 due_date => $five_days_ago,
1802 expiration_date => $expected_expiration,
1806 # We want to charge 2 days every 3 days, with 1 day of grace
1807 # With 5 days of overdue: ((5-1) / 3 ) * 2
1808 $rule->suspension_chargeperiod(3)->store;
1809 $rule->firstremind(1)->store;
1810 $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
1811 test_debarment_on_checkout(
1814 library => $library,
1816 due_date => $five_days_ago,
1817 expiration_date => $expected_expiration,
1821 # Use finesCalendar to know if holiday must be skipped to calculate the due date
1822 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
1823 $rule->finedays(2)->store;
1824 $rule->suspension_chargeperiod(1)->store;
1825 $rule->firstremind(0)->store;
1826 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
1828 # Adding a holiday 2 days ago
1829 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
1830 my $two_days_ago = dt_from_string->subtract( days => 2 );
1831 $calendar->insert_single_holiday(
1832 day => $two_days_ago->day,
1833 month => $two_days_ago->month,
1834 year => $two_days_ago->year,
1835 title => 'holidayTest-2d',
1836 description => 'holidayDesc 2 days ago'
1838 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
1839 $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
1840 test_debarment_on_checkout(
1843 library => $library,
1845 due_date => $five_days_ago,
1846 expiration_date => $expected_expiration,
1850 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
1851 my $two_days_ahead = dt_from_string->add( days => 2 );
1852 $calendar->insert_single_holiday(
1853 day => $two_days_ahead->day,
1854 month => $two_days_ahead->month,
1855 year => $two_days_ahead->year,
1856 title => 'holidayTest+2d',
1857 description => 'holidayDesc 2 days ahead'
1860 # Same as above, but we should skip D+2
1861 $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
1862 test_debarment_on_checkout(
1865 library => $library,
1867 due_date => $five_days_ago,
1868 expiration_date => $expected_expiration,
1872 # Adding another holiday, day of expiration date
1873 my $expected_expiration_dt = dt_from_string($expected_expiration);
1874 $calendar->insert_single_holiday(
1875 day => $expected_expiration_dt->day,
1876 month => $expected_expiration_dt->month,
1877 year => $expected_expiration_dt->year,
1878 title => 'holidayTest_exp',
1879 description => 'holidayDesc on expiration date'
1881 # Expiration date will be the day after
1882 test_debarment_on_checkout(
1885 library => $library,
1887 due_date => $five_days_ago,
1888 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
1892 test_debarment_on_checkout(
1895 library => $library,
1897 return_date => dt_from_string->add(days => 5),
1898 expiration_date => dt_from_string->add(days => 5 + (5 * 2 - 1) ),
1903 subtest 'AddReturn | is_overdue' => sub {
1906 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
1907 t::lib::Mocks::mock_preference('finesMode', 'production');
1908 t::lib::Mocks::mock_preference('MaxFine', '100');
1910 my $library = $builder->build( { source => 'Branch' } );
1911 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1913 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1914 my $item = $builder->build(
1918 homebranch => $library->{branchcode},
1919 holdingbranch => $library->{branchcode},
1923 biblionumber => $biblioitem->{biblionumber},
1928 Koha::IssuingRules->search->delete;
1929 my $rule = Koha::IssuingRule->new(
1931 categorycode => '*',
1935 lengthunit => 'days',
1936 fine => 1, # Charge 1 every day of overdue
1942 my $one_day_ago = dt_from_string->subtract( days => 1 );
1943 my $five_days_ago = dt_from_string->subtract( days => 5 );
1944 my $ten_days_ago = dt_from_string->subtract( days => 10 );
1945 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1947 # No date specify, today will be used
1948 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
1949 AddReturn( $item->{barcode}, $library->{branchcode} );
1950 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
1951 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1953 # specify return date 5 days before => no overdue
1954 AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
1955 AddReturn( $item->{barcode}, $library->{branchcode}, undef, $ten_days_ago );
1956 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
1957 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1959 # specify return date 5 days later => overdue
1960 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
1961 AddReturn( $item->{barcode}, $library->{branchcode}, undef, $five_days_ago );
1962 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
1963 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1965 # specify dropbox date 5 days before => no overdue
1966 AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
1967 AddReturn( $item->{barcode}, $library->{branchcode}, $ten_days_ago );
1968 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
1969 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1971 # specify dropbox date 5 days later => overdue, or... not
1972 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
1973 AddReturn( $item->{barcode}, $library->{branchcode}, $five_days_ago );
1974 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue in dropbox mode' ); # FIXME? This is weird, the FU fine is created ( _CalculateAndUpdateFine > C4::Overdues::UpdateFine ) then remove later (in _FixOverduesOnReturn). Looks like it is a feature
1975 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1978 subtest '_FixAccountForLostAndReturned' => sub {
1982 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
1983 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
1985 my $processfee_amount = 20;
1986 my $replacement_amount = 99.00;
1987 my $item_type = $builder->build_object(
1988 { class => 'Koha::ItemTypes',
1990 notforloan => undef,
1992 defaultreplacecost => undef,
1993 processfee => $processfee_amount,
1994 rentalcharge_daily => 0,
1998 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2000 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Daria' });
2002 subtest 'Full write-off tests' => sub {
2006 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2008 my $item = $builder->build_sample_item(
2010 biblionumber => $biblio->biblionumber,
2011 library => $library->branchcode,
2012 replacementprice => $replacement_amount,
2013 itype => $item_type->itemtype,
2017 AddIssue( $patron->unblessed, $item->barcode );
2019 # Simulate item marked as lost
2020 ModItem( { itemlost => 3 }, $biblio->biblionumber, $item->itemnumber );
2021 LostItem( $item->itemnumber, 1 );
2023 my $processing_fee_lines = Koha::Account::Lines->search(
2024 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2025 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2026 my $processing_fee_line = $processing_fee_lines->next;
2027 is( $processing_fee_line->amount + 0,
2028 $processfee_amount, 'The right PF amount is generated' );
2029 is( $processing_fee_line->amountoutstanding + 0,
2030 $processfee_amount, 'The right PF amountoutstanding is generated' );
2032 my $lost_fee_lines = Koha::Account::Lines->search(
2033 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
2034 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2035 my $lost_fee_line = $lost_fee_lines->next;
2036 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2037 is( $lost_fee_line->amountoutstanding + 0,
2038 $replacement_amount, 'The right L amountoutstanding is generated' );
2040 my $account = $patron->account;
2041 my $debts = $account->outstanding_debits;
2043 # Write off the debt
2044 my $credit = $account->add_credit(
2045 { amount => $account->balance,
2049 $credit->apply( { debits => $debts, offset_type => 'Writeoff' } );
2051 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2052 is( $credit_return_id, undef, 'No CR account line added' );
2054 $lost_fee_line->discard_changes; # reload from DB
2055 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2056 is( $lost_fee_line->accounttype,
2057 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2059 is( $patron->account->balance, -0, 'The patron balance is 0, everything was written off' );
2062 subtest 'Full payment tests' => sub {
2066 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2068 my $item = $builder->build_sample_item(
2070 biblionumber => $biblio->biblionumber,
2071 library => $library->branchcode,
2072 replacementprice => $replacement_amount,
2073 itype => $item_type->itemtype
2077 AddIssue( $patron->unblessed, $item->barcode );
2079 # Simulate item marked as lost
2080 ModItem( { itemlost => 1 }, $biblio->biblionumber, $item->itemnumber );
2081 LostItem( $item->itemnumber, 1 );
2083 my $processing_fee_lines = Koha::Account::Lines->search(
2084 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2085 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2086 my $processing_fee_line = $processing_fee_lines->next;
2087 is( $processing_fee_line->amount + 0,
2088 $processfee_amount, 'The right PF amount is generated' );
2089 is( $processing_fee_line->amountoutstanding + 0,
2090 $processfee_amount, 'The right PF amountoutstanding is generated' );
2092 my $lost_fee_lines = Koha::Account::Lines->search(
2093 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
2094 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2095 my $lost_fee_line = $lost_fee_lines->next;
2096 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2097 is( $lost_fee_line->amountoutstanding + 0,
2098 $replacement_amount, 'The right L amountountstanding is generated' );
2100 my $account = $patron->account;
2101 my $debts = $account->outstanding_debits;
2103 # Write off the debt
2104 my $credit = $account->add_credit(
2105 { amount => $account->balance,
2109 $credit->apply( { debits => $debts, offset_type => 'Payment' } );
2111 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2112 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2114 is( $credit_return->accounttype, 'CR', 'An account line of type CR is added' );
2115 is( $credit_return->amount + 0,
2116 -99.00, 'The account line of type CR has an amount of -99' );
2117 is( $credit_return->amountoutstanding + 0,
2118 -99.00, 'The account line of type CR has an amountoutstanding of -99' );
2120 $lost_fee_line->discard_changes;
2121 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2122 is( $lost_fee_line->accounttype,
2123 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2125 is( $patron->account->balance,
2126 -99, 'The patron balance is -99, a credit that equals the lost fee payment' );
2129 subtest 'Test without payment or write off' => sub {
2133 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2135 my $item = $builder->build_sample_item(
2137 biblionumber => $biblio->biblionumber,
2138 library => $library->branchcode,
2139 replacementprice => 23.00,
2140 replacementprice => $replacement_amount,
2141 itype => $item_type->itemtype
2145 AddIssue( $patron->unblessed, $item->barcode );
2147 # Simulate item marked as lost
2148 ModItem( { itemlost => 3 }, $biblio->biblionumber, $item->itemnumber );
2149 LostItem( $item->itemnumber, 1 );
2151 my $processing_fee_lines = Koha::Account::Lines->search(
2152 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2153 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2154 my $processing_fee_line = $processing_fee_lines->next;
2155 is( $processing_fee_line->amount + 0,
2156 $processfee_amount, 'The right PF amount is generated' );
2157 is( $processing_fee_line->amountoutstanding + 0,
2158 $processfee_amount, 'The right PF amountoutstanding is generated' );
2160 my $lost_fee_lines = Koha::Account::Lines->search(
2161 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
2162 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2163 my $lost_fee_line = $lost_fee_lines->next;
2164 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2165 is( $lost_fee_line->amountoutstanding + 0,
2166 $replacement_amount, 'The right L amountountstanding is generated' );
2168 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2169 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2171 is( $credit_return->accounttype, 'CR', 'An account line of type CR is added' );
2172 is( $credit_return->amount + 0, -99.00, 'The account line of type CR has an amount of -99' );
2173 is( $credit_return->amountoutstanding + 0, 0, 'The account line of type CR has an amountoutstanding of 0' );
2175 $lost_fee_line->discard_changes;
2176 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2177 is( $lost_fee_line->accounttype, 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2179 is( $patron->account->balance, 20, 'The patron balance is 20, still owes the processing fee' );
2182 subtest 'Test with partial payement and write off, and remaining debt' => sub {
2186 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2187 my $item = $builder->build_sample_item(
2189 biblionumber => $biblio->biblionumber,
2190 library => $library->branchcode,
2191 replacementprice => $replacement_amount,
2192 itype => $item_type->itemtype
2196 AddIssue( $patron->unblessed, $item->barcode );
2198 # Simulate item marked as lost
2199 ModItem( { itemlost => 1 }, $biblio->biblionumber, $item->itemnumber );
2200 LostItem( $item->itemnumber, 1 );
2202 my $processing_fee_lines = Koha::Account::Lines->search(
2203 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2204 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2205 my $processing_fee_line = $processing_fee_lines->next;
2206 is( $processing_fee_line->amount + 0,
2207 $processfee_amount, 'The right PF amount is generated' );
2208 is( $processing_fee_line->amountoutstanding + 0,
2209 $processfee_amount, 'The right PF amountoutstanding is generated' );
2211 my $lost_fee_lines = Koha::Account::Lines->search(
2212 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
2213 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2214 my $lost_fee_line = $lost_fee_lines->next;
2215 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2216 is( $lost_fee_line->amountoutstanding + 0,
2217 $replacement_amount, 'The right L amountountstanding is generated' );
2219 my $account = $patron->account;
2220 is( $account->balance, $processfee_amount + $replacement_amount, 'Balance is PF + L' );
2223 my $payment_amount = 27;
2224 my $payment = $account->add_credit(
2225 { amount => $payment_amount,
2230 $payment->apply( { debits => $lost_fee_lines->reset, offset_type => 'Payment' } );
2232 # Partially write off fee
2233 my $write_off_amount = 25;
2234 my $write_off = $account->add_credit(
2235 { amount => $write_off_amount,
2239 $write_off->apply( { debits => $lost_fee_lines->reset, offset_type => 'Writeoff' } );
2241 is( $account->balance,
2242 $processfee_amount + $replacement_amount - $payment_amount - $write_off_amount,
2243 'Payment and write off applied'
2246 # Store the amountoutstanding value
2247 $lost_fee_line->discard_changes;
2248 my $outstanding = $lost_fee_line->amountoutstanding;
2250 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2251 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2253 is( $account->balance, $processfee_amount - $payment_amount, 'Balance is PF - payment (CR)' );
2255 $lost_fee_line->discard_changes;
2256 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2257 is( $lost_fee_line->accounttype,
2258 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2260 is( $credit_return->accounttype, 'CR', 'An account line of type CR is added' );
2261 is( $credit_return->amount + 0,
2262 ($payment_amount + $outstanding ) * -1,
2263 'The account line of type CR has an amount equal to the payment + outstanding'
2265 is( $credit_return->amountoutstanding + 0,
2266 $payment_amount * -1,
2267 'The account line of type CR has an amountoutstanding equal to the payment'
2270 is( $account->balance,
2271 $processfee_amount - $payment_amount,
2272 'The patron balance is the difference between the PF and the credit'
2276 subtest 'Partial payement, existing debits and AccountAutoReconcile' => sub {
2280 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2281 my $barcode = 'KD123456793';
2282 my $replacement_amount = 100;
2283 my $processfee_amount = 20;
2285 my $item_type = $builder->build_object(
2286 { class => 'Koha::ItemTypes',
2288 notforloan => undef,
2290 defaultreplacecost => undef,
2292 rentalcharge_daily => 0,
2296 my ( undef, undef, $item_id ) = AddItem(
2297 { homebranch => $library->branchcode,
2298 holdingbranch => $library->branchcode,
2299 barcode => $barcode,
2300 replacementprice => $replacement_amount,
2301 itype => $item_type->itemtype
2303 $biblio->biblionumber
2306 AddIssue( $patron->unblessed, $barcode );
2308 # Simulate item marked as lost
2309 ModItem( { itemlost => 1 }, $biblio->biblionumber, $item_id );
2310 LostItem( $item_id, 1 );
2312 my $lost_fee_lines = Koha::Account::Lines->search(
2313 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'L' } );
2314 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2315 my $lost_fee_line = $lost_fee_lines->next;
2316 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2317 is( $lost_fee_line->amountoutstanding + 0,
2318 $replacement_amount, 'The right L amountountstanding is generated' );
2320 my $account = $patron->account;
2321 is( $account->balance, $replacement_amount, 'Balance is L' );
2324 my $payment_amount = 27;
2325 my $payment = $account->add_credit(
2326 { amount => $payment_amount,
2330 $payment->apply({ debits => $lost_fee_lines->reset, offset_type => 'Payment' });
2332 is( $account->balance,
2333 $replacement_amount - $payment_amount,
2337 # TODO use add_debit when time comes
2338 my $manual_debit_amount = 80;
2339 C4::Accounts::manualinvoice( $patron->id, undef, undef, 'FU', $manual_debit_amount );
2341 is( $account->balance, $manual_debit_amount + $replacement_amount - $payment_amount, 'Manual debit applied' );
2343 t::lib::Mocks::mock_preference( 'AccountAutoReconcile', 1 );
2345 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item_id, $patron->id );
2346 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2348 is( $account->balance, $manual_debit_amount - $payment_amount, 'Balance is PF - payment (CR)' );
2350 my $manual_debit = Koha::Account::Lines->search({ borrowernumber => $patron->id, accounttype => 'FU' })->next;
2351 is( $manual_debit->amountoutstanding + 0, $manual_debit_amount - $payment_amount, 'reconcile_balance was called' );
2355 subtest '_FixOverduesOnReturn' => sub {
2358 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2360 my $branchcode = $library2->{branchcode};
2362 my $item = $builder->build_sample_item(
2364 biblionumber => $biblio->biblionumber,
2365 library => $branchcode,
2366 replacementprice => 99.00,
2371 my $patron = $builder->build( { source => 'Borrower' } );
2373 ## Start with basic call, should just close out the open fine
2374 my $accountline = Koha::Account::Line->new(
2376 borrowernumber => $patron->{borrowernumber},
2377 accounttype => 'FU',
2378 itemnumber => $item->itemnumber,
2380 amountoutstanding => 99.00,
2381 lastincrement => 9.00,
2385 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber );
2387 $accountline->_result()->discard_changes();
2389 is( $accountline->amountoutstanding, '99.000000', 'Fine has the same amount outstanding as previously' );
2390 is( $accountline->accounttype, 'F', 'Open fine ( account type FU ) has been closed out ( account type F )');
2393 ## Run again, with exemptfine enabled
2396 accounttype => 'FU',
2397 amountoutstanding => 99.00,
2401 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1 );
2403 $accountline->_result()->discard_changes();
2404 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next();
2406 is( $accountline->amountoutstanding + 0, 0, 'Fine has been reduced to 0' );
2407 is( $accountline->accounttype, 'FFOR', 'Open fine ( account type FU ) has been set to fine forgiven ( account type FFOR )');
2408 is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
2409 is( $offset->amount, '-99.000000', "Amount of offset is correct" );
2412 subtest 'Set waiting flag' => sub {
2415 my $library_1 = $builder->build( { source => 'Branch' } );
2416 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2417 my $library_2 = $builder->build( { source => 'Branch' } );
2418 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2420 my $biblio = $builder->build( { source => 'Biblio' } );
2421 my $biblioitem = $builder->build( { source => 'Biblioitem', value => { biblionumber => $biblio->{biblionumber} } } );
2423 my $item = $builder->build(
2427 homebranch => $library_1->{branchcode},
2428 holdingbranch => $library_1->{branchcode},
2432 biblionumber => $biblioitem->{biblionumber},
2437 set_userenv( $library_2 );
2438 my $reserve_id = AddReserve(
2439 $library_2->{branchcode}, $patron_2->{borrowernumber}, $biblioitem->{biblionumber},
2440 '', 1, undef, undef, '', undef, $item->{itemnumber},
2443 set_userenv( $library_1 );
2444 my $do_transfer = 1;
2445 my ( $res, $rr ) = AddReturn( $item->{barcode}, $library_1->{branchcode} );
2446 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2447 my $hold = Koha::Holds->find( $reserve_id );
2448 is( $hold->found, 'T', 'Hold is in transit' );
2450 my ( $status ) = CheckReserves($item->{itemnumber});
2451 is( $status, 'Reserved', 'Hold is not waiting yet');
2453 set_userenv( $library_2 );
2455 AddReturn( $item->{barcode}, $library_2->{branchcode} );
2456 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2457 $hold = Koha::Holds->find( $reserve_id );
2458 is( $hold->found, 'W', 'Hold is waiting' );
2459 ( $status ) = CheckReserves($item->{itemnumber});
2460 is( $status, 'Waiting', 'Now the hold is waiting');
2463 subtest 'Cancel transfers on lost items' => sub {
2465 my $library_1 = $builder->build( { source => 'Branch' } );
2466 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2467 my $library_2 = $builder->build( { source => 'Branch' } );
2468 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2469 my $biblio = $builder->build( { source => 'Biblio' } );
2470 my $biblioitem = $builder->build( { source => 'Biblioitem', value => { biblionumber => $biblio->{biblionumber} } } );
2471 my $item = $builder->build(
2475 homebranch => $library_1->{branchcode},
2476 holdingbranch => $library_1->{branchcode},
2480 biblionumber => $biblioitem->{biblionumber},
2485 set_userenv( $library_2 );
2486 my $reserve_id = AddReserve(
2487 $library_2->{branchcode}, $patron_2->{borrowernumber}, $biblioitem->{biblionumber}, '', 1, undef, undef, '', undef, $item->{itemnumber},
2490 #Return book and add transfer
2491 set_userenv( $library_1 );
2492 my $do_transfer = 1;
2493 my ( $res, $rr ) = AddReturn( $item->{barcode}, $library_1->{branchcode} );
2494 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2495 C4::Circulation::transferbook( $library_2->{branchcode}, $item->{barcode} );
2496 my $hold = Koha::Holds->find( $reserve_id );
2497 is( $hold->found, 'T', 'Hold is in transit' );
2499 #Check transfer exists and the items holding branch is the transfer destination branch before marking it as lost
2500 my ($datesent,$frombranch,$tobranch) = GetTransfers($item->{itemnumber});
2501 is( $tobranch, $library_2->{branchcode}, 'The transfer record exists in the branchtransfers table');
2502 my $itemcheck = Koha::Items->find($item->{itemnumber});
2503 is( $itemcheck->holdingbranch, $library_2->{branchcode}, 'Items holding branch is the transfers destination branch before it is marked as lost' );
2505 #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch
2506 ModItem( { itemlost => 1 }, $biblio->{biblionumber}, $item->{itemnumber} );
2507 LostItem( $item->{itemnumber}, 'test', 1 );
2508 ($datesent,$frombranch,$tobranch) = GetTransfers($item->{itemnumber});
2509 is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled');
2510 $itemcheck = Koha::Items->find($item->{itemnumber});
2511 is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' );
2514 subtest 'CanBookBeIssued | is_overdue' => sub {
2517 # Set a simple circ policy
2518 $dbh->do('DELETE FROM issuingrules');
2520 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
2521 issuelength, lengthunit,
2522 renewalsallowed, renewalperiod,
2523 norenewalbefore, auto_renew,
2540 my $five_days_go = output_pref({ dt => dt_from_string->add( days => 5 ), dateonly => 1});
2541 my $ten_days_go = output_pref({ dt => dt_from_string->add( days => 10), dateonly => 1 });
2542 my $library = $builder->build( { source => 'Branch' } );
2543 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
2545 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
2546 my $item = $builder->build(
2550 homebranch => $library->{branchcode},
2551 holdingbranch => $library->{branchcode},
2555 biblionumber => $biblioitem->{biblionumber},
2560 my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $five_days_go ); # date due was 10d ago
2561 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
2562 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
2563 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->{barcode},$ten_days_go, undef, undef, undef);
2564 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
2565 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
2568 subtest 'ItemsDeniedRenewal preference' => sub {
2571 C4::Context->set_preference('ItemsDeniedRenewal','');
2573 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
2576 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod,
2577 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
2580 '*', $idr_lib->branchcode, '*', 25,
2587 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
2588 homebranch => $idr_lib->branchcode,
2592 itemcallnumber => undef,
2596 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
2597 homebranch => $idr_lib->branchcode,
2600 location => 'NOPROC'
2604 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
2605 branchcode => $idr_lib->branchcode,
2608 my $future = dt_from_string->add( days => 1 );
2609 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
2610 returndate => undef,
2613 borrowernumber => $idr_borrower->borrowernumber,
2614 itemnumber => $deny_book->itemnumber,
2615 onsite_checkout => 0,
2616 date_due => $future,
2619 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
2620 returndate => undef,
2623 borrowernumber => $idr_borrower->borrowernumber,
2624 itemnumber => $allow_book->itemnumber,
2625 onsite_checkout => 0,
2626 date_due => $future,
2632 my ( $idr_mayrenew, $idr_error ) =
2633 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2634 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
2635 is( $idr_error, undef, 'Renewal allowed when no rules' );
2637 $idr_rules="withdrawn: [1]";
2639 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2640 ( $idr_mayrenew, $idr_error ) =
2641 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2642 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
2643 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
2644 ( $idr_mayrenew, $idr_error ) =
2645 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2646 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
2647 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
2649 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
2651 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2652 ( $idr_mayrenew, $idr_error ) =
2653 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2654 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
2655 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
2656 ( $idr_mayrenew, $idr_error ) =
2657 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2658 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
2659 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
2661 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
2663 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2664 ( $idr_mayrenew, $idr_error ) =
2665 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2666 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
2667 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
2668 ( $idr_mayrenew, $idr_error ) =
2669 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2670 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
2671 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
2673 $idr_rules="itemcallnumber: [NULL]";
2674 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2675 ( $idr_mayrenew, $idr_error ) =
2676 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2677 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
2678 $idr_rules="itemcallnumber: ['']";
2679 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2680 ( $idr_mayrenew, $idr_error ) =
2681 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2682 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
2684 $idr_rules="itemnotes: [NULL]";
2685 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2686 ( $idr_mayrenew, $idr_error ) =
2687 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2688 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
2689 $idr_rules="itemnotes: ['']";
2690 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2691 ( $idr_mayrenew, $idr_error ) =
2692 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2693 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
2696 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
2699 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
2700 my $library = $builder->build( { source => 'Branch' } );
2701 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
2703 my $itemtype = $builder->build(
2705 source => 'Itemtype',
2706 value => { notforloan => undef, }
2710 my $biblioitem = $builder->build( { source => 'Biblioitem', value => { itemtype => $itemtype->{itemtype} } } );
2711 my $item = $builder->build_object(
2713 class => 'Koha::Items',
2715 homebranch => $library->{branchcode},
2716 holdingbranch => $library->{branchcode},
2720 biblionumber => $biblioitem->{biblionumber},
2721 biblioitemnumber => $biblioitem->{biblioitemnumber},
2726 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2727 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2728 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2731 subtest 'CanBookBeIssued | notforloan' => sub {
2734 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
2736 my $library = $builder->build( { source => 'Branch' } );
2737 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
2739 my $itemtype = $builder->build(
2741 source => 'Itemtype',
2742 value => { notforloan => undef, }
2746 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
2747 my $item = $builder->build_object(
2749 class => 'Koha::Items',
2751 homebranch => $library->{branchcode},
2752 holdingbranch => $library->{branchcode},
2756 itype => $itemtype->{itemtype},
2757 biblionumber => $biblioitem->{biblionumber},
2758 biblioitemnumber => $biblioitem->{biblioitemnumber},
2763 my ( $issuingimpossible, $needsconfirmation );
2766 subtest 'item-level_itypes = 1' => sub {
2769 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
2770 # Is for loan at item type and item level
2771 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2772 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2773 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2775 # not for loan at item type level
2776 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
2777 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2778 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2781 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
2782 'Item can not be issued, not for loan at item type level'
2785 # not for loan at item level
2786 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
2787 $item->notforloan( 1 )->store;
2788 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2789 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2792 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
2793 'Item can not be issued, not for loan at item type level'
2797 subtest 'item-level_itypes = 0' => sub {
2800 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
2802 # We set another itemtype for biblioitem
2803 my $itemtype = $builder->build(
2805 source => 'Itemtype',
2806 value => { notforloan => undef, }
2810 # for loan at item type and item level
2811 $item->notforloan(0)->store;
2812 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
2813 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2814 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2815 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2817 # not for loan at item type level
2818 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
2819 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2820 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2823 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
2824 'Item can not be issued, not for loan at item type level'
2827 # not for loan at item level
2828 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
2829 $item->notforloan( 1 )->store;
2830 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2831 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2834 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
2835 'Item can not be issued, not for loan at item type level'
2839 # TODO test with AllowNotForLoanOverride = 1
2842 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
2845 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
2846 my $item = $builder->build_object({ class => 'Koha::Items', value => { onloan => '2018-01-01' }});
2847 AddReturn( $item->barcode, $item->homebranch );
2848 $item->discard_changes; # refresh
2849 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
2852 $schema->storage->txn_rollback;
2853 C4::Context->clear_syspref_cache();
2854 $cache->clear_from_cache('single_holidays');
2856 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
2860 $schema->storage->txn_begin;
2862 t::lib::Mocks::mock_preference('item-level_itypes', 1);
2864 my $issuing_charges = 15;
2865 my $title = 'A title';
2866 my $author = 'Author, An';
2867 my $barcode = 'WHATARETHEODDS';
2869 my $circ = Test::MockModule->new('C4::Circulation');
2871 'GetIssuingCharges',
2873 return $issuing_charges;
2877 my $library = $builder->build_object({ class => 'Koha::Libraries' });
2878 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
2879 my $patron = $builder->build_object({
2880 class => 'Koha::Patrons',
2881 value => { branchcode => $library->id }
2884 my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
2885 my ( undef, undef, $item_id ) = AddItem(
2887 homebranch => $library->id,
2888 holdingbranch => $library->id,
2889 barcode => $barcode,
2890 replacementprice => 23.00,
2891 itype => $itemtype->id
2893 $biblio->biblionumber
2895 my $item = Koha::Items->find( $item_id );
2897 my $context = Test::MockModule->new('C4::Context');
2898 $context->mock( userenv => { branch => $library->id } );
2900 # Check the item out
2901 AddIssue( $patron->unblessed, $item->barcode );
2902 t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
2903 my $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
2904 my %params_renewal = (
2905 timestamp => { -like => $date . "%" },
2906 module => "CIRCULATION",
2907 action => "RENEWAL",
2909 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
2910 AddRenewal( $patron->id, $item->id, $library->id );
2911 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
2912 is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
2914 my $checkouts = $patron->checkouts;
2915 # The following will fail if run on 00:00:00
2916 unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
2918 t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
2919 $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
2920 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
2921 AddRenewal( $patron->id, $item->id, $library->id );
2922 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
2923 is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
2925 my $lines = Koha::Account::Lines->search({
2926 borrowernumber => $patron->id,
2927 itemnumber => $item->id
2930 is( $lines->count, 3 );
2932 my $line = $lines->next;
2933 is( $line->accounttype, 'Rent', 'The issuing charge generates an accountline' );
2934 is( $line->branchcode, $library->id, 'AddIssuingCharge correctly sets branchcode' );
2935 is( $line->description, 'Rental', 'AddIssuingCharge set a hardcoded description for the accountline' );
2937 $line = $lines->next;
2938 is( $line->accounttype, 'Rent', 'Fine on renewed item is closed out properly' );
2939 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
2940 is( $line->description, "Renewal of Rental Item $title $barcode", 'AddRenewal set a hardcoded description for the accountline' );
2942 $line = $lines->next;
2943 is( $line->accounttype, 'Rent', 'Fine on renewed item is closed out properly' );
2944 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
2945 is( $line->description, "Renewal of Rental Item $title $barcode", 'AddRenewal set a hardcoded description for the accountline' );
2947 $schema->storage->txn_rollback;
2950 subtest 'ProcessOfflinePayment() tests' => sub {
2954 $schema->storage->txn_begin;
2958 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
2959 my $library = $builder->build_object({ class => 'Koha::Libraries' });
2960 my $result = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
2962 is( $result, 'Success.', 'The right string is returned' );
2964 my $lines = $patron->account->lines;
2965 is( $lines->count, 1, 'line created correctly');
2967 my $line = $lines->next;
2968 is( $line->amount+0, $amount * -1, 'amount picked from params' );
2969 is( $line->branchcode, $library->id, 'branchcode set correctly' );
2971 $schema->storage->txn_rollback;
2977 my ( $library ) = @_;
2978 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
2982 my ( $error, $question, $alert ) = @_;
2984 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
2985 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
2986 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
2990 sub test_debarment_on_checkout {
2992 my $item = $params->{item};
2993 my $library = $params->{library};
2994 my $patron = $params->{patron};
2995 my $due_date = $params->{due_date} || dt_from_string;
2996 my $return_date = $params->{return_date} || dt_from_string;
2997 my $expected_expiration_date = $params->{expiration_date};
2999 $expected_expiration_date = output_pref(
3001 dt => $expected_expiration_date,
3002 dateformat => 'sql',
3006 my @caller = caller;
3007 my $line_number = $caller[2];
3008 AddIssue( $patron, $item->{barcode}, $due_date );
3010 my ( undef, $message ) = AddReturn( $item->{barcode}, $library->{branchcode}, undef, $return_date );
3011 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
3012 or diag('AddReturn returned message ' . Dumper $message );
3013 my $debarments = Koha::Patron::Debarments::GetDebarments(
3014 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
3015 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
3017 is( $debarments->[0]->{expiration},
3018 $expected_expiration_date, 'Test at line ' . $line_number );
3019 Koha::Patron::Debarments::DelUniqueDebarment(
3020 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
3023 subtest 'Incremented fee tests' => sub {
3026 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3028 my $library = $builder->build_object( { class => 'Koha::Libraries' } )->store;
3030 my $module = new Test::MockModule('C4::Context');
3031 $module->mock('userenv', sub { { branch => $library->id } });
3033 my $patron = $builder->build_object(
3035 class => 'Koha::Patrons',
3036 value => { categorycode => $patron_category->{categorycode} }
3040 my $itemtype = $builder->build_object(
3042 class => 'Koha::ItemTypes',
3044 notforloan => undef,
3046 rentalcharge_daily => 1.000000
3051 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
3052 my $item = $builder->build_object(
3054 class => 'Koha::Items',
3056 homebranch => $library->id,
3057 holdingbranch => $library->id,
3061 itype => $itemtype->id,
3062 biblionumber => $biblioitem->{biblionumber},
3063 biblioitemnumber => $biblioitem->{biblioitemnumber},
3068 is( $itemtype->rentalcharge_daily, '1.000000', 'Daily rental charge stored and retreived correctly' );
3069 is( $item->effective_itemtype, $itemtype->id, "Itemtype set correctly for item");
3071 my $dt_from = dt_from_string();
3072 my $dt_to = dt_from_string()->add( days => 7 );
3073 my $dt_to_renew = dt_from_string()->add( days => 13 );
3075 t::lib::Mocks::mock_preference('finesCalendar', 'ignoreCalendar');
3076 my $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3077 my $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3078 is( $accountline->amount, '7.000000', "Daily rental charge calculated correctly with finesCalendar = ignoreCalendar" );
3079 $accountline->delete();
3080 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3081 $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3082 is( $accountline->amount, '6.000000', "Daily rental charge calculated correctly with finesCalendar = ignoreCalendar, for renewal" );
3083 $accountline->delete();
3086 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
3087 $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3088 $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3089 is( $accountline->amount, '7.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed" );
3090 $accountline->delete();
3091 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3092 $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3093 is( $accountline->amount, '6.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed, for renewal" );
3094 $accountline->delete();
3097 my $calendar = C4::Calendar->new( branchcode => $library->id );
3098 $calendar->insert_week_day_holiday(
3100 title => 'Test holiday',
3101 description => 'Test holiday'
3103 $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3104 $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3105 is( $accountline->amount, '6.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays" );
3106 $accountline->delete();
3107 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3108 $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3109 is( $accountline->amount, '5.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays, for renewal" );
3110 $accountline->delete();
3113 $itemtype->rentalcharge('2.000000')->store;
3114 is( $itemtype->rentalcharge, '2.000000', 'Rental charge updated and retreived correctly' );
3115 $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from);
3116 my $accountlines = Koha::Account::Lines->search({ itemnumber => $item->id });
3117 is( $accountlines->count, '2', "Fixed charge and accrued charge recorded distinctly");
3118 $accountlines->delete();
3119 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3120 $accountlines = Koha::Account::Lines->search({ itemnumber => $item->id });
3121 is( $accountlines->count, '2', "Fixed charge and accrued charge recorded distinctly, for renewal");
3122 $accountlines->delete();
3126 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
3129 t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
3130 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3133 $builder->build_object( { class => 'Koha::Libraries' } )->store;
3134 my $patron = $builder->build_object(
3136 class => 'Koha::Patrons',
3137 value => { categorycode => $patron_category->{categorycode} }
3141 my $itemtype = $builder->build_object(
3143 class => 'Koha::ItemTypes',
3147 rentalcharge_daily => 0
3152 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
3153 my $item = $builder->build_object(
3155 class => 'Koha::Items',
3157 homebranch => $library->id,
3158 holdingbranch => $library->id,
3162 itype => $itemtype->id,
3163 biblionumber => $biblioitem->{biblionumber},
3164 biblioitemnumber => $biblioitem->{biblioitemnumber},
3169 my ( $issuingimpossible, $needsconfirmation );
3170 my $dt_from = dt_from_string();
3171 my $dt_due = dt_from_string()->add( days => 3 );
3173 $itemtype->rentalcharge('1.000000')->store;
3174 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3175 is_deeply( $needsconfirmation, { RENTALCHARGE => '1' }, 'Item needs rentalcharge confirmation to be issued' );
3176 $itemtype->rentalcharge('0')->store;
3177 $itemtype->rentalcharge_daily('1.000000')->store;
3178 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3179 is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
3180 $itemtype->rentalcharge_daily('0')->store;