Bug 10481: FIX No enrollment fee when changing patron category.
authorJonathan Druart <jonathan.druart@biblibre.com>
Mon, 17 Jun 2013 12:56:22 +0000 (14:56 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 11 Sep 2013 17:32:57 +0000 (14:32 -0300)
commit98397ed4b10b03fb0b00e9550b571c3cc47407dc
tree53b8e1d307854ccb916e304fa4bea785cdb591b2
parentd7bd725fb1309813b89190b73556e0cb0ba7c4b4
Bug 10481: FIX No enrollment fee when changing patron category.

When a patron changes to a category with enrollment fee, they
are not generated.

Test plan:
- Choose a category without fee (e.g. Kid)
- Add an enrollment fee for another category (e.g. Young adult)
- Choose a kid and change his category to "Young adult".
- Note the warning message "Fees & Charges: Patron has Outstanding fees
  & charges of XX" on the check out page.

This patch also moves all instances of adding the enrollment fee
to a new routine in C4::Members, AddEnrolmentFeeIfNeeded(), so
additional tests include:

- Register a new patron and give it a category that has
  an enrollment fee.  Verify that the fee is charged.
- Renew the patron.  Verify that the additional fee is charged.
- Register a new patron with a child patron category.
- Use the 'update child to adult' menu option to change the
  patron's category to one that is fee-bearing.  Verify that the
  enrollment fee was charged.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit f8eb19163bd4e59e99b6dae90a5712b6a7be52f6)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Members.pm