Bug 22611: Correction for call to get create_item in EDI.pm
authorColin Campbell <colin.campbell@ptfs-europe.com>
Mon, 1 Apr 2019 11:16:51 +0000 (12:16 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 15 Apr 2019 10:30:26 +0000 (11:30 +0100)
commit4a2e88549505afbf28c2e0236f81012789262496
treea4a4f5b66035626ea9abcf7d4a0665d290905a32
parent170cdc4b01ce53a4ac114ab4d2d45b14af50627f
Bug 22611: Correction for call to get create_item in EDI.pm

There was a typo in the addition of a call to
effective_create_items causing processing to abort after adding
a single copy.

This patch reverts to using the C4::Context call as used for the
first copy created, the intended call to effective_create_items
is a wrapper around that as the field in the basket is guaranteed
to be null (its not set when we call AddBasket). Being consistent
and explicit in what we call should guard against future changes
in dependencies exposing the logic flaw

Added some comments to make logical flow of code clearer

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit f6bc67e851722451a970d085f51fb11fb03e21b3)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/EDI.pm