Bug 17916 - "Delete MARC modification template" fails to actually delete it
authorOwen Leonard <oleonard@myacpl.org>
Tue, 25 Apr 2017 13:15:13 +0000 (13:15 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Apr 2017 11:02:10 +0000 (07:02 -0400)
commit3fddc0d73724c6c5f1aafe6842c488304b79f306
tree96bb9f5ba5def58907d8b5f06c182c3efc314646
parentdddd2691e704654fd656c5d519e029c5dfc3ecc9
Bug 17916 - "Delete MARC modification template" fails to actually delete it

The MARC modification templates' 'Delete' button fails because the event
handler has a "preventDefault" but the outcome of the confirmation
function must return true or false.

This patch removes the "preventDefault" from the .delete_template click
handler as well as a redundant onclick attribute from the delete link
itself.

To test, apply the patch and go to Tools -> MARC modification templates.
Clicking the delete button for any existing template should work
correctly.

Followed test plan, worked as intended

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js