Bug 14721: OAI-PMH must return error when no results
authorFridolin Somers <fridolin.somers@biblibre.com>
Tue, 25 Aug 2015 09:33:04 +0000 (11:33 +0200)
committerChris Cormack <chris@bigballofwax.co.nz>
Tue, 22 Sep 2015 02:00:00 +0000 (14:00 +1200)
commit3d8e059513db08f2070e33ea1562d7cdd915797c
treea853e8bb351c2fcdfc19bacac057d56c37c816ba
parentc7dfbfedd3d298753b4d96d5ce50363c2cfc65fc
Bug 14721: OAI-PMH must return error when no results

When getting records from OAI-PMH, an error must be returned if there is no results.

See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions

Test plan :
- Enable OAI webservice
- Perform a query that will return no results. ie : /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31
=> Without patch you get a response with :
   <ListRecords/>
=> With patch you get a response with error code :
   <error code="noRecordsMatch">No records match the given criteria</error>
- Check a good query returns still results
- Same test with ListIdentifiers verb

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 64992a05ce87af7bf595c8d6f0b9d528887a2e44)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
opac/oai.pl