Bug 21172: Remove warning from addbiblio.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 7 Aug 2018 20:06:41 +0000 (17:06 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 26 Apr 2019 11:56:57 +0000 (12:56 +0100)
commit1ed01089db28deb6f9689bbb64c30ee805559dbf
treead8548613f78a402a0c93a926489969423d35a6e
parent98a50392900d7b7b6ef0fc187a26e3759844d095
Bug 21172: Remove warning from addbiblio.pl

Argument "01e" isn't numeric in numeric ne (!=) at
/home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507.

A tagfield can be 01e and so raise a warning is compared with == or !=

This patch also fixes few inconsistencies:
- tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField
(to support other marcflavours)
- do not use $_
- loop only once on $usedTagsLib

Test plan:
For devs only, read the code and confirm the changes make sense.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit f3afec0587f4baeff580e153ea592020d4d36be3)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
cataloguing/addbiblio.pl