Bug 25875: Move check for module_bit and code to the JOIN
authorNick Clemens <nick@bywatersolutions.com>
Thu, 25 Jun 2020 10:38:26 +0000 (10:38 +0000)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Thu, 16 Jul 2020 04:36:45 +0000 (16:36 +1200)
commit0cb156cba54e8433a3ea351a322f93c807a934e5
tree3ea2dfa79936189ec4d9adccb4e8d1c070be25c6
parent46248a65d6f773a25d4f568e3b6a5508f6648bf6
Bug 25875: Move check for module_bit and code to the JOIN

If we limit the JOIN to rows with the correct subpermission we won't
duplicate the returned patrons

To test:
 1 - Give a patron full acquisitions permissions
 2 - Also give them several subpermissions on other areas
 3 - Go to Acquisitions
 4 - Edit a fund
 5 - Add a user to the fund
 6 - Search for user above
 7 - They return multiple times in results
 8 - Apply patch
 9 - Restart all the things
10 - Repeat search
11 - Patron appears once

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 721876785142fea84f02c7dbe4f325e2a605bd0f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 59e1e78c6d59ee6ced202382e2910676a4e32360)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
C4/Utils/DataTables/Members.pm