Version 3.20.9

Translations for 3.20.9

Bug 15795: C4/Members.pm is floody (Norwegian Patron DB)

From the mailing list:
"I'm working on 3.22.02 and my logs are FILLED with the following warnings:

Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl
admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl"

I agree. Looking at C4/Members.pm other warns are all prepended with $debug.

TEST PLAN
---------
1) rm Koha/NorwegianPatronDB.pm
   -- quickest and dirtiest way to get the load to fail.
2) echo > ~/koha-dev/var/log/koha-error_log
   -- so it will be easy to spot the log changes.
   -- back up the log file if you really want it.
3) log into the staff client and go to patrons.
   -- Check the log file. "Unable to load ..." will be there.
4) echo > ~/koha-dev/var/log/koha-error_log
5) sudo vi /etc/apache2/sites-enabled/{your koha site file}
   -- Find your staff client entry in your apache
      configuration file and add:
       SetEnv DEBUG 1
6) sudo service apache2 restart
7) apply the patch
8) refresh the patron page
   -- "Unable to load..." will still be there.
9) change the DEBUG value in your apache config to 0
10) sudo sevice apache2 restart
11) echo > ~/koha-dev/var/log/koha-error_log
12) refresh the patron page
    -- "Unable to load..." will NOT be there.
13) git checkout origin/master -- Koha/NorwegianPatronDB.pm
    -- to bring it back.
14) refresh the patron page
    -- "Unable to load..." will still not be there.
15) run koha qa test tools

Signed-off-by: Philippe Blouin <philippe.blouin@inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit b52cbecbfd282060a2a444252d83d263c0783f14)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 410b567a4c7943b052cfeee04fbd3fd986bbecd6)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15622 - Spelling mistake in printfeercpt.pl writen -> written

Search the file for writen, when not found change sucsessful

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit fdd66bc830e8974be67ca43379e4ae3156b0e9cb)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 71e8855f1e0e7e593141061e84b6355b7f09608c)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15416: Warns on guided_reports.pl

Initialising $phase variable to be '' if not defined.

To test:
1) Go to Reports -> Guided Reports Wizard
2) Notice warns
3) Apply patch
4) Refresh page
5) Confirm warns are gone and page still works as it should

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Warns are gone. Page still works as expected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch:
-my $phase = $input->param('phase');
-$phase //= '';
+my $phase = $input->param('phase') // '';

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 17c7c685f12dd09186d369f84cc725984328c5fa)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit fef0f0c367328b1f4ca22b9124783b12706d176e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15743: Allow plugins to embed Perl modules

This patch allows plugins to embed Perl modules by ignoring Perl modules
in plugins directory that don't inherit from Koha::Plugins::Base

TEST PLAN
---------
1) Edit koha-conf.xml to have enable_plugins set to 1, and
   the pluginsdir set to a particular path.
2) Create a dummy plugin file. (e.g. {that path}/Koha/Plugin/Kaboom.pm)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 2a43195322c228795b08ebbc165e360c725c2b56)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 5f96cbd933aad1bade1d06b57e58c205aa6ffa35)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15652: Allow current date in datepicker on opac-reserve

If you enable AllowHoldDateInFuture (and its OPAC variant), you get
an additional "Hold starts on date". In that field and in "Hold not
needed after" it was not possible to enter the current date.

Although it does not really make any difference if you leave the startdate
empty or put the current date in it, we concluded that it still makes
a psychological difference. Some patrons were confused when placing a
hold because the first date to select was tomorrow. Instead of telling
them "Yes, but you can leave it empty", we should just allow the current
date as well.

The expiration date ("not needed after") also started on tomorrow. (This
field can really be empty.) But there is actually no reason not to allow
today here too. If the patron only wants it today, why force tomorrow?

How is this arranged? Well, this is one of the simplest Koha patches ever
written. It only changes the minDate option of both date pickers in one
line from 1 to 0.

Test plan:
[1] Allow future hold dates via systempreferences.
[2] Verify that you can enter today in both fields.
[3] Put today in start and expiration date. Place the hold and verify that
    you can confirm the hold, check out and check in again.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 904a358da38e2945125170c3e9896193f0c288ce)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ae2c66c601a38a30d7ed8e8a074dbb0282de6057)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 11937 - opac link doesn't open in new window

Signed-off-by: Juan Romay Sieira <juan.sieira@xercode.es>

Patch works as expected. From a biblio detail page, the link
'OPAC view: Open in new window' opens a new browser window.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit d1ead7313cf78581e31c4a210f01709ff228fdb6)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit e6cab05555d775d3303deffb9016d03b1753ef6a)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15746: Same fix for "write off"

Same fix as before for the "Write off" button next to the "Pay" button.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit efad45a0e39703017a894d3ffdd1a7078d13af60)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 9973f0e986abf1db68dc177369f85126f77230d2)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15746: Do not record individual payments with randomly picked libraries

When a payment is made individualy, the library used to record this
payment is randomly picked from the library list.
This is because C4::Branch::GetBranch looks at 1. the $branch variable
sent by the template, wich does not exist, then 2. the branchname
cookie, which does not exist neither, then 3. get the first branchcode
from a list of keys (non ordered).

To reproduce:
- Create a manual invoice for a patron
(members/maninvoice.pl?borrowernumber=XXXX)
- Pay this fine using the "Pay" button of the corresponding line from
  the members/pay.pl?borrowernumber=XXXX page
Look at the statistics table:
select * from statistics order by datetime desc limit 10;

The branch value of the first line might not correspond to the library
you were using to pay the payment.

Test plan:
Apply this patch, repeat the steps above and confirm that the library
picked is now the one used to pay.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 80a690588ceac464891dcb2956c3b148433a253c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f2c6d5ad4f042ddcbf7127bc5d440cd8032cc8f4)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15742 [QA Followup] - Tidy script

Script does not appear to have any other modifying patches at this
time based on bz splitter. This is a perfect time to clean up this
script!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 0277c545b0369046e3d2785689ea52b99d84962f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 63230f6bfea8c36246793eaf13791e8a3883af6b)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15742: Remove unnecessary loop in j2a cronjob

If no branchcode is given, all the libraries are retrieved and the same
query (so without using the libraries loop) is executed for each
library.

Test plan:
Use the j2a.pl cronjob to change the category of a child patron
If a branchcode is passed to the script, only the children from this
branchcode should be updated.
But if it is not passed, all children of the DB should be updated.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit cf047247893b04de820ff51e9b2d8f43773af332)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 93c5535eb5498887052d5c44d661b99b3f550461)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15517 Fix test for 3.20

Bug 15517: Update DB rev (3.20.08.004)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit e06c67044e11ffd9defc20af81d78422ff97a775)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15517: Change wording for tests

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 100d800060c26378b91b465926a5993cb5596300)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 9329290fc5f930d2950c27a4f65d7b08acb3d7ec)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15517: deleted* tables won't never differ anymore!

These tests will ensure that the 4 deleted* tables won't never differ
anymore.

Test plan:
0/ Do not execute the update DB entry
1/ prove t/db_dependent/db_structure.t
should fail
2/ Execute the update DB entry and update the schema with
misc/devel/update_dbix_class_files.pl
3/ prove t/db_dependent/db_structure.t
should now be happy

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Test pass successfuly. Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 8b2573e24e50d2911d88aa6d9ec969b51f37284b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 3a64f9c8470b9ae672e7f9ec0baf9d5ee4dd0b5f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15517: Resync borrowers and deletedborrowers tables

The 2 columns password and userid are not sync and could cause errors
when deleting patrons.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit f4f307230ab0aeb3d28566dd0e5e9f7b851800b0)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 17556074415305b47905288773a2d7d71a9ef8cd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15479 [QA Followup] - Tidy sub to remove tabs causing qa script to fail

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit d268d428fd984aeb76f617e0e93ef6fdea543230)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit c8a0323e7b9ee4c736d38f31c8954162ee19c4e5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15479 Add tests for ILS.pm

This patch specifically adds a test for the sub added to
resolve Bug 15479. As no test script existed to add this two
added one which also tests that ILS objects can be instantiated
correctly and offer the required interface

NOTE: This does not apply without the first patch.
      Comment #3 suggested a unit test that would fail
      before and pass after. So while this code is good,
      it missed the before case. -- mtompset

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit df4b1552211aae130b2ac31b44f45892c342e28c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 70ec608f917664411c6fc3357ade58a6261dd86f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15479 Make ILS cardnumber comparison case insensitive

The borrowers table is defined COLLATE=utf8_unicode_ci which means
that cardnumbers may be saved in either lowercase or uppercase and
these are considered equivalent.
The server was performing a case sensitive comparison between
the incoming patron identifier and that retrieved from the db
As a result some renewals were rejected as being on loan to
another borrower if the stored cardnumber differed in case.

Make code comparison comply with db.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 203659ee60b25614eecd01f69e23e3be57952707)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 619060799d5b89c22fe83dfecc229b84a638b0da)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 655e35649c1877224d184de2baf82e3a505ec999)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 46d7a7d2c6fdbd12851777ffd72c2f5175352e07)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature

To Test
- Borrower has some fines and checkouts
- Leave OPACFineNoRenewals empty/blank
- Try to renew items in the OPAC
- notice error message
- Add a big value to OpacFineNoRenewals
- notice renewals work

Leaving the OPACFineNoRenewals empty will disable the feature.

Patch works as expected.(Amended to format the commit message and to
remove a warn on line 112 / MV)
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 47e78f5c290f14c2af53e747ebae7ec317a0dbbd)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f02054cfcd37a6bd41e563cc7a4f50d6c65145ec)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14507 [QA Followup] - Restore comment, tidy sub

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit f56ad87648ddef5cba66a4cbae9efb53a221c09a)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 94e6b71b4e35d852110537a6dcf00fc1ea3f3546)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14507 Use checkpw to check password in Patron Info

Some devices are using patron information responses to validate
patron passwords to govern access to facilities as we
were using C4::Auth::checkpw_hash this only worked in a db password
context not other authentication routines.
The C4::Auth routines are not very consistent and there isnt a dropin
replacement for checkpw_hash this calls checkpw instead.
In a password only environment this behaves as the old version did
returning field CQ as Y if a valid password or no password is passed in
the patron info request and N if an incorrect password is supplied
It should also test against the appropriate authentication sources if
othere autrhentication schemes are in use

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Tested this with a client who reports that this enables SIP authentication to work correctly with their LDAP server.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 0810027bfadd50fe4b93088e9939327fd4c7f6e9)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit cd5640eb9f8835862d695a2572ad9017b771c13c)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 12549: (QA followup) missing newline in CLI dialog

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 002d7f45e5de35d2b052bf99d6d0dbc329775a3d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ae839dbfe4d49f10ee1b93958fd516d7971bf51c)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 12549: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems

Allows for selection of DejaVu font path when installing from the command line. This
is useful for non-debian distributions that don't store the fonts in the same place.

Adds a new configuration variable to Makefile.PL: FONT_DIR

Defaults to the Debian install location for the fonts.

Test plan:
1. Run a CLI install, accepting the defaults.
2. Compare the generated koha-conf.xml to a
previous install - the font path for DejaVu fonts should be the same.
3. Run another CLI install, this time choosing a custom path for the fonts
4. Check that the path selected is reflected in the koha-conf.xml file.

NOTE: 'perl Makefile.pl' and 'make' generates blib/KOHA_CONF_DIR/koha-conf.xml
      ran with a weird string for the font dir
      copied that koha-conf.xml to my home dir
      reran with all defaults
      compared the two, and only the font paths differed.
      Also, I cleaned up the tabs that snuck in. :)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 8c9fe6b2ddb7d9ba2113750d89c0be1e855e9b5d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 7876820211d44624bf65aa70b177555d53206353)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 13534: Update DB rev (3.20.08.003)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 9ad830d04b88e16c44824f3fd1052dd566df3345)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 13534: Do not remove tags on deleting a patron

On deleting a patron, all the tags approved by this user will be
deleted.
This can cause data lost.

Test plan:
0/ Do not execute the update DB entry
1/ Create 2 patrons A, B
2/ Create some tags with patron A logged in
3/ Approve them with patron B logged in
4/ Delete the 2 patrons
=> The tags have been deleted
5/ Execute the DB entry
6/ Repeat 1,2,3,4
=> The tags have not been deleted and are still shown on the interface
(result, detail, tags module)

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit fb419ba83d8c7b6bf710b42ad3fe61701809fc0e)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 71b0885babf336843d931afd09233428f6f8f86d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15818 - OPAC search with utf-8 characters and without results generates encoding error

When searching for something in OPAC which doesn't result in any results but have utf-8
characters in search string we get following encoding error:

Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl5/5.20/Encode.pm line 215.

This is because we are trying to decode string which is allready correctly
marked as utf-8.

Test scenario:

1) enter search string with utf-8 characters in opac which doesn't
   return any results
2) verify that you get application error
3) apply this patch
4) re-run query and verify that errror is gone

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Step 0: Define "OPACNoResultsFound" with '{QUERY_KW}'
Note that I don't get the error (Encode 2.60) but the search terms are
not display correctly.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
The variable to be decoded comes from already decoded vars (via
the -utf8 flag from CGI), following the trail in Search.pm.

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit ea69693997fa5ea6f6eef37290c783b507db1213)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d7587e0567ac97639e84be668a08d5e6985e3e87)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15552: Better wording of intranetreadinghistory

To test:

1) Find intranetreadinghistory system preference in Administration
2) Confirm new description gives more information and makes sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Better wording and much better for translatability purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit c827160122525c45000a4208215ee3fd83aa92b0)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6ce3969d07c5dc55f898d74be9bab41e262314ee)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15571 [QA Followup] - Remove tabs

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit eb542fb1ff91ca8416058c20692a0201f74596e3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit b3b03440f37885cdb4b0d7fe1b49c17cd41a72df)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15571 reserveforothers permission does not remove Search to hold button from patron account

To Test:
1. Create a user without 'reserveforothers' permission
2. Go onto user details
3. 'Search to hold' button should not be there
4. Create a user with 'reserveforothers' permission
5. Repeat steps
6. 'Search to Hold' button should be there

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Briana <brianagreally@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f118addf0f559448cc8ffc13a522ff4b35718fd3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 7fd9119cd8c8dfdbbef4e05cbae55209e07368a2)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15411: Update DB rev (3.20.08.002)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit af61bfbcf827fc51e2f27f45afce9bec349a0bb4)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15411: More changes

Changes to Italian and Polish sql files and catalogue help file.

TEST PLAN
---------
1) Confirm sql is valid and has Non-fiction.
   > delete from auth_vals;
   > source {appropriate file};
2) Staff -> Search -> Help
   -- Confirm Non-fiction
3) Run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
(cherry picked from commit 81c9770f28d13129aa2969c4a243988a4f026a6b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 3b1e74d7ae5e4f2f2c36a982abdea594ae457117)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15574: Better wording for error message when adding a duplicate tag

To test:

1) Apply patch
2) Go to a record (ie opac-detail.pl) and add tags that already exist with that record
3) Confirm new error message

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for common patrons

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 56dde11a4f39b8a9f151d7592a7869f20c8c5f2f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ec9fd6c43f01258d9c26a47d8b8697c62c6887bd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15628: Remove get_branchinfos_of vestiges

The C4::Branch::get_branchinfos_of subroutine has been removed by bug
7034, but 2 occurrences have been left

git grep get_branchinfos_of
C4/Branch.pm:           &get_branchinfos_of
t/db_dependent/Branch.t:      get_branchinfos_of

Test plan:
  git grep get_branchinfos_of
should not return any occurrences.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Vestiges removed

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 7dc0c67640904a19a73e58c6af330af50d6d16d6)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit cd0b768bd0f9fe7fa373f72d74bc20357695bdf5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15638: Spelling mistake in request.pl

To Test-
chek that in line 4 "writen" has been changed to "written"

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 0867ca53d689108475d2bdba94712d6839db928f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 9c1c9285a84d9341432188258ea56ab5e88a434b)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15638: spelling mistake in ~/Koha/reserve/placerequest.pl:4

writen ==> written

To Test-
check that in line 4 of this file "writin" has been corrected to "written"

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 6bb0b6b2d90402bf1c618f32ddfde83529e63ba8)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit e78c5cfb4e8192262f807142a5c74c8ed502bcd3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off

If the user knows the URL for OPAC lists they can access them even with
the virtualshelves preference turned off. This patch copies the solution
added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists
pages.

To test, apply the patch and set the virtualshelves system preference to
"don't allow."

- Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to
  an Error 404 page.
- Also check:
  - /cgi-bin/koha/opac-shareshelf.pl.
  - /cgi-bin/koha/opac-downloadshelf.pl
  - /cgi-bin/koha/opac-sendshelf.pl
  - /cgi-bin/koha/opac-addbybiblionumber.pl
- Turn virtualshelves back on. Access to lists and list sharing should
  be restored.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 2923cfdff4466efed55dd3d3dbee8ba37f6ff882)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 59229f74805c9bdc817b0c5f65b311f9825ce3b3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14406: When adding messages in patron account, only first name is shown in pull down

To test:

Log in to staff patron account
Go to Checkout tab
Click 'Add a new message'
Drop down box should show 'Staff - Internal Note' and 'OPAC - [Full name
of patron]'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Made a tiny change during signoff: uncapitalized "note"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
(cherry picked from commit 9f4d87373abb8517e39c51cdde8fa17104196fea)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f861cf879b5a4e65482ba607e80a0b4a8373fc7e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15684: Fix encoding issues with quote upload

To verify:
- Download attachment 'Goethe with umlaut' from Bug 15684
- Go to Tools > Quote Editor
- Click "Import quotes" and select the file
- The quotes display in a table. Click 'Sav quotes'
- Result: Nothing happens

To test:
- Apply patch
- Repeat steps above
- Verify that you get a message '2 quotes saved' and that the quotes
  are added in to the quotes table
- Test with attachment 'sample quotes' as well

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 59fc32531071e3d4594a8b5555acd41a17921de3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6eb380da3b8908b7a909828082fe95f6d221fe19)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 11569: Update DB rev (3.20.08.001)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 53bbfa2aab5daf148113de1929193b64f3cf19ef)

Bug 11569: Correcting typos in userpermissions.sql

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit cc592b4b38f14813e3ee80c808dfde500e092bd1)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 8635b7b6dc97aa9f329d9f9d0b5ddb2245cc9bba)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15687 [QA Followup] - Tidy sub to remove tab characters

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 6d24219976c332c8fb7da69ceab6374627aeb95c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f9978afb60aa845de07fa0c31e1b35b208a8cabb)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15687: Fix xgettext.pl syntax errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 70112cfb8103c9a760bf9b27e7ed8ecb8e5c9278)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit af24e8ee01877928335727bf04248b3c372ac574)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15760 RMaint Avoid SQL injections

For security purpose, backport a fix to the way the DB connection is
established.

Bug 15298 [QA Followup] - Fix whitespace issues

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f98225c7c231926332bba9ec40de786aa58174d6)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit be7ca57e113d7ba27b86e93ad3ce05e64921b5db)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15298 - z39.50 admin setup, options column suggested changes

To Test-
1-first look at the orginal Z39.50/SRU servers administration page
  (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6)
2-apply patch
3-now see the new styling of the "action" drop down tab like the one on
  the saved reports page
4-check that each link works (for delete i reccommend copying one then
  deleting the copy)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 142c47fcf4ca966f153d7d60e2f448cb2f5c929d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 76326a09818cd6af8a07f427e56b17ff4c9220d5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set

If permission 'circulate_remaining_permissions' is not set, links to 'Circulation'
(/circ/circulation-home.pl) on the intranet home page lead to an error
message: "Error: You do not have permission to access this page."

This patch hides the links if the permission is not set.

To test:
- Apply patch
- Log in to the intranet (staff client) with a patron who has the permission
  'circulate_remaining_pernissions' not set
- Verify that no links to Circulation appear on the intranet start page
  (menu top left and menu in main page area)
- Log in as a user who has the permission set.
- Verify that te links appear as appropriate.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 83936a6b821fe623a6bb7121d128a90107bf703c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit daaf3c758c9ba6e642083f4e198b8ad451444c3f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15598: Also fixing space near exclamation mark in other files

To test:
-Check that the space near to exclamation mark (!) is fixed

Signed-off-by: Briana <brianagreally@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit d3b7ccc87e2da4666617122f05ece2250a7c1500)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 7db70b33a4dedd6d1de321a49f4e4be33fd17293)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15597: Typo in opac-auth-detail.tt

Patch fix a small type

To test:
- Verify that a double punctuation mark colon (:) is fix it.

Signed-off-by: Briana <brianagreally@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 386aafd8bda94581c4eaa070552bf9a025306ceb)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6cb7dc0c0a06839892bcba9172a1603793481f90)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15589: Changing 'his' to 'their' in OPAC lists

To be more gender neutral

To test:
1) Go to OPAC lists (opac-shelves.pl)
2) Confirm it now says "Allow anyone to remove their own contributed
   entries."

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 229cc7e8be66b61b2a0070a83d63cb7afb513d3f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d26086a84c9909dcc96d4f35086f4028a3e4c8bd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15375 [QA Followup] - Fix non-functional restriction message and date

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 43694867676ed627759a302ade7d666ab029490b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit db2a954579499d8f21670c157ee50959fe50143e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15375 [QA Followup] - Remove refereces to biblio and biblionumber for patron messages

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit a633af13b6851a15b71140ab123105d02c803da3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 73bf2f2dc83974a9d33c7b02078697a84111def3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15375 - Translatability: Fix issues on OPAC page 'Placing a hold'

Fix several issues with odd translations on opac-reserve.tt due to
string splitting by tags.
In addition, streamline messages to make them similar to the same
messages on the OPAC summary page (Bug 15374)

To test:
- Apply patch
- Log in to OPAC
  - with blocked /debarred user (with and without comment and date)
  - with user who has to much fines
  - with user who has his card marked as lost
  - with user with expired account
  - with user with uncertain address information
- Try to put holds
- Verify that message about why holds are not possible is correct
  and displays nicely and that links in messages work
- Carefully examine code
- Search for regressions

(Amended: stray i removed, test plan updated, removed account that
          is about to expire)

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

I am going to sign off on this because it works as it should and I think the problems I had in comment 8 are a separate bug.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f0face38698b5c803604b37509edad98e2291bcd)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit dceb3ed02284270af12b711014d30555115403f8)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15190: Bad utf8 decode to unapi and fixing status code 200

Fix bad utf8 decoding, also fix status code 200 for no parameters passed to
script

To reproduce the issue in OPAC
1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with
   special characters
2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc
   play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc.
   Note: marcxml does not fail
3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise
4) An oai_dc record will display, notice about the bad utf8
   decoding characters
5) Search the record in OPAC
6) To reproduce code 200 Ok and 300 Multiple choices play with:
    cgi-bin/koha/unapi
    cgi-bin/koha/unapi?id=koha:biblionumber:4
7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162)

Test plan
-Apply patch
-Follow steps 2 to 6
-You will see no errors in utf8

Followed test plan, works as expected.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 283d80729a49c8821a5ce95bcf3affd24cce93e6)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 4f976932a489f347becd5eb7f27952dcda35fa3d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15624: Spelling mistake in suggestion.pl

Test - due to noone being in a comparison name it was not changed
1. search for choosen, see that it was removed
2. search for agregate, see that it was removed

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Typos fixed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 9c2b0ea1158f7c3cd47e3ece8aa6575f78cc304f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ac36fe478adeb8d0565ca1538db25a57b60380cd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

15623 - Spelling mistake in boraccount.pl Test - Search for writen, if not found fix is correct

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Gus: You should try git grep writen one more time :)

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 17a2426e0f6ea79eeea7e70acb670111ee6fa5f5)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d5dd89ff78f733be327f258ed1b8be16e3d030ef)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15621: Spelling mistake in printinvice.pl

Test- search for writen, if not found patch successful

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Typo fixed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 12bd1dc60171fb9c85ef7176908a9f205190b2a6)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit e23abce8ddd275505caeaaef058e8a90bf61495a)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15619: Spelling mistake in memberentry.pl

Test - Check file for 'konw', notice no instance

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Typo fixed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 89978bab103cbcf7e83e69d47851e9b0bc16238a)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 45095c007839fb4cd46e52e2b3188d9d2b50ebda)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15614 - Spelling mistake in circ/pendingreserves.tt: Fullfilled

To Test:

Check if "fullfilled" has been changed to "fulfilled" in line 137

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 69b5fc9aa16891d7425685219a41078581ef2383)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 644e69cb7fa3aac68abe610b7b59045dc92d8d29)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15613: Fix 2 other occurrences of paramter vs parameter

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 6c80367f85b92f7b66c9b6255f836bc29f40d660)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 8013976d3e00eb3c9ae3370aaa925e0c29048e06)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15613 - Spelling mistake in opac-shelves.tt

Spelling mistake in opac-shelves.tt paramter ==> parameter

To test - check the change is made in the file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 9a109fde4caf3e983f086e60f61cf2fa59b225dd)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 314f1f7a2f116bc6a18fe2f14883f5e3bf2a3760)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15611: Fix another implimented vs implemented

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 2723e463c0f3b9ee6cec77309bf5f2d97779be02)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6c1b8ddffee6f9c414a14e02b10b428b04eb5e5e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15611 - Spelling mistake in patroncards/edit-layout.tt

To Test:

check that "implimented" has been changed to "implemented" on both lines
478 and 534

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 88607dfaf1d470a24b0b27d0ef4b2be8967cf93a)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 74680de7361c31ae87ca35d3e4a6347b05747067)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl

Removes warn using Jonathan's suggestion!

To test:
1) Reproduce warns by clicking New Subscription
2) Apply patch
3) Click New Subscription again
4) Confirm warns are gone

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Patch removes the warn that come when clicking "New subscription"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit fe7940257537042ff6ffab9c7b718e5b8a5dc368)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 0e6346c614bd5707d79fc376dd4d9028c5086bc9)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14480: Silences warn from editing patron

Argument "" isn't numeric in numeric lt (<)

TEST PLAN
---------
1) Go to any patron in staff client
2) Click 'Edit'
3) Check error logs
   -- warnings should exist.
4) Apply patch
5) Reload page
   -- warnings should not be triggered.
6) Add restriction and save
7) Go back to edit screen
   -- restriction should be shown
8) Remove restriction and save
9) Go back to edit screen
   -- Should say "Patron is currently unrestricted"
10) Run koha qa test tools.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 11109501eb6c8b8ee55390cd9860ac6dbf8c908c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit c08a13593cbc3a60ac3d5345c93c6c4c362a3835)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15553: [QA Follow-up] Replace hardcoded tmp and add instance to dirname

If you use multiple instances on one server, you could have the situation
that instance A creates the cgisess subfolder and instance B could have a
permission problem. This patch resolves that by allowing each instance to
have its own cgisess subfolder.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit c4934b2dab427da4304913b3f0f26e0a24606896)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d259eaac7ba240cbe9008271d9d123a5758547d8)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15553 - [SIGNED-OFF] cgisess_ files polluting the /tmp directory

When some users want to improve performance, one suggestion is to switch the syspref "sessionstorage" to 'tmp',
which store the session info in the /tmp directory instead of the database.

Depending on the frequency of the cleaning process (or lack thereof),
this can be heavy pollution into the /tmp directory, making it unusable.
"rm cgi*" would not even work since cgi* extends to over 8000 items...

A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess.

Testing scenario:
1) change the syspref SessionStorage to 'tmp'
2) Log into the OPAC, validate that a file named /tmp/cgisess_(something) got created
3) Apply the patch
4) Log into the OPAC, validate that a file /tmp/cgisess/cgisess_(something) got created

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Works as advertised. Session files are created in /tmp/cgisess/ instead
of directly in /tmp. I usually store sessions in memcached, but a
couple of times memcached has died on me, and before I knew it, /tmp
was so full of sessions files, I could not easily delete them with
"rm /tmp/cgisess*". Being able to delete /tmp/cgisess/ should be a
bit easier.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 3815915a3338c4380da7773acc675b07ac82562d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6efb2ebc0f81c5eaa7e42475495131f578487ffc)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15468 - Search links on callnumbers with parentheses fails on OPAC results page

To Test:
1-before plugin search in opac for a call number with either a "(" or a ")" in it
2-it should come back with no results
3-use plugin
4-re-search the call number with "(" or ")"
5-the search should come back with results

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
It seems this only works with OPAC XSLT for results page turned off
and OPACItemsResultsDisplay turned on. - Then the callnumbers
in the result list will be linked for searching.

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 6d9a75014e1f1ef7dc84a3d14643271658eacc2e)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 27f9eb01197dddb95332871eb5c1ba4fe3589af0)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15592 - spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt

To Test:

checkthat "extention" has been changed to "extension" on line 27

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 70086f1681155d8e63c9ee1b149c3f812df8f125)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 841aa118e575470af73ef3160c63a421b6d99b58)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator)

This patch adds a separator for multiple 508 fields to the XSLT display
in the staff and OPAC detail view.  Separator is wrapped in span with
class=‘separator’ for easy manipulation via css.

To test:
* Search the OPAC
* Click the title with multiple 508 fields
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 1c5f75fde534db8a2b1329d5dfb83d34d9d29982)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit c68d58259ef27d187b67f8d39d8dd7578173b1e1)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15476: Listname not always displayed in shelves.pl

To reproduce:
  - In staff client, go to List and click on the name of an
    existing list.
  - At the bottom of the screen, you see a title "Add an item to "
    but no list name.

To test:
  - Apply patch
  - Verify that listname appears after "Add an item to "

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Label/legend for listname displayed Ok

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit df13a5d3e7727f6a7db67aac618fb85c135b2723)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 67c26ef476319149954794244310c990552dbf4e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented

To Test Check perldoc for misc/cronjobs/advance_noitces.pl
and see that the documentation matches.

Ran:
$ perldoc misc/cronjobs/advance_noitces.pl
Saw expected changes.
Koha QA test tools pass too.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Switched due date for the name of the database column
date_due as the parameter expects a list of database
column names.

(cherry picked from commit 4120e48b0ffe974636f8b070ea3c3f3956948409)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit b3586e5dc7b5c6646c403ee144b33853c21b77cb)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15609 - spelling mistake in :692: writen ==> written

To test:

Check that "writen" has been changed to "written" on line 692

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f37ce198feae78b82b751f1c3d682010b4db0305)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 87e96810fc548c3301be54135fa6cc918f83f1fc)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15299: Ask for confirmation when deleting a report from second page

Some link are hidden when loading the page, by DataTables, we need to
use the delegate jQuery method to attach a handler to the click event
for all delete links (the ones existing when loading the page, and the
ones displayed in the future).

Test plan:
Have more than 20 reports defined
Go on the report list view, then change the number of elements
displayed, click "action>delete". You should get a warn.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Confirm that there is now a confirmation on delete from the list -> action menu

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit dcce65c8fd6f6d4963a3dd0e8b73a79548a2aa8b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt

(cherry picked from commit dfdf3c15de1fc741f6aafcea83d340728c6bffc3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14810 Improve messages in patron anonymizing tool

To test:
Create circulation records
Go to 'http://localhost:8081/cgi-bin/koha/tools/cleanborrowers.pl'
Anonymize patron checkout history
Message should read 'All checkouts older than [date] have been
 anonymized
When patch is not applied, message reads 'All patrons with checkouts
 older than [date]  have been anonymized"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit e38564d2132e1e102cec23d239fb81cd987b3de8)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 2f3843af990491ea9e628c064838b904f9e9223d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14555: Warns in opac-search.pl

Avoid use of uninitialized value in split

== Test plan ==
1. Go to opac advanced search
2. Click "Search" without any search query
3. Log file will show "Use of uninitialized value in split at ..."
4. Apply this patch
5. Repeat step 1 and 2
6. Log file should no longer show "Use of uninitialized value in split at ..."

Sponsored-by: Regionbibliotek Halland / County library of Halland
Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
At step 2 you have to check a criteria

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit ab81a0feeebf1c01857755f53060dcc255960e9b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 34f20412f89e9320e0fe2a0a3778a3e680566ec3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 12636: Do not display unique patron attributes in the batch patron modification

Batch patron modification should not offer to update patron attributes
with values which are designated as unique since such attributes are
required to be unique to a single patron.

Test plan:
Create some patron attributes, some should be unique.
Use the batch patron modification tool to modify patrons.
With this patch, the patron attributes marked as unique won't be
display anymore.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit b7b94b7012704d99a91ce32723404095a68fe6f1)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 4c0506f33e07807d548fe4870d25ea367015c0e1)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 14133: Print notices should be generated with the print template

If the overdue notice to send is an email or a SMS and the patron does
not provided such information, a print notice is generated.
But it will be generated with the email or sms template, which is not
useful, especially in the SMS case.

The template to use should be the print one.

Test plan:
0/ Does not apply this patch and Correctly define the overdue rules to generate
an overdue notice to the message_queue table.
Check email + SMS
1/ Define an email address and a SMS number for a patron
2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t])
3/ 2 notices should have been generated:
    mtt=email with the email template used
    mtt=sms   with the sms template used
4/ Truncate the message_queue table
5/ Remove the email address and repeat 2
6/ Only 1 notice should have been generated:
    mtt=print with the email template used
7/ Truncate the message_queue table
8/ Remove the sms alert number and repeat 2
9/ 2 notices should have been generated:
    mtt=print with the email template used (or sms I suppose)

10/ Apply this patch and repeat previous steps.
The print notices should be generated with the print template.

IMPORTANT NOTE: This test plan does not take into account the notices
generated for the staff ("These messages were not sent directly to the
patrons."). However the behavior will also change, the print template
will be used in all cases. Is it what we want?

Signed-off-by: Chris <chris@bigballofwax.co.nz>

Seems fine by me

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 581759e985c170db0edb4a895cda641930e5ac11)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d55a5ca464f6af91419cab74ee91dbacff9c9722)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15577: Correcting link redirect

To test:
1) Add a restriction to a user
2) Log in as that user in the OPAC
3) Click 'your account page' link in the yellow mesage
4) Confirm you are taken to opac-account.pl

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 5b6457087d0c8be00cbe3d54a7e157706f74908b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 7cfa560631c5a0d116b02aa0499f9da69f8351c0)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15357: Display existing holds even if no items exist

If all the items have been deleted for a record and holds exist, the
holds are not displayed.  You are not able to delete the items from the
record detail page, but you can from the items page.

Test plan:
1 - Place 1 or more title level holds on a record.
2 - Delete each item individually.
3 - Note that you see the number of holds on the record details page
With this patch, that holds are accessible via the holds tab.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 0e4b703d239551207ca72c5b201475418c7cfd9c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 2903bc2909180d3f021f7caf2c1181b2a00c5b2f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15353: Display the patron image where needed

On the 3 following pages, the patron image was not displayed:
   members/discharge.pl
   members/pay.pl
   members/paycollect.pl

Test plan:
Apply this patch and confirm the image is now displayed

Followed test plan, image displays as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit bb0c2fce1b87222933bfa5dd02ca614521ba2a0c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 64eb1f88ea741ca06b0a17bf4186ad25c7487f81)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15398: Hide Staff members only in the patron deletion/anonymization tool

On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan
was to hide the Staff members from the tool.
But the test was wrong, it was done on the category_code instead of the
category_type value.

Test plan:
1/ Create a category 'Student' which is not part of the Staff
(category_code=S, category_type!=S)
2/ Create a staff category (category_type=S)
3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and
confirm that the category Student category is displayed in the dropdown
list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=15308

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 6f0cdee69b670f1c49693198e335deb26470d961)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 5349313187dbea4804b7d0e28db7ad16827afbe5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15391: Fix HoldsQueue.t tests

Prior to this patch, in HoldsQueue.t:
 63 my @item_types = C4::ItemType->all;
 64 my $itemtype = grep { $_->{notforloan} == 1 } @item_types
 65   or BAIL_OUT("No adequate itemtype");

Then we use the $itemtype variable (which contains the number of item types not for loan):

 92 $dbh->do("INSERT INTO biblioitems (biblionumber, marcxml, itemtype)
 93           VALUES                  ($biblionumber, '', '$itemtype')");

There is obviously something wrong here.

The code should be

 64 my @not_for_loan = grep { $_->{notforloan} == 1 } @item_types
 65   or BAIL_OUT("No adequate itemtype");
 66 my $itemtype = $not_for_loan[0]->{itemtype};

But then some tests don't pass:

Actually the problem comes from:
commit bfbc646fdd9ca4b90a0bc2751d0faa95d9e93ba1
  Bug 10336: HoldsQueue.t needs to create its own data

-my $itemtype = $dbh->selectrow_array("SELECT min(itemtype) FROM itemtypes WHERE notforloan = 0")
+my @item_types = C4::ItemType->all;
+my $itemtype = grep { $_->{notforloan} == 1 } @item_types

The line should have been:
my $itemtype = grep { $_->{notforloan} == 0 } @item_types

Test plan:
Confirm that the tests still pass after this patch applied.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
All tests pass pre and post patch

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit b340d1f5bd02e1ddb535db13e321e6b07a166725)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 31ab3b277c51c5ae8c3b6ccdfa2a9e007b85a0e3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 9754: koha-remove optionally includes var/lib and var/spool

Currently, the files in the folder /var/lib/koha/[instance] and also
in /var/spool/koha/[instance] are not removed.
This patch adds the option -p|--purge-all to include those two
directories when removing files.

Note: There was a small bug in the for loop. On the -k line the extra
shift statement is one too much.

NOTE: Verify that you use the adjusted koha-remove in the test plan
and not accidentally an older version of this script.

Test plan:
[1] Create an instance test.
[2] Run koha-remove and verify that /var/lib/koha/test still exists.
[3] Create an instance test2.
[4] Run koha-remove -k -p and verify that the sql database still exists
    but the two instance folders in var/lib/koha and var/spool/koha are
    gone.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 1d99fa026bb05225df93e56740456ba185a5937d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 69fd29942c843b8b15df1bb75cd25451344341ba)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

 Bug 15209: Check the parameter at the beginning of the subroutines

It seems better to check if parameters exist at the beginning of a
subroutine.
It makes the code easier to read and there is 1 indentation level less.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 372881ebfd5552ecb83450c7afea6a76f2df1a0b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 7132c9b49ca0c2abf7592d56e4b467be9107dd3f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15209: Add tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit c273e888b0468c6d8e943f9989f6680dc63203fa)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit bc287802a996b265d008845867f1691eeca576d9)

 Bug 15209 Validate passed MARC::Record objs in C4::Koha

Ensure that a passed MARC::Record is defined before calling
its methods. Otherwise you are open to occurences of the
error 'Can't call method "field" on an undefined value'
In a CGI environment you can live with such sloppiness but
in a persistent environment the error can cause the instance
to abort.
Made all routines passed a MARC::Record validate it before calling
its methods. Changed the parameter name from the meaningless
record to marcrecord to indicate its content. Added an explicit return
for all cases where no valid data returned. Cleaned up some logic for
clarity. I think we can assume that GetNormalizedOCLCNumber meant to
look at all 035s till it found an OCLC number not just the first.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 960458dee4a9c09506f48fa73950c0e2da3611e7)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 958985b2ff7304cc55a620e0cd1f09d31d213463)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15240: [QA Follow-up] Minor adjustments

This patch does:
[1] It removes some unused modules.
[2] It adds some options not listed in the synopsis.
[3] It removes an unused sql expression from one query.
    Note: In fines related code the third parameter of CalcFine sometimes
    is named as days_overdue too.
[4] Corrects a few typos in comments or pod.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 8d072272fa396820ec655fb7b45d30eee6fca3e8)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit b94fc3419dc04d06d7557753cea619633ab4c8dd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15240: Do not process issues with a date due later than today

There is no need to do this job in Perl, MySQL could do it instead.
The idea is to only retrieve the issues info which could be overdued.

To test:
1/ Run the script
2/ Apply the patch
3/ Run the script again, notice the exact same results but execution time is faster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 0d36c27678a6968304990759657e2312338763eb)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit e46923af8829f7da9eb3b94e89831b32e68df040)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15680 - Fresh install of Koha cannot find any dependencies

Revert "Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm"

This reverts commit 0e356b214eb049a446a8d089d579775aa49287d7.

Fixing the evals in PerlModules.pm to pass perl critic has caused
a regression. If appears that using a block eval will not work here,
at least not in its current form.

(cherry picked from commit c2f667b4f220c5f3cfb904759b5d4bee679f1ed7)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ff73d0415fade98b79dcaa185640fff694ea80a5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 12045 - Transfer impossible if barcode includes spaces

have changed the code which strips the white space to only remove the leading and trailing white space instead

To Test-
1- go to circulation -> transfer
2- attempt to tranfer an item where the barcode has a space in the middle of it
3- it should fail
4- apply patch
5- try again
6- it should work

NOTE: I purposefully added: die "($barcode)";
      Before, all spaces were removed.
          '    white space    ' became '(whitespace)'
      After, only external spaces were remove
          '    white space    ' became '(white space)'

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 47caf69a469cb48ef18754d2e3bf077e5e882aa4)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 8fa06fdfde407522d6f647527e1b3fefa52a154d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15530 - Editing a course item via a disabled course disables it even if it is on other enabled courses

It appears that if the course item is edited by clicking the edit link
from an active course, the course item will be set to enabled and the
fields will be swapped, if the same course item is edited from a course
that is *not* active, the course item will be set to *not* enabled, and
the original fields will be swapped back in!

The short term work-around is to only edit course items from an enabled
course if the item has a course that is enabled. If all the courses it
is on are disabled, it doesn't matter what course the item is edited
from.

Test Plan:
1) Create two courses, 1 enabled and 1 disabled
2) Add an item as a course reserve to both courses
3) Edit the course reserve data for the item via the enabled course
4) Note the course item is enabled ( easy way is to check the database )
5) Edit the same course reserve data, but via the disabled course
6) Note the course item is now disabled even though it is part of
   an enabled course!
7) Apply this patch
8) Repeat steps 1 through 5
9) Note the course item is still enabled

Signed-off-by: Margaret Holt <mholt@bastyr.edu>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit d10adb26aa661a6b5f6dc9b2fd6f8ab966f98918)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 4739952294165f764ee7074f5a71235e328697a3)

Bug 15530 - Add Unit Test

Signed-off-by: Margaret Holt <mholt@bastyr.edu>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 31ffdbf49af617db29c8b6bfcaf01566d84f2a33)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit cd7d29440f8b1f88b88cba0d9934e3907847793b)

Bug 15188: Do not remove unused auths if zebra is not reachable

Other conn errors should be checked (wrong user/pwd, etc.)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit a60943bc1b28696459ea5a28df9874083b9f0966)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 67b3f0196ea4129488193f27fd3e28591ff5f33d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Bug 15188 - Fixes remove_unused_authorities.pl will delete all authorities if zebra is not running

Test plan:

1) Shut down zebra: koha-zebra-ctl.sh stop
2) Execute the script: remove_unused_authorities.pl (with -t if you
   don't want to really delete from your database).
3) Check that the script would have deleted all the authorities (eg:
   31449 authorities parsed, 31449 deleted and 0 unchanged because
   used).
4) Apply patch
5) Run, notice that the script dies because zebra is unavailable

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 128e7f54b17501ee43614aa8f8c50c3789921f08)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6b6213deea813bf9040dfa5232546b9a48b41e37)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

 Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 8ca35dc7a9291a685a4d22aaf2c18e8023c7be4f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 8022419f58b7dc861f235e568b4abd4c9b26f352)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

 Bug 6679 - Fixing code so it passes basic Perl:::Critic tests

opac/ilsdi.pl: Stricture disabled at line 217, column 17.  See page 429 of PBP.  (Severity: 5)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f2eb9681457627e24ba44bcbb0aa64792a88cc4e)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit a6f2231b4fe772b2f2fa5c5ac3bed3449013f163)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm

Expression form of "eval" at line 71, column 9.  See page 161 of PBP.  (Severity: 5)

Expression form of "eval" at line 85, column 13.  See page 161 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 0e356b214eb049a446a8d089d579775aa49287d7)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f8bd7e717927c65782f544ee0b5a3ec38a3330ad)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>