Bug 20376: Make select/unselect all ignore disabled checkboxes on batch record deletion
authorMaksim Sen <maksim.sen@inlibro.com>
Mon, 12 Mar 2018 20:15:30 +0000 (16:15 -0400)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 24 Apr 2018 05:33:33 +0000 (07:33 +0200)
Test Plan:

0.1 - find at least one biblionumber that has at least one item checked out
0.2 - find at least one biblionumber that has zero items checked out.
1 - Go into the module "Tools > Batch record deletion"
2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2
3 - click continue
4 - biblionumbers with at least one item checked out should not be clickable.
5 - biblionumbers with zero items checked out should be clickable.
6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes.
7 - apply patch
8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes.

Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 336e7faaf451ff29d43a4a557861fbc8511c8e5e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt

index 06805e3..868aea2 100644 (file)
@@ -11,11 +11,11 @@ var MSG_CANNOT_BE_DELETED = _("This record cannot be deleted, at least one item
 $(document).ready(function() {
   $("#selectall").click(function(e){
     e.preventDefault();
-    $(".records").checkCheckboxes();
+    $(".records").checkCheckboxes(":input[type='checkbox']:not(:disabled)");
   });
   $("#clearall").click(function(e){
     e.preventDefault();
-    $(".records").unCheckCheckboxes();
+    $(".records").unCheckCheckboxes(":input[type='checkbox']:not(:disabled)");
   });
   $("#selectwithoutitems").click(function(e){
     e.preventDefault();