Bug 20998: Only perform quicksearch if patron found with cardnumber
authorNick Clemens <nick@bywatersolutions.com>
Tue, 26 Jun 2018 15:02:02 +0000 (15:02 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 29 Jun 2018 19:05:57 +0000 (19:05 +0000)
This patch makes sure we have a patron before we try to access their
branchcode and allows search to work

To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error
6 - Apply patch
7 - Try the search again
8 - Success!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

members/member.pl

index 7dc0b1e..2fc7fb4 100755 (executable)
@@ -53,7 +53,7 @@ if ( $quicksearch and $searchmember ) {
         $branchcode = $userenv->{'branch'};
     }
     my $patron = Koha::Patrons->find( { cardnumber => $searchmember } );
-    if( ( $branchcode and $patron->branchcode eq $branchcode ) or ( not $branchcode and $patron ) ){
+    if( ( $branchcode and $patron and $patron->branchcode eq $branchcode ) or ( not $branchcode and $patron ) ){
         print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=" . $patron->borrowernumber);
         exit;
     }