Bug 11468: Remove given/when from Koha::Dateutils

given and when give warnings due to their experimental
status as of perl 5.18. Replace the construct with
an if/elsif to avoid the keywords

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, especially t/DateUtils.t.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit b529ca00e0cac093fc32a1d123cdbcc84582c155)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 01e627b6412bbb3d2fc82900014c118dc5b06a57)

diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
index 714b171..fba1062 100644 (file)
--- a/Koha/DateUtils.pm
+++ b/Koha/DateUtils.pm
@@ -124,31 +124,28 @@ sub output_pref {
     my $time_format = $force_time || C4::Context->preference('TimeFormat');
     my $time = ( $time_format eq '12hr' ) ? '%I:%M %p' : '%H:%M';
 
-    given ($pref) {
-        when (/^iso/) {
-            return $dateonly
-                ? $dt->strftime("%Y-%m-%d")
-                : $dt->strftime("%Y-%m-%d $time");
-        }
-        when (/^metric/) {
-            return $dateonly
-                ? $dt->strftime("%d/%m/%Y")
-                : $dt->strftime("%d/%m/%Y $time");
-        }
-        when (/^us/) {
-
-            return $dateonly
-                ? $dt->strftime("%m/%d/%Y")
-                : $dt->strftime("%m/%d/%Y $time");
-        }
-        default {
-            return $dateonly
-                ? $dt->strftime("%Y-%m-%d")
-                : $dt->strftime("%Y-%m-%d $time");
-        }
+    if ( $pref =~ m/^iso/ ) {
+        return $dateonly
+          ? $dt->strftime("%Y-%m-%d")
+          : $dt->strftime("%Y-%m-%d $time");
+    }
+    elsif ( $pref =~ m/^metric/ ) {
+        return $dateonly
+          ? $dt->strftime("%d/%m/%Y")
+          : $dt->strftime("%d/%m/%Y $time");
+    }
+    elsif ( $pref =~ m/^us/ ) {
 
+        return $dateonly
+          ? $dt->strftime("%m/%d/%Y")
+          : $dt->strftime("%m/%d/%Y $time");
     }
-    return;
+    else {
+        return $dateonly
+          ? $dt->strftime("%Y-%m-%d")
+          : $dt->strftime("%Y-%m-%d $time");
+    }
+
 }
 
 =head2 output_pref_due