Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists...
authorNick Clemens <nick@bywatersolutions.com>
Wed, 7 Nov 2018 01:32:26 +0000 (01:32 +0000)
committerJesse Maseto <jesse@bywatersolution.com>
Tue, 18 Dec 2018 20:23:55 +0000 (20:23 +0000)
To test:
1 - Create four users:
    1 superlibrarian (or with both edit patrons and manage patron
            lists)
    1 with only edit patrons and catalogue
    1 with only add to list and catalogue
    1 with catalogue but neither edit patrons or manage patron lists
2 - Search patrons signed in as each user
3 - Note different sorting
4 - Apply patch
5 - Try searching with each patron
6 - Results should always be sorted by surname, firstname
7 - Only in the case of neither extra permission should the checkboxes
be absent

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 96b3889390f8efe9851aaa9c2cafa9e20bda3f43)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit f228847155bc46433cbad4f834c2df89734b9c5c)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>

koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

index 89ed6c5..be06c92 100644 (file)
                 },
                 'bFilter': false,
                 'bAutoWidth': false,
-                [% IF CAN_user_tools_manage_patron_lists %]
+                [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %]
                     'aaSorting': [[2, 'asc']],
                 [% ELSE %]
                     'aaSorting': [[1, 'asc']],