Bug 15682 - Only allow merging of 2 or more records form lsits (for consistency)
authorNick Clemens <nick@bywatersolutions.com>
Mon, 28 Mar 2016 20:09:01 +0000 (20:09 +0000)
committerChris Cormack <chrisc@catalyst.net.nz>
Sun, 19 Jun 2016 22:37:08 +0000 (10:37 +1200)
Test as above but on shelves.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.z>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
(cherry picked from commit 9550e37fc66402500adf8bca7a1c90ee0104cdd0)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 9f1e23735f46a8b014d4a8983796f1b8b37cc9b4)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt

index e6fd5bd..a4fb74b 100644 (file)
@@ -185,14 +185,18 @@ $(document).ready(function(){
      * This function checks if the adequate number of records are checked for merging
      */
     function MergeItems() {
-       var checkboxes = $("input:checkbox:checked");
-        var nbCheckbox = checkboxes.length;
-       if (nbCheckbox != 2) {
-           alert(_("Two records must be selected for merging."));
-       } else {
-           location.href='/cgi-bin/koha/cataloguing/merge.pl?biblionumber=' + checkboxes[0].value + '&amp;biblionumber=' + checkboxes[1].value;
-       }
-       return false;
+        var checkboxes = $("input:checkbox:checked");
+        if (checkboxes.length < 2) {
+            alert(_("At least two records must be selected for merging."));
+        } else {
+            var params = [];
+            $(checkboxes).each(function() {
+                params.push('biblionumber=' + $(this).val());
+            });
+            var url = '/cgi-bin/koha/cataloguing/merge.pl?' + params.join('&');
+            location.href = url;
+        }
+        return false;
     }
 
     /**