Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode

It is used in list context, but we need a scalar value.
Can be fixed by adding scalar's, or returning empty string as here.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
index 3421bda..37c9c69 100644 (file)
--- a/C4/SIP/ILS/Item.pm
+++ b/C4/SIP/ILS/Item.pm
@@ -196,12 +196,12 @@ sub hold_patron_name {
 
 sub hold_patron_bcode {
     my $self = shift;
-    my $borrowernumber = (@_ ? shift: $self->hold_patron_id()) or return;
+    my $borrowernumber = (@_ ? shift: $self->hold_patron_id()) or return q{};
     my $holder = Koha::Patrons->find( $borrowernumber );
     if ($holder and $holder->cardnumber ) {
         return $holder->cardnumber;
     }
-    return;
+    return q();
 }
 
 sub destination_loc {