Bug 24378: Change wording of auto_renewals notice in updatedatabase

On the template of AUTO-RENEWALS the wording is grammatically incorrect:

[% IF checkout.auto_renew_error == 'too_many' %]
You have reach the maximum of checkouts possible.

This should say
[% IF checkout.auto_renew_error == 'too_many' %]
You have reached the maximum of checkouts possible.

Test plan:
- Make sure you have the AUTO_RENEWALS notice with the problematic
  spelling
- install patch
- update database
- confirm changes to notice name and wording

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Kept Andrew's change on the original updatedatabase entry,
but removed the database update to be done a little differently
in a follow-up patch.

Amended test plan.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
index d751465..d31355c 100755 (executable)
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -14438,26 +14438,26 @@ if( CheckVersion( $DBversion ) ) {
     }
 
     $dbh->do(q{
-        INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'notification on auto renewing', 'Auto renewals',
-"Dear [% borrower.firstname %] [% borrower.surname %],
-[% IF checkout.auto_renew_error %]
-The following item [% biblio.title %] has not been correctly renewed
-[% IF checkout.auto_renew_error == 'too_many' %]
-You have reach the maximum of checkouts possible.
-[% ELSIF checkout.auto_renew_error == 'on_reserve' %]
-This item is on hold for another patron.
-[% ELSIF checkout.auto_renew_error == 'restriction' %]
-You are currently restricted.
-[% ELSIF checkout.auto_renew_error == 'overdue' %]
-You have overdues.
-[% ELSIF checkout.auto_renew_error == 'auto_too_late' %]
-It\'s too late to renew this checkout.
-[% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %]
-You have too much unpaid fines.
-[% END %]
-[% ELSE %]
-The following item [% biblio.title %] has correctly been renewed and is now due [% checkout.date_due %]
-[% END %]", 'email');
+            INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES ('circulation', 'AUTO_RENEWALS', 'Notification of automatic renewal', 'Automatic renewal notice',
+        "Dear [% borrower.firstname %] [% borrower.surname %],
+        [% IF checkout.auto_renew_error %]
+        The following item, [% biblio.title %], has not been renewed because:
+        [% IF checkout.auto_renew_error == 'too_many' %]
+        You have reached the maximum number of checkouts possible.
+        [% ELSIF checkout.auto_renew_error == 'on_reserve' %]
+        This item is on hold for another patron.
+        [% ELSIF checkout.auto_renew_error == 'restriction' %]
+        You are currently restricted.
+        [% ELSIF checkout.auto_renew_error == 'overdue' %]
+        You have overdue items.
+        [% ELSIF checkout.auto_renew_error == 'auto_too_late' %]
+        It\'s too late to renew this item.
+        [% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %]
+        Your total unpaid fines are too high.
+        [% END %]
+        [% ELSE %]
+        The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due %]
+        [% END %]", 'email');
     });
 
     SetVersion( $DBversion );