Bug 22908: Add tests
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 14 May 2019 17:21:57 +0000 (12:21 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 30 May 2019 20:16:56 +0000 (21:16 +0100)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 9613d9f1647bfceeb15b60c731f2c84796a12f87)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

t/db_dependent/Suggestions.t

index 2d2bfb5..4b86678 100644 (file)
@@ -18,7 +18,7 @@
 use Modern::Perl;
 
 use DateTime::Duration;
-use Test::More tests => 103;
+use Test::More tests => 104;
 use Test::Warn;
 
 use t::lib::Mocks;
@@ -197,6 +197,13 @@ is( @$messages, 1, 'ModSuggestion sends an email if the status is updated' );
 is( CountSuggestion('CHECKED'), 1, 'CountSuggestion returns the correct number of suggestions' );
 
 
+$mod_suggestion4->{manageddate} = 'invalid date!';
+ModSuggestion($mod_suggestion4);
+$messages = C4::Letters::GetQueuedMessages({
+    borrowernumber => $borrowernumber2
+});
+is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
+
 is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
 $suggestion = GetSuggestionInfo($my_suggestionid);
 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' );