Bug 21425: Display basketno correctly in Order error msg

carp will display the hash value instead of the desired basketno
in the error message unless we change its behaviour

Use the simpler but effective option of concatenating
the errormessage with the basketno. Error is shown if no
sender or receipient ean is passed in instantiating
an Koha::Edifact::Order object

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm
index dcab51d..9822526 100644 (file)
--- a/Koha/Edifact/Order.pm
+++ b/Koha/Edifact/Order.pm
@@ -60,13 +60,13 @@ sub new {
         return;
     }
     if ( !$self->{recipient} ) {
-        carp
-"No vendor passed to order creation: basket = $self->{basket}->basketno()";
+        carp 'No vendor passed to order creation: basket = '
+          . $self->{basket}->basketno;
         return;
     }
     if ( !$self->{sender} ) {
-        carp
-"No sender ean passed to order creation: basket = $self->{basket}->basketno()";
+        carp 'No sender ean passed to order creation: basket = '
+          . $self->{basket}->basketno;
         return;
     }