Bug 19767: Remove unused serial-issues.pl script
authorOwen Leonard <oleonard@myacpl.org>
Mon, 11 Dec 2017 16:47:00 +0000 (16:47 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 14 Dec 2017 19:58:39 +0000 (16:58 -0300)
This patch removes three unused files:

serials/serial-issues.pl

...and its associated templates:

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt

To test, apply the patch and search the Koha codebase for references to
any of those files. None should exist.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt [deleted file]
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt [deleted file]
serials/serial-issues.pl [deleted file]

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt
deleted file mode 100644 (file)
index fb020a0..0000000
+++ /dev/null
@@ -1,97 +0,0 @@
-[% INCLUDE 'doc-head-open.inc' %]
-<title>Koha &rsaquo; Serials &rsaquo; Subscription information for biblio #[% biblionumber %] with title : [% bibliotitle %]</title>
-[% INCLUDE 'doc-head-close.inc' %]
-<script type="text/javascript">
-//<![CDATA[
-active([% yearmin %]);
-function active(numlayer)
-{
-       for (i=[% yearmin %]; i<=[% yearmax %]; i++ ) {
-               ong = i;
-               link = "link"+i;
-               if (numlayer==i) {
-                       document.getElementById(ong).style.visibility="visible";
-               } else {
-                       document.getElementById(ong).style.visibility="hidden";
-               }
-       }
-}
-//]]>
-</script>
-</head>
-<body id="ser_serial-issues-full" class="ser">
-
-[% UNLESS ( popup ) %]
-[% INCLUDE 'header.inc' %]
-[% INCLUDE 'serials-search.inc' %]
-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; Serials </div>
-
-<div id="doc3" class="yui-t2">
-   
-   <div id="bd">
-       <div id="yui-main">
-       <div class="yui-b">
-       <h1>Subscription information for biblio #[% biblionumber %] with title : [% bibliotitle %]</h1>
-       <p>
-       <a href="opac-detail.pl?biblionumber=[% biblionumber %]" class="button">Back to biblio</a>
-[% END %]
-       [% FOREACH year IN years %]
-               [% IF ( year.year ) %]
-                       <a  class="button" href="javascript:active([% year.year %])">[% year.year %]</a>
-               [% END %]
-       [% END %]
-       <a class=" button serial" href="serial-issues.pl?biblionumber=[% biblionumber %]&amp;selectview=small">Compact view</a>
-       </p>
-       [% FOREACH year IN years %]
-    [% IF ( year.first ) %]<div name="[% year.year %]" id="[% year.year %]" style="position:absolute; visibility:visible margin-top:0px; border:4px;" >
-    [% ELSE %]<div name="[% year.year %]" id="[% year.year %]" style="position:absolute; visibility:hidden; margin-top:0px; border:4px;">[% END %]
-               <table>
-                       <tr>
-                               <th>Information
-                               </th>
-                               <th>Date
-                               </th>
-                               <th>Number
-                               </th>
-                               <th>Status
-                               </th>
-                       </tr>
-                       [% FOREACH serial IN year.serials %]
-                       <tr>
-                               <td>
-                                       [% serial.notes %]
-                               </td>
-                               <td>
-                                       [% serial.planneddate %]
-                               </td>
-                               <td>
-                                       [% serial.serialseq %]
-                               </td>
-                               <td>
-                    [% IF ( serial.status1 ) %]Expected[% END %]
-                    [% IF ( serial.status2 ) %]Arrived[% END %]
-                    [% IF ( serial.status3 ) %]Late[% END %]
-                    [% IF ( serial.status4 ) %]Missing[% END %]
-                    [% IF ( serial.status41 ) %]Missing (never received)[% END %]
-                    [% IF ( serial.status42 ) %]Missing (sold out)[% END %]
-                    [% IF ( serial.status43 ) %]Missing (damaged)[% END %]
-                    [% IF ( serial.status44 ) %]Missing (lost)[% END %]
-                    [% IF ( serial.status5 ) %]Not issued[% END %]
-                    [% IF ( serial.status6 ) %]Delete[% END %]
-                    [% IF ( serial.status7 ) %]Claimed[% END %]
-                    [% IF ( serial.status8 ) %]Stopped[% END %]
-                               </td>
-                       </tr>
-                       [% END %]
-               </table>
-       </div>
-       [% END %]
-
-</div>
-</div>
-
-<div class="yui-b">
-[% INCLUDE 'serials-menu.inc' %]
-</div>
-</div>
-[% INCLUDE 'intranet-bottom.inc' %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt
deleted file mode 100644 (file)
index 7bc9feb..0000000
+++ /dev/null
@@ -1,122 +0,0 @@
-[% INCLUDE 'doc-head-open.inc' %]
-<title>Koha &rsaquo; Serials &rsaquo; Subscription information for [% bibliotitle %]</title>
-[% INCLUDE 'doc-head-close.inc' %]
-</head>
-<body id="ser_serial-issues" class="ser">
-[% INCLUDE 'header.inc' %]
-[% INCLUDE 'serials-search.inc' %]
-
-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> &rsaquo; Subscription information for <i>[% bibliotitle %]</i></div>
-
-<div id="doc3" class="yui-t2">
-   
-   <div id="bd">
-       <div id="yui-main">
-       <div class="yui-b">
-
-<h1>Subscription information for <i>[% bibliotitle %]</i></h1>
-<div id="action">
-    <a href="/cgi-bin/koha/serials/serials-search.pl?biblionumber=[% biblionumber %]">Subscriptions</a>
-    <a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% biblionumber %]">Back to biblio</a>
-    <a href="/cgi-bin/koha/serials/serial-issues.pl?biblionumber=[% biblionumber %]&amp;selectview=full">Complete view</a>
-</div>
-[% FOREACH subscription_LOO IN subscription_LOOP %]
-    <div id="serials_serial_issue_[% subscription_LOO.subscriptionid %]">
-    <h2>Subscription summary</h2>
-        <p>It began on <b>[% subscription_LOO.histstartdate %]</b> and is issued every
-        <b>
-        [% IF ( subscription_LOO.periodicity1 ) %]
-                day
-        [% END %]
-        [% IF ( subscription_LOO.periodicity2 ) %]
-                week
-        [% END %]
-        [% IF ( subscription_LOO.periodicity3 ) %]
-                2 weeks
-        [% END %]
-        [% IF ( subscription_LOO.periodicity4 ) %]
-                3 weeks
-        [% END %]
-        [% IF ( subscription_LOO.periodicity5 ) %]
-                month
-        [% END %]
-        [% IF ( subscription_LOO.periodicity6 ) %]
-                2 months
-        [% END %]
-        [% IF ( subscription_LOO.periodicity7 ) %]
-                3 months
-        [% END %]
-        [% IF ( subscription_LOO.periodicity8 ) %]
-                quarter
-        [% END %]
-        [% IF ( subscription_LOO.periodicity9 ) %]
-                2 quarters
-        [% END %]
-        [% IF ( subscription_LOO.periodicity10 ) %]
-                year
-        [% END %]
-        [% IF ( subscription_LOO.periodicity11 ) %]
-                2 years
-        [% END %]
-        </b>
-        [% IF ( subscription_LOO.arrival1 ) %]
-            on <b>Monday</b>
-        [% END %]
-        [% IF ( subscription_LOO.arrival2 ) %]
-            on <b>Tuesday</b>
-        [% END %]
-        [% IF ( subscription_LOO.arrival3 ) %]
-            on <b>Wednesday</b>
-        [% END %]
-        [% IF ( subscription_LOO.arrival4 ) %]
-            on <b>Thursday</b>
-        [% END %]
-        [% IF ( subscription_LOO.arrival5 ) %]
-            on <b>Friday</b>
-        [% END %]
-        [% IF ( subscription_LOO.arrival6 ) %]
-            on <b>Saturday</b>
-        [% END %]
-        [% IF ( subscription_LOO.arrival7 ) %]
-            on <b>Sunday</b>
-        [% END %]
-        for <b>
-            [% IF ( subscription_LOO.numberlength ) %][% subscription_LOO.numberlength %] issues[% END %]
-            [% IF ( subscription_LOO.weeklength ) %][% subscription_LOO.weeklength %] weeks[% END %]
-            [% IF ( subscription_LOO.monthlength ) %][% subscription_LOO.monthlength %] months[% END %]
-            </b>
-        </p>
-        <p>Last renewal of subscription was <b>[% subscription_LOO.startdate %]</b></p>
-        [% IF ( subscription_LOO.enddate ) %]<p><b>This subscription is now ended. The last issue was received on [% subscription_LOO.enddate %]</b></p>[% END %]
-    [% UNLESS ( subscription_LOO.fullinfo ) %]
-        <p>[% subscription_LOO.notes %]</p>
-        [% IF ( subscription_LOO.opacnote ) %]
-            <h2>Issues summary</h2>
-            <p>
-                [% subscription_LOO.opacnote %]
-            </p>
-        [% END %]
-        [% IF ( subscription_LOO.recievedlist ) %]
-            <h2>Received issues</h2>
-            <p>
-                [% subscription_LOO.recievedlist %]
-            </p>
-        [% END %]
-        [% IF ( subscription_LOO.missinglist ) %]
-            <h2>Missing issues</h2>
-            <p>
-                [% subscription_LOO.missinglist %]
-            </p>
-        [% END %]
-    </div>
-    [% END %]
-[% END %]
-
-</div>
-</div>
-
-<div class="yui-b">
-[% INCLUDE 'serials-menu.inc' %]
-</div>
-</div>
-[% INCLUDE 'intranet-bottom.inc' %]
diff --git a/serials/serial-issues.pl b/serials/serial-issues.pl
deleted file mode 100755 (executable)
index fdda1fd..0000000
+++ /dev/null
@@ -1,108 +0,0 @@
-#!/usr/bin/perl
-
-# Copyright 2000-2002 Katipo Communications
-#
-# This file is part of Koha.
-#
-# Koha is free software; you can redistribute it and/or modify it
-# under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# Koha is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Koha; if not, see <http://www.gnu.org/licenses>.
-
-
-=head1 NAME
-
-serial-issue.pl
-
-=head1 DESCRIPTION
-
-this script give more information about a susbcription given on input arg.
-
-=head1 PARAMETERS
-
-=over 4
-
-=item selectview
-can be equal to "full" or not.
-
-=item biblionumber
-the biblionumber this script has to give more infos.
-
-=back
-
-
-=cut
-
-use strict;
-use warnings;
-use CGI qw ( -utf8 );
-use C4::Auth;
-use C4::Koha;
-use C4::Serials;
-use C4::Output;
-use C4::Context;
-
-
-my $query = new CGI;
-my $dbh = C4::Context->dbh;
-my $selectview = $query->param('selectview');
-$selectview = C4::Context->preference("SubscriptionHistory") unless $selectview;
-
-my ($template, $loggedinuser, $cookie);
-my $biblionumber = $query->param('biblionumber');
-if ($selectview eq "full"){
-    my $subscriptions = GetFullSubscriptionsFromBiblionumber($biblionumber);
-
-    my $title = $subscriptions->[0]{bibliotitle};
-    my $yearmin=$subscriptions->[0]{year};
-    my $yearmax=$subscriptions->[scalar(@$subscriptions)-1]{year};
-
-    ($template, $loggedinuser, $cookie)
-     = get_template_and_user({template_name => "serials/serial-issues-full.tt",
-     query => $query,
-     type => "intranet",
-        flagsrequired => {serials => '*'},
-     });
-
- # replace CR by <br> in librarian note
- # $subscription->{opacnote} =~ s/\n/\<br\/\>/g;
-
-    $template->param(
-        biblionumber => scalar $query->param('biblionumber'),
-        years => $subscriptions,
-        yearmin => $yearmin,
-        yearmax =>$yearmax,
-        bibliotitle => $title,
-        suggestion => C4::Context->preference("suggestion"),
-        virtualshelves => C4::Context->preference("virtualshelves"),
-    );
-
-} else {
-    my $subscriptions = GetSubscriptionsFromBiblionumber($biblionumber);
-    ($template, $loggedinuser, $cookie)
-    = get_template_and_user({template_name => "serials/serial-issues.tt",
-        query => $query,
-        type => "intranet",
-           flagsrequired => {serials => '*'},
-     });
-
- # replace CR by <br> in librarian note
- # $subscription->{opacnote} =~ s/\n/\<br\/\>/g;
-
-    $template->param(
-        biblionumber => "".$query->param('biblionumber'),
-        subscription_LOOP => $subscriptions,
-        suggestion => "".C4::Context->preference("suggestion"),
-        virtualshelves => "".C4::Context->preference("virtualshelves"),
-    );
-}
-$template->param((uc(C4::Context->preference("marcflavour"))) => 1);
-output_html_with_http_headers $query, $cookie, $template->output;