Bug 14408: Add tests to get_template_and_user
authorJonathan Druart <jonathan.druart@koha-community.org>
Fri, 19 Jun 2015 08:25:30 +0000 (10:25 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 25 Jun 2015 07:40:03 +0000 (09:40 +0200)
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Mason James <mtj@kohaaloha.com>
(cherry picked from commit 5aaa108274712440c98b92efdbad8657dccfad24)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

t/db_dependent/Auth.t

index 6a100bc..095029e 100644 (file)
@@ -9,6 +9,7 @@ use CGI;
 use Test::MockModule;
 use List::MoreUtils qw/all any none/;
 use Test::More tests => 6;
+use Test::Warn;
 use C4::Members;
 use Koha::AuthUtils qw/hash_password/;
 
@@ -105,6 +106,27 @@ $dbh->{RaiseError} = 1;
 
     ok( ( any { $_->name eq 'KohaOpacLanguage' and $_->value eq 'en' } @$cookies ),
         'BZ9735: invalid language, then default to en');
+
+    for my $template_name (
+        qw(
+            ../../../../../../../../../../../../../../../etc/passwd
+            test/../../../../../../../../../../../../../../etc/passwd
+            /etc/passwd
+        )
+    ) {
+        eval {
+            ( $template, $loggedinuser, $cookies ) = get_template_and_user(
+                {
+                    template_name   => $template_name,
+                    query           => $query,
+                    type            => "intranet",
+                    authnotrequired => 1,
+                    flagsrequired   => { catalogue => 1 },
+                }
+            );
+        };
+        like ( $@, qr(^bad template path), 'The file $template_name should not be accessible' );
+    }
 }
 
 my $hash1 = hash_password('password');