Bug 21846: Fix pod2usage return values

According to existing pattern.
However I am not sure it makes sense to return an errno (and print to STDERR)
if --help is passed.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/misc/maintenance/fix_tags_weight.pl b/misc/maintenance/fix_tags_weight.pl
index 549d170..7dc3801 100755 (executable)
--- a/misc/maintenance/fix_tags_weight.pl
+++ b/misc/maintenance/fix_tags_weight.pl
@@ -65,15 +65,12 @@ binmode( STDOUT, ":encoding(UTF-8)" );
 my $help;
 my $verbose;
 
-my $result = GetOptions(
+GetOptions(
     'help|h'    => \$help,
     'verbose|v' => \$verbose
-);
+) or pod2usage(2);
 
-if ( not $result or $help ) {
-    pod2usage();
-    exit 0;
-}
+pod2usage(1) if $help;
 
 fix_tags_approval($verbose);
 fix_tags_index( $verbose );