Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 10 Jun 2020 10:03:20 +0000 (12:03 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 15 Jun 2020 08:29:53 +0000 (10:29 +0200)
It seems that this regression comes from bug 14419, but I have not found
a logic reason behind that.
This patch restores the behaviour we always had: facet groups must be
displayed in a given order: the Zebra index (au, ccode, holdingbranch,
etc.)

Test plan:
Apply this patch, restart all and confirm that the facets are not moving
up and down when you refresh your search result page.

QA note:
I think the following line must be removed
@facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop;

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

C4/Search.pm

index cd9b892..9d4f64e 100644 (file)
@@ -487,8 +487,7 @@ sub getRecords {
                 # BUILD FACETS
                 if ( $servers[ $i - 1 ] =~ /biblioserver/ ) {
                     for my $link_value (
-                        sort { $facets_counter->{$b} <=> $facets_counter->{$a} }
-                        keys %$facets_counter
+                        sort { $a cmp $b } keys %$facets_counter
                       )
                     {
                         my @this_facets_array;