Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl
authorNick Clemens <nick@bywatersolutions.com>
Mon, 13 May 2019 15:07:41 +0000 (15:07 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 14 May 2019 12:06:36 +0000 (13:06 +0100)
Backport of 22650 makes an object call to an item hashref retrieved by get item:

  94             if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) {

Should be $item->{itemnumber}

To test:
1 - Try to place an item level hold
2 - It fails
3 - Aply patch
4 - Try again
5 - It works!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

reserve/placerequest.pl

index 31b7e8c..f89720f 100755 (executable)
@@ -91,7 +91,7 @@ if ( $type eq 'str8' && $borrower ) {
             if ( $item->{'biblionumber'} ne $biblionumber ) {
                 $biblionumber = $item->{'biblionumber'};
             }
-            if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) {
+            if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->{'itemnumber'}, $branch)->{status} eq 'OK' ) {
                 AddReserve( $branch, $borrower->{'borrowernumber'},
                     $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title,
                     $checkitem, $found, $itemtype );