Bug 18411: Fix failing search_utf8.t tests
authorMark Tompsett <mtompset@hotmail.com>
Fri, 9 Jun 2017 23:23:49 +0000 (19:23 -0400)
committerKatrin Fischer <katrin.fischer.83@web.de>
Tue, 13 Jun 2017 20:38:38 +0000 (22:38 +0200)
TEST PLAN
---------
export KOHA_INTRANET_URL=...
prove -v t/db_dependent/www/search_utf8.t

something like seen before failure:
t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0: Bad Request at t/db_dependent/www/search_utf8.t line 170.

apply this patch
prove -v t/db_dependent/www/search_utf8.t

Now it is the marc staging that is failing.
And that is failing in master for me.
So, I don't think it is the test that is a problem at this point,
but the actual staged marc records process.

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
I'm not sure why you had problems. All 66 tests passed
after patch application and the patch also passes QA Tools.
I tested this patch on a brand new kohadevbox without issue.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit bd14d2db9c6f6ac34a1dc0ea4ab741c05c22e5d3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 1b228a9a29ac07518ed9f5054de22e2fb3e4a269)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

t/db_dependent/www/search_utf8.t

index 7a10888..c0d3a27 100644 (file)
@@ -168,9 +168,8 @@ sub test_search{
     # if we haven't completed the batch in two minutes, it's not happening
     for my $counter ( 1 .. 24 ) {
         $agent->get(
-            "$intranet/cgi-bin/koha/tools/background-job-progress.pl?jobID=$jobID",
-            "get job progress"
-        );
+            "$intranet/cgi-bin/koha/tools/background-job-progress.pl?jobID=$jobID"
+        ); # get job progress
         $jsonresponse = decode_json $agent->content();
         if ( $jsonresponse->{'job_status'} eq 'completed' ) {
             $completed = 1;