Bug 22743: Add password modal to overdrive results page
authorNick Clemens <nick@bywatersolutions.com>
Fri, 19 Apr 2019 11:25:43 +0000 (11:25 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 23 May 2019 20:53:16 +0000 (20:53 +0000)
This patch also removes a line abotu ratings which was throwing an error.
Confirm stars rating for OD results are still shown as expected

To test:
 1 - Enable overdrive circulation with password required
 2 - Sign in to OPAC but not overdrive
 3 - Perform a search that returns overdrive results
 4 - Click in to results page
     http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats
 5 - Note 'Login to OverDrive account' link
 6 - Click it
 7 - Nothing happens!
 8 - Apply patch
 9 - Repeat
10 - Success!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 7be176cf1da5adb5f264bb9668667dfeb1d9a2ae)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 461c7176735cbfd4ed7db97a9fa094b60ac2e0ca)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt

index 29caf86..6a1a190 100644 (file)
         </div> <!-- / .container-fluid -->
     </div> <!-- / .main -->
 
-[% INCLUDE 'overdrive-checkout.inc' %]
+[% IF ( Koha.Preference('OverDriveCirculation') ) %]
+    [% INCLUDE 'overdrive-checkout.inc' %]
+    [% IF ( Koha.Preference('OverDrivePasswordRequired') ) %]
+        [% INCLUDE 'overdrive-login.inc' %]
+    [% END %]
+[% END %]
 
 [% INCLUDE 'opac-bottom.inc' %]
 [% BLOCK jsinclude %]
@@ -171,7 +176,6 @@ function search( offset ) {
 
         if ( pages.length > 1 ) $( '#top-pages, #bottom-pages' ).find( '.pagination' ).html( '<ul>' + pages.join( '' ) + '</ul>');
 
-        $( '#overdrive-results-list input.star' ).rating();
     } );
 }