Bug 17257: Fix add/edit patrons under MySQL 5.7
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 6 Sep 2016 09:12:20 +0000 (10:12 +0100)
committerJulian Maurice <julian.maurice@biblibre.com>
Mon, 22 May 2017 10:56:18 +0000 (12:56 +0200)
If no guarantor is defined the patron won't be added/modified and an
error will be raised:

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'guarantorid'

Test plan:
Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES)
Create a patron without guarantor

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>

Tested with MariaDB 10.0.30 (sql_mode='STRICT_TRANS_TABLES')
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 720071004516ec4e119dc5ec7f9538b56313b186)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(cherry picked from commit 63823bbfcd66191f88b5f9359b1a743e71d69348)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

C4/Members.pm

index fe40188..6eff6d7 100644 (file)
@@ -759,6 +759,7 @@ sub AddMember {
     # we don't want invalid dates in the db (mysql has a bad habit of inserting 0000-00-00
     $data{'dateofbirth'} = undef if( not $data{'dateofbirth'} );
     $data{'debarred'} = undef if ( not $data{'debarred'} );
+    $data{'guarantorid'} = undef if ( not $data{'guarantorid'} );
 
     # get only the columns of Borrower
     my @columns = $schema->source('Borrower')->columns;