Bug 21837: Don't set holdingbranch filter using selected homebranch filter
authorNick Clemens <nick@bywatersolutions.com>
Wed, 14 Nov 2018 19:08:09 +0000 (19:08 +0000)
committerJesse Maseto <jesse@bywatersolution.com>
Fri, 7 Dec 2018 21:21:36 +0000 (21:21 +0000)
To recreate:
1 - Open the overdues report (don't worry if you don't have results)
2 - Choose to filter by homebranch
3 - Note the holdingbranch filter is set to the selected homebranch
4 - Apply patch
5 - Clear filters
6 - repeat
7 - only homebranch is set

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 81ac96abec1226b6635022c0a3f69697d13c7d62)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>

circ/overdue.pl

index e60d3cc..635de46 100755 (executable)
@@ -183,7 +183,7 @@ $template->param(
     patron_attr_header_loop => [ map { { header => $_->{description} } } grep { ! $_->{isclone} } @patron_attr_filter_loop ],
     branchfilter => $branchfilter,
     homebranchfilter => $homebranchfilter,
-    holdingbranchfilter => $homebranchfilter,
+    holdingbranchfilter => $holdingbranchfilter,
     borcatloop=> \@borcatloop,
     itemtypeloop => \@itemtypeloop,
     patron_attr_filter_loop => \@patron_attr_filter_loop,