Bug 20827: Display Fund's owner name when selected
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 28 May 2018 14:40:20 +0000 (11:40 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 7 Jun 2018 08:13:19 +0000 (10:13 +0200)
When a fund is created or edited and does not have a owner yet, the
name of the patron will not be displayed when selected.

The HTML element the JS code expects is not present in the DOM.

Test plan:
- Create a fund, set a owner
- remove the owner, edit, etc.
- Save
- Edit again
Make sure it works as expected.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit dc396756a050bf3fe07bb3141df6535a27fd9afb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit b344b81e24b63e4451c49909436a98cfcc71a622)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt

index a3c9ee9..d997735 100644 (file)
@@ -35,7 +35,7 @@ var MSG_PARENT_BENEATH_BUDGET = "- " + _("New budget-parent is beneath budget")
 
     function select_user(borrowernumber, borrower) {
         ownerRemove();
-        var borrowername = borrower.firstname + ' ' + borrower.surname
+        var borrowername = borrower.firstname + ' ' + borrower.surname;
         if (borrowernumber) {
             var ownerlink = '<a href="/cgi-bin/koha/members/moremember.pl'
                 + '?borrowernumber=' + borrowernumber + '">'
@@ -508,6 +508,8 @@ var MSG_PARENT_BENEATH_BUDGET = "- " + _("New budget-parent is beneath budget")
                     [% budget_owner_name %]
                 </a> |
             </span>
+        [% ELSE %]
+            <span  id="budget_owner_name"></span>
         [% END %]
         <a id="edit_owner" class="new_window" href="#"><i class="fa fa-search"></i> Select owner</a>
         <a id="remove_owner" href="#"><i class="fa fa-trash"></i> Remove owner</a>