Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete

Wrong replacement in additem.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
index 4281658..ec27c1a 100755 (executable)
--- a/cataloguing/additem.pl
+++ b/cataloguing/additem.pl
@@ -670,7 +670,7 @@ if ($op eq "additem") {
 #-------------------------------------------------------------------------------
     # check that there is no issue on this item before deletion.
     my $item = Koha::Items->find($itemnumber);
-    $error = $item->safe_to_delete;
+    $error = $item->safe_delete;
     if($error ne '1'){
         print $input->redirect("additem.pl?biblionumber=$biblionumber&frameworkcode=$frameworkcode&searchid=$searchid");
     }else{

diff --git a/tools/batch_delete_records.pl b/tools/batch_delete_records.pl
index 7604a96..d1ab80c 100755 (executable)
--- a/tools/batch_delete_records.pl
+++ b/tools/batch_delete_records.pl
@@ -183,7 +183,7 @@ if ( $op eq 'form' ) {
                         type => 'error',
                         code => 'item_not_deleted',
                         biblionumber => $biblionumber,
-                        itemnumber => $itemnumber,
+                        itemnumber => $item->itemnumber,
                         error => ($@ ? $@ : $error),
                     };
                     $schema->storage->txn_rollback;