Bug 21973: Do not url escape casServerUrl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 7 Dec 2018 13:26:02 +0000 (10:26 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 14 Dec 2018 13:32:14 +0000 (13:32 +0000)
It is already escaped correctly in
C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape

Note that shibbolethLoginUrl is not and must be url escaped in template
("be consistent, they said")

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt

index 71edf3c..d8aeabe 100644 (file)
@@ -97,7 +97,7 @@
                         [% IF ( casAuthentication ) %]
                             [% IF ( shibbolethAuthentication ) %]
                                 [% IF ( casServerUrl ) %]
-                                    <p><a href="[% casServerUrl | url %]">Please click here to log in.</a><p>
+                                    <p><a href="[% casServerUrl | $raw %]">Please click here to log in.</a><p>
                                 [% END %]
 
                                 [% IF ( casServersLoop ) %]
                                 [% END %]
 
                                 [% IF ( casServerUrl ) %]
-                                   <p><a href="[% casServerUrl | url %]">If you have a CAS account, please click here to log in.</a><p>
+                                   <p><a href="[% casServerUrl | $raw %]">If you have a CAS account, please click here to log in.</a><p>
                                 [% END %]
 
                                 [% IF ( casServersLoop ) %]