Bug 24367: Resolve warn Argument available is not numeric in delete
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 10 Jan 2020 07:54:33 +0000 (07:54 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 19 Feb 2020 11:22:14 +0000 (11:22 +0000)
Argument "available" isn't numeric in delete at /usr/share/koha/C4/Search.pm line 1480.
The construction delete array[string] simply does not work.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

C4/Search.pm

index dc620ba..4ca9e01 100644 (file)
@@ -1477,7 +1477,7 @@ sub buildQuery {
         if ( @limits ) {
             if ( grep { $_ eq 'available' } @limits ) {
                 $q .= q| and ( (allrecords,AlwaysMatches='') and (not-onloan-count,st-numeric >= 1) and (lost,st-numeric=0) )|;
-                delete $limits['available'];
+                @limits = grep {!/^available$/} @limits;
             }
             $q .= ' and '.join(' and ', @limits) if @limits;
         }