Bug 17829: Fix import patron
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 25 Jul 2017 13:29:06 +0000 (10:29 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 25 Jul 2017 13:29:08 +0000 (10:29 -0300)
Can't call method "unblessed" on an undefined value at
/home/vagrant/kohaclone/tools/import_borrowers.pl line 230, <$fh> line 2.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

tools/import_borrowers.pl

index 76dc299..66190e2 100755 (executable)
@@ -227,15 +227,9 @@ if ( $uploadborrowers && length($uploadborrowers) > 0 ) {
         my $borrowernumber;
         my $member;
         if ( ($matchpoint eq 'cardnumber') && ($borrower{'cardnumber'}) ) {
-            $member = Koha::Patrons->find( { cardnumber => $borrower{'cardnumber'} } )->unblessed;
-            if ($member) {
-                $borrowernumber = $member->{'borrowernumber'};
-            }
+            $member = Koha::Patrons->find( { cardnumber => $borrower{'cardnumber'} } );
         } elsif ( ($matchpoint eq 'userid') && ($borrower{'userid'}) ) {
             $member = Koha::Patrons->find( { userid => $borrower{'userid'} } )->unblessed;
-            if ($member) {
-                $borrowernumber = $member->{'borrowernumber'};
-            }
         } elsif ($extended) {
             if (defined($matchpoint_attr_type)) {
                 foreach my $attr (@$patron_attributes) {
@@ -248,6 +242,13 @@ if ( $uploadborrowers && length($uploadborrowers) > 0 ) {
             }
         }
 
+        if ($member) {
+            $member = $member->unblessed;
+            $borrowernumber = $member->{'borrowernumber'};
+        } else {
+            $member = {};
+        }
+
         if ( C4::Members::checkcardnumber( $borrower{cardnumber}, $borrowernumber ) ) {
             push @errors, {
                 invalid_cardnumber => 1,