Bug 21011: Search for items with not defined homebranch and/or holdingbranch

From bug 5789: scripts can fail if items.homebranch and/or
items.holdingbranch is not defined

This script will help people catching these migration issues.

Test plan:
Update your items table to set some homebranch or holdingbranch to NULL
Run this script
It will display the different items with not defined values in these
fields.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 7d47bb311827298ddc30297bbd388e8f8905db48)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
new file mode 100644 (file)
index 0000000..5105f6c
--- /dev/null
+++ b/misc/maintenance/search_for_data_inconsistencies.pl
@@ -0,0 +1,67 @@
+#!/usr/bin/perl
+
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use Modern::Perl;
+
+use Koha::Items;
+
+{
+    my $items = Koha::Items->search({ -or => { homebranch => undef, holdingbranch => undef }});
+    if ( $items->count ) { new_section("Not defined items.homebranch and/or items.holdingbranch")}
+    while ( my $item = $items->next ) {
+        if ( not $item->homebranch and not $item->holdingbranch ) {
+            new_item(sprintf "Item with itemnumber=%s does not have homebranch and holdingbranch defined", $item->itemnumber);
+        } elsif ( $item->homebranch ) {
+            new_item(sprintf "Item with itemnumber=%s does not have homebranch defined", $item->itemnumber);
+        } else {
+            new_item(sprintf "Item with itemnumber=%s does not have holdingbranch defined", $item->itemnumber);
+        }
+    }
+    if ( $items->count ) { new_hint("Edit these items and set valid homebranch and/or holdingbranch")}
+}
+
+sub new_section {
+    my ( $name ) = @_;
+    say "\n== $name ==";
+}
+
+sub new_item {
+    my ( $name ) = @_;
+    say "\t* $name";
+}
+sub new_hint {
+    my ( $name ) = @_;
+    say "=> $name";
+}
+
+=head1 NAME
+
+search_for_data_inconsistencies.pl
+
+=head1 SYNOPSIS
+
+    perl search_for_data_inconsistencies.pl
+
+=head1 DESCRIPTION
+
+Catch data inconsistencies in Koha database
+
+* Items with not defined homebranch and/or holdingbranch
+
+=back
+
+=cut