Bug 10825: don't display enum/chron twice for items received via the serials module
authorMason James <mtj@kohaaloha.com>
Mon, 16 Sep 2013 03:12:16 +0000 (15:12 +1200)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 13 Aug 2014 14:24:26 +0000 (10:24 -0400)
TEST PLAN
---------
1) In the staff interface, display a bib that has one or more items
   that were received in the serials module.  The following query
   can identify them:
   -- in MySQL:
      SELECT items.biblionumber,items.enumchron,serial.serialseq
      FROM items,serial,serialitems
      WHERE items.itemnumber=serialitems.itemnumber
        AND serialitems.serialid=serial.serialid;
2) Note that in the holdings tab, the serial enumeration/chronology
   is displayed twice.
3) Apply the patch
4) Refresh the screen
4) Now, the enum/chron should be displayed only once per item.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Template change only.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 3f5636cac39ca1109a73b40be08d9dbef096a17c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 8ade958e84035b7132f2f9eb1837f137cc7937c6)

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

index 882e342..a83f4e3 100644 (file)
@@ -512,11 +512,17 @@ function verify_images() {
                     [% IF ( volinfo ) %]
                         <td class="enumchron">
                             [% IF ( itemdata_enumchron ) %]
-                                [% IF ( item.enumchron ) %]
+                                [% IF item.enumchron && item.serialseq %]
                                     [% item.enumchron %]
-                                    [% IF ( item.serialseq ) %] -- [% END %]
+                                    [% IF ( item.serialseq &&
+                                            item.enumchron!=item.serialseq ) %]
+                                       -- [% item.serialseq %]
+                                    [% END %]
+                                [% ELSIF item.enumchron %]
+                                    [% item.enumchron %]
+                                [% ELSIF item.serialseq %]
+                                    [% item.serialseq %]
                                 [% END %]
-                                [% item.serialseq %]
                                 [% IF ( item.publisheddate ) %] ([% item.publisheddate %])[% END %]
                             [% END %]
                         </td>