Bug 21990: Replace dialog .error with .alert
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 12 Dec 2018 15:22:47 +0000 (12:22 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 16 Jan 2019 08:19:10 +0000 (09:19 +0100)
<div class="dialog error"> will display a div without background color, the correct class is "dialog alert".

https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages

Test plan:
Hit /cgi-bin/koha/acqui/parcel.pl
Notice the background color change with and without this patch

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit d44a42e417b563f501f038cc5226eda0f5fb3ca5)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 1f5aa58a2ce0b6f1bf076a50cbbd2f728b47d0e1)

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
(cherry picked from commit 03631164c5d683c92d4728b416e094994c9fc14a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt

index 02e1d4c..e4677ab 100644 (file)
     [% END %]
 
     [% IF (error_cancelling_receipt) %]
-      <div class="dialog error">
+      <div class="dialog alert">
       Cannot cancel receipt. Possible reasons :
       <ul>
         <li>
     [% END %]
 
     [% IF error_invoice_not_known %]
-        <div class="dialog error">
+        <div class="dialog alert">
             The invoice referenced by this invoiceid does not exist.
         </div>
     [% END %]
index 868aea2..6c18c71 100644 (file)
@@ -101,7 +101,7 @@ $(document).ready(function() {
     [% ELSIF message.type == 'warning' %]
       <div class="dialog alert">
     [% ELSIF message.type == 'error' %]
-      <div class="dialog error" style="margin:auto;">
+      <div class="dialog alert" style="margin:auto;">
     [% END %]
     [% IF message.code == 'biblio_not_exists' %]
       The biblionumber [% message.biblionumber |html %] does not exist in the database.