fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield...

to test...

1/ attempt to add a new bib in the cataloguing editor, default framewok
  - observe 245b subfield is visible in the editor, for tab 2

2/ uncheck the OPAC visibility for 245b, within the framework editor - then save

3/ repeat step 1/
  - observe that the 245b subfield has disappeared from the cataloguing editor!

4/ apply patch,

5/ repeat step 1/
  - observe that the 245b subfield now displays correctly in the cataloguing editor

note: this looks looks like a typo bug, that has been in koha for years

Signed-off-by: wajasu <matted@34813.mypacks.net>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index 5b06706..645a30a 100755 (executable)
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -653,8 +653,8 @@ sub build_tabs {
                 foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) {
                     next if ( length $subfield != 1 );
                     next
-                      if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -5 )
-                        or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 4 ) )
+                      if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -4 )
+                        or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 5 ) )
                       and not ( $subfield eq "9" and
                                 exists($tagslib->{$tag}->{'a'}->{authtypecode}) and
                                 defined($tagslib->{$tag}->{'a'}->{authtypecode}) and