Bug 22478: (QA follow-up) Make test consistent with variable name
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 26 Apr 2019 18:56:43 +0000 (19:56 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 29 Apr 2019 01:49:10 +0000 (01:49 +0000)
We were adding data to category 1 (private lists) and testing against
that, but we named the variable 'publist_lists'.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 5977db6738a50f398e9049db39d8a8e622546f2e)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

t/db_dependent/selenium/regressions.t

index 7ea7e0b..d636a4b 100644 (file)
@@ -176,7 +176,7 @@ subtest 'XSS vulnerabilities in pagination' => sub {
             {
                 class => 'Koha::Virtualshelves',
                 value => {
-                    category                 => 1,
+                    category                 => 2,
                     allow_change_from_owner  => 1,
                     allow_change_from_others => 0,
                     owner                    => $patron->borrowernumber
@@ -190,7 +190,7 @@ subtest 'XSS vulnerabilities in pagination' => sub {
     $patron->set_password({ password => $password });
     $s->opac_auth( $patron->userid, $password );
 
-    my $public_lists = $s->opac_base_url . q|opac-shelves.pl?op=list&category=1|;
+    my $public_lists = $s->opac_base_url . q|opac-shelves.pl?op=list&category=2|;
     $driver->get($public_lists);
 
     $s->remove_error_handler;
@@ -199,7 +199,7 @@ subtest 'XSS vulnerabilities in pagination' => sub {
     is( $alert_text, undef, 'No alert box displayed' );
 
     my $booh_alert = 'booh!';
-    $public_lists = $s->opac_base_url . qq|opac-shelves.pl?op=list&category=1"><script>alert('$booh_alert')</script>|;
+    $public_lists = $s->opac_base_url . qq|opac-shelves.pl?op=list&category=2"><script>alert('$booh_alert')</script>|;
     $driver->get($public_lists);
 
     $s->remove_error_handler;