Bug 14816: Fix multiple selection in item search
authorJulian Maurice <julian.maurice@biblibre.com>
Thu, 7 Jan 2016 14:38:57 +0000 (15:38 +0100)
committerBrendan Gallagher <bredan@bywatersolutions.com>
Wed, 20 Apr 2016 21:00:49 +0000 (21:00 +0000)
Send each selected value as a separate parameter. Otherwise DataTables
(or jQuery ?) joins all values with a comma

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I could not reproduce the bug when selecting multiple home libraries,
but I could by selecting multiple item types or collection codes. The
patch allowed those queries to complete correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt

index 15cbb91..09e6b84 100644 (file)
       $('#results-wrapper').empty().html(results_heading + table);
 
       var params = [];
-      $form.find('select,input[type="text"],input[type="hidden"]').not('[disabled]').each(function () {
+      $form.find('select').not('[disabled]').find('option:selected').each(function () {
+        var name = $(this).parent('select').attr('name');
+        var value = $(this).val();
+        params.push({ 'name': name, 'value': value });
+      });
+      $form.find('input[type="text"],input[type="hidden"]').not('[disabled]').each(function () {
         params.push({ 'name': $(this).attr('name'), 'value': $(this).val() });
       });
       $form.find('input[type="radio"]:checked').each(function() {