Revert "Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues"
authorMason James <mtj@kohaaloha.com>
Fri, 27 Feb 2015 14:17:49 +0000 (03:17 +1300)
committerMason James <mtj@kohaaloha.com>
Fri, 27 Feb 2015 14:20:42 +0000 (03:20 +1300)
This reverts commit 081ce4ba27ec032e70a57d7f056e8aaa23490542.

Koha/Cache.pm

index 0643903..826a4cb 100644 (file)
@@ -41,6 +41,7 @@ use warnings;
 use Carp;
 use Module::Load::Conditional qw(can_load);
 use Koha::Cache::Object;
+use C4::Context;
 
 use base qw(Class::Accessor);
 
@@ -132,28 +133,16 @@ sub _initialize_memcached {
 
 sub _initialize_fastmmap {
     my ($self) = @_;
-    my ($cache, $share_file);
-
-    # Temporary workaround to catch fatal errors when: C4::Context module
-    # is not loaded beforehand, or Cache::FastMmap init fails for whatever
-    # other reason (e.g. due to permission issues - see Bug 13431)
-    eval {
-        $share_file = join( '-',
-            "/tmp/sharefile-koha", $self->{'namespace'},
-            C4::Context->config('hostname'), C4::Context->config('database') );
-
-        $cache = Cache::FastMmap->new(
-            'share_file'  => $share_file,
-            'expire_time' => $self->{'timeout'},
-            'unlink_on_exit' => 0,
-        );
-    };
-    if ( $@ ) {
-        warn "FastMmap cache initialization failed: $@";
-        return;
-    }
-    return unless defined $cache;
-    $self->{'fastmmap_cache'} = $cache;
+    my $share_file = join( '-',
+        "/tmp/sharefile-koha", $self->{'namespace'},
+        C4::Context->config('hostname'), C4::Context->config('database'),
+        "" . getpwuid($>) );
+
+    $self->{'fastmmap_cache'} = Cache::FastMmap->new(
+        'share_file'  => $share_file,
+        'expire_time' => $self->{'timeout'},
+        'unlink_on_exit' => 0,
+    );
     return $self;
 }