Bug 12885: Fix if url contains +*... and HTML5 Media is enabled
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 15 Jul 2015 11:49:03 +0000 (12:49 +0100)
committerMason James <mtj@kohaaloha.com>
Mon, 28 Sep 2015 12:06:41 +0000 (01:06 +1300)
The special regex chars are not escaped in C4::HTML5Media.

Test plan:
1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley
2/ Enable the pref HTML5Media
3/ Go on the detail page
It should not explode.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 085d766a0524e399d0c9c9e807d8c0acd0da6a19)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>

C4/HTML5Media.pm

index 89620d3..88427b4 100644 (file)
@@ -110,7 +110,7 @@ sub gethtml5media {
         }
         # extension
         $HTML5Media{extension} = ($HTML5Media{srcblock} =~ m/([^.]+)$/)[0];
-        if ( !grep /$HTML5Media{extension}/, @HTML5MediaExtensions ) {
+        if ( !grep /\Q$HTML5Media{extension}\E/, @HTML5MediaExtensions ) {
             next; # not a specified media file
         }
         # mime